Sign upLogin

honeybee/trellis

View on GitHub
Star

Showing 223 of 223 total issues

Method execute has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function execute($value, EntityInterface $entity = null)
    {
        if (!is_string($value)) {
            $this->throwError('non_string_value', [ 'value' => $value ], IncidentInterface::CRITICAL);
            return false;
Severity: Minor
Found in src/Runtime/Validator/Rule/Type/SpoofcheckerRule.php - About 1 hr to fix

    Function extractData has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function extractData(BaseObjectInterface $object)
    {
        $data = [ self::OBJECT_TYPE => get_class($object) ];
        $hidden_properties = $object->getHiddenProperties();
    Severity: Minor
    Found in src/Common/BaseObject.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function execute has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function execute($value, EntityInterface $entity = null)
    {
        if (!is_string($value)) {
            $this->throwError('non_string_value', [ 'value' => $value ], IncidentInterface::CRITICAL);
            return false;
    Severity: Minor
    Found in src/Runtime/Validator/Rule/Type/SpoofcheckerRule.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function execute has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function execute($value, EntityInterface $entity = null)
    {
        if ($value === '') {
            $value = $this->getOption(
                AttributeInterface::OPTION_NULL_VALUE,
    Severity: Minor
    Found in src/Runtime/Validator/Rule/Type/IntegerRule.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    <?php

namespace Trellis\Runtime\Attribute\ImageList;

use Trellis\Runtime\Attribute\HandlesFileListInterface;
    Severity: Major
    Found in src/Runtime/Attribute/ImageList/ImageListAttribute.php and 1 other location - About 1 hr to fix
    src/Runtime/Attribute/AssetList/AssetListAttribute.php on lines 1..72

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 119.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    <?php

namespace Trellis\Runtime\Attribute\AssetList;

use Trellis\Runtime\Attribute\HandlesFileListInterface;
    Severity: Major
    Found in src/Runtime/Attribute/AssetList/AssetListAttribute.php and 1 other location - About 1 hr to fix
    src/Runtime/Attribute/ImageList/ImageListAttribute.php on lines 1..72

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 119.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method execute has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function execute($value, EntityInterface $entity = null)
    {
        try {
            if (is_array($value)) {
                if (!empty($value) && !$this->isAssoc($value)) {
    Severity: Minor
    Found in src/Runtime/Attribute/Image/ImageRule.php - About 1 hr to fix

      Method createValueHolder has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function createValueHolder($apply_default_values = false)
    {
        if (!$this->value_holder_implementor) {
            $implementor = $this->hasOption(self::OPTION_VALUE_HOLDER)
                ? $this->getOption(self::OPTION_VALUE_HOLDER)
      Severity: Minor
      Found in src/Runtime/Attribute/Attribute.php - About 1 hr to fix

        Method createComplexValue has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function createComplexValue(AttributeInterface $attribute, array $options = array())
    {
        $values = array();
        $value_holder = $attribute->createValueHolder();
        $value_type = $value_holder->getValueType();
        Severity: Minor
        Found in src/Sham/DataGenerator.php - About 1 hr to fix

          Function getMetadataOptions has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function getMetadataOptions()
    {
        $options = $this->getOptions();

        $value_type = self::METADATA_VALUE_TYPE_SCALAR;
          Severity: Minor
          Found in src/Runtime/Attribute/Image/ImageRule.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function execute has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function execute($values, EntityInterface $entity = null)
    {
        if (!is_array($values)) {
            $this->throwError('non_array_value', [], IncidentInterface::CRITICAL);
            return false;
          Severity: Minor
          Found in src/Runtime/Attribute/TextList/TextListRule.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getMetadataOptions has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function getMetadataOptions()
    {
        $options = $this->getOptions();

        $value_type = self::METADATA_VALUE_TYPE_SCALAR;
          Severity: Minor
          Found in src/Runtime/Attribute/Asset/AssetRule.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method execute has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function execute($value, EntityInterface $entity = null)
    {
        try {
            if (is_array($value)) {
                if (!empty($value) && !$this->isAssoc($value)) {
          Severity: Minor
          Found in src/Runtime/Attribute/Asset/AssetRule.php - About 1 hr to fix

            Function getUrlFromArray has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function getUrlFromArray(array $url_parts)
    {
        // generate the resulting URL
        $url = $url_parts['scheme'] . $this->getOption(self::OPTION_SCHEME_SEPARATOR, '://');
            Severity: Minor
            Found in src/Runtime/Validator/Rule/Type/UrlRule.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function __construct has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                public function __construct(array $data)
    {
        // check for mandatory property values
        foreach ($this->getMandatoryPropertyNames() as $name) {
            if (!array_key_exists($name, $data)) {
            Severity: Minor
            Found in src/Runtime/Attribute/GeoPoint/GeoPoint.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if ($this->hasOption(self::OPTION_MIN_VALUE)) {
            $min = filter_var($this->getOption(self::OPTION_MIN_VALUE), FILTER_VALIDATE_FLOAT, $filter_flags);
            if ($min === false) {
                throw new InvalidConfigException('Minimum value specified is not interpretable as float.');
            }
            Severity: Major
            Found in src/Runtime/Validator/Rule/Type/FloatRule.php and 1 other location - About 1 hr to fix
            src/Runtime/Attribute/IntegerList/IntegerListRule.php on lines 48..66

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 112.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if ($this->hasOption(self::OPTION_MAX_VALUE)) {
            $max = filter_var($this->getOption(self::OPTION_MAX_VALUE), FILTER_VALIDATE_FLOAT, $filter_flags);
            if ($max === false) {
                throw new InvalidConfigException('Maximum value specified is not interpretable as float.');
            }
            Severity: Major
            Found in src/Runtime/Validator/Rule/Type/FloatRule.php and 1 other location - About 1 hr to fix
            src/Runtime/Attribute/IntegerList/IntegerListRule.php on lines 69..87

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 112.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        if ($this->hasOption(self::OPTION_MIN_VALUE)) {
                $min = filter_var(
                    $this->getOption(self::OPTION_MIN_VALUE),
                    FILTER_VALIDATE_INT,
                    $filter_flags
            Severity: Major
            Found in src/Runtime/Attribute/IntegerList/IntegerListRule.php and 1 other location - About 1 hr to fix
            src/Runtime/Validator/Rule/Type/FloatRule.php on lines 125..138

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 112.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        if ($this->hasOption(self::OPTION_MAX_VALUE)) {
                $max = filter_var(
                    $this->getOption(self::OPTION_MAX_VALUE),
                    FILTER_VALIDATE_INT,
                    $filter_flags
            Severity: Major
            Found in src/Runtime/Attribute/IntegerList/IntegerListRule.php and 1 other location - About 1 hr to fix
            src/Runtime/Validator/Rule/Type/FloatRule.php on lines 141..154

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 112.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method getAttributeValueByPath has 39 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static function getAttributeValueByPath(EntityInterface $entity, $value_path)
    {
        if (!mb_strpos($value_path, self::PATH_DELIMITER)) {
            return $entity->getValue($value_path);
        }
            Severity: Minor
            Found in src/Runtime/Attribute/AttributeValuePath.php - About 1 hr to fix
              Severity
              Category
              Status
              Source
              Language