Sign upLogin

hrntsm/Tunny

View on GitHub
Star

Showing 123 of 131 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        public void ParallelCoordinate(string objectiveName, int objectiveIndex, string[] variableNames)
        {
            PyModule ps = Py.CreateScope();
            ps.Exec(ReadFileFromResource.Text("Optuna.Visualization.Python.plot_parallel_coordinate.py"));
            dynamic visualize = ps.Get("plot_parallel_coordinate");
Severity: Major
Found in Optuna/Visualization/Visualization.cs and 1 other location - About 1 hr to fix
Optuna/Visualization/Visualization.cs on lines 78..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method GetParetoFrontTrials2D has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        private static Trial.Trial[] GetParetoFrontTrials2D(List<Trial.Trial> trials, StudyDirection[] directions)
        {
            List<Trial.Trial> targetTrials = trials.FindAll(trial => trial.State == TrialState.COMPLETE);

            int nTrials = targetTrials.Count;
Severity: Minor
Found in Optuna/Study/MultiObjective.cs - About 1 hr to fix

    Method CheckOptimizeComplete has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            private bool CheckOptimizeComplete(OptimizationHandlingInfo optInfo, int trialNum, DateTime startTime)
        {
            TLog.MethodStart();

            int nTrials = optInfo.NTrials;
    Severity: Minor
    Found in Tunny/Solver/Algorithm.cs - About 1 hr to fix

      Method SetAttributeEachItem has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              private void SetAttributeEachItem(StringBuilder sb, KeyValuePair<string, object> attr)
        {
            var valueStrings = new StringBuilder();
            if (attr.Key == "Geometry")
            {
      Severity: Minor
      Found in Tunny/Type/GH_Fish.cs - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                public dynamic CreateNewTStorage(bool useInnerPythonEngine, Settings.Storage storageSetting)
        {
            TLog.MethodStart();
            string storagePath = storageSetting.GetOptunaStoragePathByExtension();
            if (useInnerPythonEngine)
        Severity: Major
        Found in Tunny.Core/Storage/JournalStorage.cs and 1 other location - About 1 hr to fix
        Tunny.Core/Storage/SqliteStorage.cs on lines 16..35

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method GetAttributes has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                public Dictionary<string, List<string>> GetAttributes()
        {
            TLog.MethodStart();
            var attrs = new Dictionary<string, List<string>>();
            if (_attributes.Value == null)
        Severity: Minor
        Found in Tunny/Util/GrasshopperInOut.cs - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  protected override void SolveInstance(IGH_DataAccess DA)
        {
            int paramCount = Params.Input.Count;
            var dict = new Dictionary<string, object>();
          Severity: Major
          Found in Tunny/Component/Operation/ConstructFishAttribute.cs and 1 other location - About 1 hr to fix
          Tunny/Component/Obsolete/ConstructFishAttribute_v0_11_1.cs on lines 48..61

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 101.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  protected override void SolveInstance(IGH_DataAccess DA)
        {
            int paramCount = Params.Input.Count;
            var dict = new Dictionary<string, object>();
          Severity: Major
          Found in Tunny/Component/Obsolete/ConstructFishAttribute_v0_11_1.cs and 1 other location - About 1 hr to fix
          Tunny/Component/Operation/ConstructFishAttribute.cs on lines 51..64

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 101.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method SetParamsValue has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  private static void SetParamsValue(List<IGH_Param> sources, List<double> numbers, List<Bitmap> images, List<GeometryBase> geometries)
        {
            TLog.MethodStart();
            foreach (IGH_StructureEnumerator ghEnumerator in sources.Select(objective => objective.VolatileData.AllData(false)))
            {
          Severity: Minor
          Found in Tunny/Input/Objective.cs - About 1 hr to fix

            Method FilterInputVariables has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    private bool FilterInputVariables()
        {
            TLog.MethodStart();
            var errorInputGuids = new List<Guid>();
            foreach ((IGH_DocumentObject docObject, int _) in _inputGuids.Select((guid, i) => (_document.FindObject(guid, false), i)))
            Severity: Minor
            Found in Tunny/Util/GrasshopperInOut.cs - About 1 hr to fix

              Method SetTrialUserAttr has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      private static void SetTrialUserAttr(TrialGrasshopperItems result, dynamic trial, OptimizationHandlingInfo optSet)
        {
            TLog.MethodStart();
            if (result.GeometryJson.Length != 0)
            {
              Severity: Minor
              Found in Tunny/Solver/Algorithm.cs - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        private bool ShowIncorrectVariableInputMessage(IEnumerable<Guid> errorGuids)
        {
            TLog.MethodStart();
            TunnyMessageBox.Show(
                "Input variables must be either a number slider or a gene pool.\nError input will automatically remove.",
                Severity: Major
                Found in Tunny/Util/GrasshopperInOut.cs and 1 other location - About 1 hr to fix
                Tunny/Util/GrasshopperInOut.cs on lines 279..290

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 99.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        private bool ShowIncorrectObjectiveInputMessage(List<IGH_Param> unsupportedSources)
        {
            TLog.MethodStart();
            TunnyMessageBox.Show("Objective supports only the Number or FishPrint input.\nError input will automatically remove.", "Tunny", MessageBoxButtons.OK, MessageBoxIcon.Error);
            foreach (IGH_Param unsupportedSource in unsupportedSources)
                Severity: Major
                Found in Tunny/Util/GrasshopperInOut.cs and 1 other location - About 1 hr to fix
                Tunny/Util/GrasshopperInOut.cs on lines 127..141

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 99.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method HumanSliderInputOptimization has 9 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        private void HumanSliderInputOptimization(int nBatch, double timeout, string[] directions, dynamic sampler, dynamic storage, dynamic artifactBackend, out Parameter[] parameter, out TrialGrasshopperItems result, out dynamic study)
                Severity: Major
                Found in Tunny/Solver/Algorithm.cs - About 1 hr to fix

                  Method NormalOptimization has 9 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          private void NormalOptimization(int nTrials, double timeout, string[] directions, dynamic sampler, dynamic storage, dynamic artifactBackend, out Parameter[] parameter, out TrialGrasshopperItems result, out dynamic study)
                  Severity: Major
                  Found in Tunny/Solver/Algorithm.cs - About 1 hr to fix

                    Method GetStudyDirections has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            public StudyDirection[] GetStudyDirections(int studyId)
        {
            if (_studies.TryGetValue(studyId, out Study.Study value))
            {
                return value.Directions;
                    Severity: Minor
                    Found in Optuna/Storage/RDB/Storage.cs - About 1 hr to fix

                      Function truncate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                      Open

                      def truncate(fig, study: Study) -> go.Figure:
    user_attr = study.trials[0].user_attrs
    has_geometry = "Geometry" in user_attr
    if has_geometry == False:
        return fig
                      Severity: Minor
                      Found in Optuna/Visualization/Python/plot_pareto_front.py - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                      fig.update_layout(
    plot_bgcolor="white",
    xaxis=dict(
        title="x+y",
        showline=True,
                      Severity: Major
                      Found in Examples/Python/plot_with_coloring_of_results.py and 1 other location - About 1 hr to fix
                      Examples/Python/plot_with_coloring_of_results.py on lines 55..79

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 39.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Method TTDesignExplorerToolStripMenuItem_Click has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              private void TTDesignExplorerToolStripMenuItem_Click(object sender, EventArgs e)
        {
            TLog.MethodStart();
            string settingsPath = TEnvVariables.OptimizeSettingsPath;
            string storagePath = string.Empty;
                      Severity: Minor
                      Found in Tunny/UI/LoadingInstruction.cs - About 1 hr to fix

                        Method InstallPackages has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                private static void InstallPackages(BackgroundWorker worker, string[] packageList)
        {
            TLog.MethodStart();
            int num = packageList.Length;
            for (int i = 0; i < num; i++)
                        Severity: Minor
                        Found in Tunny.Core/Handler/PythonInstaller.cs - About 1 hr to fix
                          Severity
                          Category
                          Status
                          Source
                          Language