Sign upLogin

jaroslavtyc/drd-plus-codes

View on GitHub
Star

Showing 591 of 591 total issues

The method I_can_easily_find_out_if_weapon_is_unarmed_in_fact is not named in camelCase.
Open

    public function I_can_easily_find_out_if_weapon_is_unarmed_in_fact()
    {
        self::assertTrue(ShieldCode::getIt(ShieldCode::WITHOUT_SHIELD)->isUnarmed());
        self::assertFalse(ShieldCode::getIt(ShieldCode::HEAVY_SHIELD)->isUnarmed());
    }
Severity: Minor
Found in tests/Codes/Armaments/ShieldCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_if_is_weapon is not named in camelCase.
Open

    public function I_can_easily_find_out_if_is_weapon()
    {
        /** @var WeaponCode $sut */
        $sut = $this->getSut();
        self::assertTrue($sut->isWeapon());
Severity: Minor
Found in tests/Codes/Armaments/WeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_if_is_melee is not named in camelCase.
Open

    abstract public function I_can_easily_find_out_if_is_melee();
Severity: Minor
Found in tests/Codes/Armaments/WeaponlikeCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method It_is_both_for_melee_and_ranged is not named in camelCase.
Open

    public function It_is_both_for_melee_and_ranged()
    {
        self::assertTrue(CombatActionCode::getIt(CombatActionCode::BLINDFOLD_FIGHT)->isForMelee());
        self::assertTrue(CombatActionCode::getIt(CombatActionCode::CONCENTRATION_ON_DEFENSE)->isForRanged());
    }
Severity: Minor
Found in tests/Codes/CombatActions/CombatActionCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_extended_it_by_same_code_but_different_category is not named in camelCase.
Open

    public function I_can_not_extended_it_by_same_code_but_different_category()
    {
        $this->expectException(\DrdPlus\Codes\Armaments\Exceptions\RangedWeaponIsAlreadyInDifferentWeaponCategory::class);
        $reflectionClass = new \ReflectionClass(RangedWeaponCode::class);
        $translations = $reflectionClass->getProperty('translations');
Severity: Minor
Found in tests/Codes/Armaments/RangedWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_if_is_melee is not named in camelCase.
Open

    public function I_can_easily_find_out_if_is_melee()
    {
        $reflection = new \ReflectionClass(self::getSutClass());
        /** @var ShieldCode $sut */
        $sut = $reflection->newInstanceWithoutConstructor();
Severity: Minor
Found in tests/Codes/Armaments/ShieldCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_melee_weapon_category_codes_at_once is not named in camelCase.
Open

    public function I_can_get_melee_weapon_category_codes_at_once()
    {
        self::assertSame(
            $codes = [
                'axes',
Severity: Minor
Found in tests/Codes/Armaments/WeaponCategoryCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_extended_it_by_custom_translatable_code is not named in camelCase.
Open

    public function I_can_extended_it_by_custom_translatable_code()
    {
        /** @var WeaponCode $sutClass */
        $sutClass = self::getSutClass();
        $reflectionClass = new \ReflectionClass($sutClass);
Severity: Minor
Found in tests/Codes/Armaments/WeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it()
    {
        $ordinaryWoundOrigin = OrdinaryWoundOriginCode::getIt();
        $sameOrdinaryWoundOrigin = OrdinaryWoundOriginCode::getIt(OrdinaryWoundOriginCode::ORDINARY);
        self::assertSame($ordinaryWoundOrigin, $sameOrdinaryWoundOrigin);
Severity: Minor
Found in tests/Codes/Body/OrdinaryWoundOriginCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_if_is_weapon is not named in camelCase.
Open

    public function I_can_easily_find_out_if_is_weapon()
    {
        $reflection = new \ReflectionClass(self::getSutClass());
        /** @var ShieldCode $sut */
        $sut = $reflection->newInstanceWithoutConstructor();
Severity: Minor
Found in tests/Codes/Armaments/ShieldCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_convert_it_to_range_weapon_code is not named in camelCase.
Open

    public function I_can_not_convert_it_to_range_weapon_code()
    {
        $this->expectException(\DrdPlus\Codes\Armaments\Exceptions\CanNotBeConvertedToRangeWeaponCode::class);
        ShieldCode::getIt(ShieldCode::BUCKLER)->convertToRangedWeaponCodeEquivalent();
    }
Severity: Minor
Found in tests/Codes/Armaments/ShieldCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_use_empty_string_for_translation_of_custom_code is not named in camelCase.
Open

    public function I_can_not_use_empty_string_for_translation_of_custom_code()
    {
        $this->expectException(\DrdPlus\Codes\Partials\Exceptions\InvalidTranslationFormat::class);
        $this->expectExceptionMessageMatches("~''~");
        /** like @see \DrdPlus\Codes\Armaments\MeleeWeaponCode::addNewMeleeWeaponCode */
Severity: Minor
Found in tests/Codes/Armaments/WeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_if_is_shield is not named in camelCase.
Open

    abstract public function I_can_easily_find_out_if_is_shield();
Severity: Minor
Found in tests/Codes/Armaments/WeaponlikeCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_convert_anything_to_melee_weapon_code is not named in camelCase.
Open

    public function I_can_not_convert_anything_to_melee_weapon_code()
    {
        $this->expectException(\DrdPlus\Codes\Armaments\Exceptions\CanNotBeConvertedToMeleeWeaponCode::class);
        $this->expectExceptionMessageMatches('~minicrossbow~');
        $rangeWeapon = RangedWeaponCode::getIt(RangedWeaponCode::MINICROSSBOW);
Severity: Minor
Found in tests/Codes/Armaments/RangedWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_it_with_default_value is not named in camelCase.
Open

    public function I_can_get_it_with_default_value()
    {
        $sut = $this->findSut();
        self::assertSame(RangedWeaponCode::SAND, $sut->getValue(), 'Expected sand as a harmless default value');
    }
Severity: Minor
Found in tests/Codes/Armaments/RangedWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_will_get_conditions_from_best_to_worst is not named in camelCase.
Open

    public function I_will_get_conditions_from_best_to_worst()
    {
        self::assertSame(
            [
                ConditionsAffectingHealingCode::GOOD_CONDITIONS,
Severity: Minor
Found in tests/Codes/Body/ConditionsAffectingHealingCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_create_custom_ordinary_origin is not named in camelCase.
Open

    public function I_can_not_create_custom_ordinary_origin()
    {
        $this->expectException(\DrdPlus\Codes\Partials\Exceptions\UnknownValueForCode::class);
        $this->expectExceptionMessageMatches('~Kitchen accident~');
        OrdinaryWoundOriginCode::getEnum('Kitchen accident');
Severity: Minor
Found in tests/Codes/Body/OrdinaryWoundOriginCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_if_weapon_is_unarmed_in_fact is not named in camelCase.
Open

    public function I_can_easily_find_out_if_weapon_is_unarmed_in_fact()
    {
        self::assertFalse(RangedWeaponCode::getIt(RangedWeaponCode::LONG_COMPOSITE_BOW)->isUnarmed());
    }
Severity: Minor
Found in tests/Codes/Armaments/RangedWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_it_with_default_value is not named in camelCase.
Open

    public function I_can_get_it_with_default_value()
    {
        $sut = $this->findSut();
        self::assertSame(ShieldCode::WITHOUT_SHIELD, $sut->getValue(), 'Expected without shield as a default value');
    }
Severity: Minor
Found in tests/Codes/Armaments/ShieldCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_it_is_not_projectile is not named in camelCase.
Open

    abstract public function I_can_easily_find_out_it_is_not_projectile();
Severity: Minor
Found in tests/Codes/Armaments/WeaponlikeCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language