Sign upLogin

jaroslavtyc/drd-plus-codes

View on GitHub
Star

Showing 591 of 591 total issues

The method I_can_easily_find_out_if_is_weapon is not named in camelCase.
Open

    abstract public function I_can_easily_find_out_if_is_weapon();
Severity: Minor
Found in tests/Codes/Armaments/WeaponlikeCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_create_custom_origin is not named in camelCase.
Open

    public function I_can_not_create_custom_origin()
    {
        $this->expectException(\DrdPlus\Codes\Partials\Exceptions\UnknownValueForCode::class);
        $this->expectExceptionMessageMatches('~Bathroom slipping~');
        SeriousWoundOriginCode::getEnum('Bathroom slipping');
Severity: Minor
Found in tests/Codes/Body/SeriousWoundOriginCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_ranged_only_codes is not named in camelCase.
Open

    public function I_can_get_ranged_only_codes()
    {
        $expectedMeleeOnly = array_diff(
            array_values((new \ReflectionClass(RangedCombatActionCode::class))->getConstants()),
            CombatActionCode::getPossibleValues()
Severity: Minor
Found in tests/Codes/CombatActions/RangedCombatActionCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method Ranged_only_codes_are_marked_so is not named in camelCase.
Open

    public function Ranged_only_codes_are_marked_so()
    {
        $reflection = new \ReflectionClass(RangedCombatActionCode::class);
        foreach ($reflection->getConstants() as $name => $value) {
            $rangedCombatActionCode = RangedCombatActionCode::getIt($value);
Severity: Minor
Found in tests/Codes/CombatActions/RangedCombatActionCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_ask_it_if_is_male_or_female is not named in camelCase.
Open

    public function I_can_ask_it_if_is_male_or_female()
    {
        $female = GenderCode::getIt(GenderCode::FEMALE);
        self::assertTrue($female->isFemale());
        self::assertFalse($female->isMale());
Severity: Minor
Found in tests/Codes/GenderCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_all_codes_at_once_or_by_same_named_constant is not named in camelCase.
Open

    public function I_can_get_all_codes_at_once_or_by_same_named_constant()
    {
        self::assertSame(
            [
                'mechanical_stab',
Severity: Minor
Found in tests/Codes/Body/SeriousWoundOriginCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_distinguish_throwing_and_shooting_weapon is not named in camelCase.
Open

    public function I_can_distinguish_throwing_and_shooting_weapon(
        $rangeWeaponCodeValue,
        $isThrowing,
        $isShooting
    )
Severity: Minor
Found in tests/Codes/Armaments/RangedWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_if_is_shield is not named in camelCase.
Open

    public function I_can_easily_find_out_if_is_shield()
    {
        self::assertTrue(ShieldCode::getIt(ShieldCode::BUCKLER)->isShield());
        self::assertFalse(ShieldCode::getIt(ShieldCode::BUCKLER)->isArmor());
    }
Severity: Minor
Found in tests/Codes/Armaments/ShieldCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_it_is_not_projectile is not named in camelCase.
Open

    public function I_can_easily_find_out_it_is_not_projectile()
    {
        self::assertFalse(ShieldCode::getIt(ShieldCode::BUCKLER)->isProjectile());
    }
Severity: Minor
Found in tests/Codes/Armaments/ShieldCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_ranged_weapon_category_codes is not named in camelCase.
Open

    public function I_can_get_ranged_weapon_category_codes()
    {
        self::assertSame(
            $codes = ['bows', 'crossbows', 'throwing_weapons'],
            WeaponCategoryCode::getRangedWeaponCategoryValues()
Severity: Minor
Found in tests/Codes/Armaments/WeaponCategoryCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_use_invalid_language_code_format_for_custom_code is not named in camelCase.
Open

    public function I_can_not_use_invalid_language_code_format_for_custom_code()
    {
        $this->expectException(\DrdPlus\Codes\Partials\Exceptions\InvalidLanguageCode::class);
        $this->expectExceptionMessageMatches('~a1~');
        /** @var WeaponCode $sutClass */
Severity: Minor
Found in tests/Codes/Armaments/WeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_if_is_ranged is not named in camelCase.
Open

    abstract public function I_can_easily_find_out_if_is_ranged();
Severity: Minor
Found in tests/Codes/Armaments/WeaponlikeCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_if_is_ranged is not named in camelCase.
Open

    public function I_can_easily_find_out_if_is_ranged()
    {
        self::assertTrue(RangedWeaponCode::getIt(RangedWeaponCode::MILITARY_CROSSBOW)->isRanged());
    }
Severity: Minor
Found in tests/Codes/Armaments/RangedWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_add_new_ranged_weapon_code_with_not_melee_category is not named in camelCase.
Open

    public function I_can_not_add_new_ranged_weapon_code_with_not_melee_category()
    {
        $this->expectException(\DrdPlus\Codes\Armaments\Exceptions\InvalidWeaponCategoryForNewRangedWeaponCode::class);
        $this->expectExceptionMessageMatches('~voulge~');
        $meleeCategory = WeaponCategoryCode::getIt(WeaponCategoryCode::VOULGES_AND_TRIDENTS);
Severity: Minor
Found in tests/Codes/Armaments/RangedWeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_it_is_not_projectile is not named in camelCase.
Open

    public function I_can_easily_find_out_it_is_not_projectile()
    {
        /** @var WeaponCode $sut */
        $sut = $this->getSut();
        self::assertFalse($sut->isProjectile());
Severity: Minor
Found in tests/Codes/Armaments/WeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_use_invalid_plural_for_translation_of_custom_code is not named in camelCase.
Open

    public function I_can_not_use_invalid_plural_for_translation_of_custom_code()
    {
        $this->expectException(\DrdPlus\Codes\Partials\Exceptions\UnknownTranslationPlural::class);
        $this->expectExceptionMessageMatches('~all~');
        /** like @see \DrdPlus\Codes\Armaments\MeleeWeaponCode::addNewMeleeWeaponCode */
Severity: Minor
Found in tests/Codes/Armaments/WeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_extended_it_by_same_code_but_different_category is not named in camelCase.
Open

    abstract public function I_can_not_extended_it_by_same_code_but_different_category();
Severity: Minor
Found in tests/Codes/Armaments/WeaponCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_find_out_if_is_sling_stone is not named in camelCase.
Open

    public function I_can_find_out_if_is_sling_stone()
    {
        self::assertTrue(SlingStoneCode::getIt(SlingStoneCode::SLING_STONE_HEAVIER)->isSlingStone());
    }
Severity: Minor
Found in tests/Codes/Armaments/SlingStoneCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method Melee_only_codes_are_marked is not named in camelCase.
Open

    public function Melee_only_codes_are_marked()
    {
        $reflection = new \ReflectionClass(MeleeCombatActionCode::class);
        foreach ($reflection->getConstants() as $name => $value) {
            $meleeCombatActionCode = MeleeCombatActionCode::getIt($value);
Severity: Minor
Found in tests/Codes/CombatActions/MeleeCombatActionCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_convert_it_to_melee_weapon_code is not named in camelCase.
Open

    public function I_can_not_convert_it_to_melee_weapon_code()
    {
        $this->expectException(\DrdPlus\Codes\Armaments\Exceptions\CanNotBeConvertedToMeleeWeaponCode::class);
        ShieldCode::getIt(ShieldCode::BUCKLER)->convertToMeleeWeaponCodeEquivalent();
    }
Severity: Minor
Found in tests/Codes/Armaments/ShieldCodeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language