Sign upLogin

jaroslavtyc/drd-plus-health

View on GitHub
Star

Showing 669 of 669 total issues

The method I_can_get_charisma_malus is not named in camelCase.
Open

    public function I_can_get_charisma_malus()
    {
        $hunger = Hunger::createIt(new Health(), $this->createAfflictionSize(782));
        self::assertSame(0, $hunger->getKnackMalus());
    }
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/HungerTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it()
    {
        $seriousWound = $this->createWound();
        $someTerriblePain = Pain::createIt(
            $seriousWound,
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/PainTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_create_more_than_completely_severed_arm is not named in camelCase.
Open

    public function I_can_not_create_more_than_completely_severed_arm()
    {
        $this->expectException(\DrdPlus\Health\Afflictions\SpecificAfflictions\Exceptions\SeveredArmAfflictionSizeExceeded::class);
        SeveredArm::createIt($this->createWound(), 7);
    }
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/SeveredArmTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_heal_malus is not named in camelCase.
Open

    public function I_can_get_heal_malus()
    {
        $thirst = Thirst::createIt(new Health(), AfflictionSize::getIt(567));
        self::assertSame(0, $thirst->getHealMalus());
    }
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/ThirstTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it($propertyCode)
    {
        $afflictionProperty = AfflictionProperty::getIt($propertyCode);
        self::assertInstanceOf(AfflictionProperty::class, $afflictionProperty);
        self::assertSame($propertyCode, $afflictionProperty->getValue());
Severity: Minor
Found in tests/Health/Afflictions/AfflictionPropertyTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_use_negative_value is not named in camelCase.
Open

    public function I_can_not_use_negative_value()
    {
        $this->expectException(\DrdPlus\Health\Afflictions\Exceptions\AfflictionSizeCanNotBeNegative::class);
        $this->expectExceptionMessageMatches('~-1~');
        AfflictionSize::getEnum(-1);
Severity: Minor
Found in tests/Health/Afflictions/AfflictionSizeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it is not named in camelCase.
Open

    abstract public function I_can_use_it();
Severity: Minor
Found in tests/Health/Afflictions/AfflictionTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_strength_malus is not named in camelCase.
Open

    abstract public function I_can_get_strength_malus();
Severity: Minor
Found in tests/Health/Afflictions/AfflictionTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_create_custom_virulence is not named in camelCase.
Open

    public function I_can_not_create_custom_virulence()
    {
        $this->expectException(\DrdPlus\Health\Afflictions\Exceptions\UnknownVirulencePeriod::class);
        $this->expectExceptionMessageMatches('~life~');
        AfflictionVirulence::getEnum('life');
Severity: Minor
Found in tests/Health/Afflictions/AfflictionVirulenceTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_heal_malus is not named in camelCase.
Open

    public function I_can_get_heal_malus()
    {
        $wound = $this->createWound();
        $woundBoundary = $this->createWoundBoundary(20);
        $this->addSizeCalculation($wound, $woundBoundary, $filledHalfOfRows = 123);
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/BleedingTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_strength_malus is not named in camelCase.
Open

    public function I_can_get_strength_malus()
    {
        $wound = $this->createWound();
        $woundBoundary = $this->createWoundBoundary(20);
        $this->addSizeCalculation($wound, $woundBoundary, $filledHalfOfRows = 123);
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/CrackedBonesTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_create_any_name is not named in camelCase.
Open

    public function I_can_create_any_name()
    {
        $afflictionName = AfflictionName::getIt('foo');
        self::assertInstanceOf(AfflictionName::class, $afflictionName);
        self::assertSame('foo', $afflictionName->getValue());
Severity: Minor
Found in tests/Health/Afflictions/AfflictionNameTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_malus_to_activities is not named in camelCase.
Open

    abstract public function I_can_get_malus_to_activities();
Severity: Minor
Found in tests/Health/Afflictions/AfflictionTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_every_virulence is not named in camelCase.
Open

    public function I_can_get_every_virulence()
    {
        $roundVirulence = AfflictionVirulence::getRoundVirulence();
        self::assertInstanceOf(AfflictionVirulence::class, $roundVirulence);
        self::assertSame('round', $roundVirulence->getValue());
Severity: Minor
Found in tests/Health/Afflictions/AfflictionVirulenceTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_find_out_if_apply_even_on_success_against_trap is not named in camelCase.
Open

    public function I_can_find_out_if_apply_even_on_success_against_trap()
    {
        $coldEffect = ColdEffect::getIt();

        self::assertFalse($coldEffect->isEffectiveEvenOnSuccessAgainstTrap());
Severity: Minor
Found in tests/Health/Afflictions/Effects/ColdEffectTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_agility_malus is not named in camelCase.
Open

    public function I_can_get_agility_malus()
    {
        $wound = $this->createWound();
        $woundBoundary = $this->createWoundBoundary(20);
        $this->addSizeCalculation($wound, $woundBoundary, $filledHalfOfRows = 123);
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/CrackedBonesTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_heal_malus is not named in camelCase.
Open

    public function I_can_get_heal_malus()
    {
        $seriousWound = $this->createWound();
        $someTerriblePain = Pain::createIt(
            $seriousWound,
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/PainTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_calculated_filled_half_rows_for_given_wound_value is not named in camelCase.
Open

    public function I_can_get_calculated_filled_half_rows_for_given_wound_value(): void
    {
        // limit of wounds divisible by two (odd)
        $gridOfWounds = new GridOfWounds($this->createHealth([] /* no wounds*/));
        self::assertSame(
Severity: Minor
Found in tests/Health/GridOfWoundsTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method It_is_linked_with_health_immediately is not named in camelCase.
Open

    public function It_is_linked_with_health_immediately()
    {
        $woundBoundary = $this->mockery(WoundBoundary::class);
        $woundBoundary->shouldReceive('getValue')
            ->andReturn(5);
Severity: Minor
Found in tests/Health/Afflictions/AfflictionByWoundTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_malus_from_pain is not named in camelCase.
Open

    public function I_can_get_malus_from_pain()
    {
        $painEffect = PainEffect::getIt();
        $pain = $this->mockery(Pain::class);
        $pain->shouldReceive('getAfflictionSize')
Severity: Minor
Found in tests/Health/Afflictions/Effects/PainEffectTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language