Sign upLogin

jaroslavtyc/drd-plus-health

View on GitHub
Star

Showing 669 of 669 total issues

The method I_can_get_agility_malus is not named in camelCase.
Open

    public function I_can_get_agility_malus()
    {
        $health = new Health();
        $hunger = Hunger::createIt($health, $this->createAfflictionSize(6));
        self::assertSame(-3, $hunger->getAgilityMalus());
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/HungerTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_will_malus is not named in camelCase.
Open

    public function I_can_get_will_malus()
    {
        $hunger = Hunger::createIt(new Health(), $this->createAfflictionSize(123541));
        self::assertSame(0, $hunger->getKnackMalus());
    }
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/HungerTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_strength_malus is not named in camelCase.
Open

    public function I_can_get_strength_malus()
    {
        $wound = $this->createWound();
        $woundBoundary = $this->createWoundBoundary(20);
        $this->addSizeCalculation($wound, $woundBoundary, 123);
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/SeveredArmTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_agility_malus is not named in camelCase.
Open

    public function I_can_get_agility_malus()
    {
        $thirst = Thirst::createIt(new Health(), AfflictionSize::getIt(567));
        self::assertSame(-567, $thirst->getStrengthMalus());
    }
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/ThirstTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it($domainCode)
    {
        $afflictionDomain = AfflictionDomain::getIt($domainCode);
        self::assertInstanceOf(AfflictionDomain::class, $afflictionDomain);
        $getAfflictionDomain = StringTools::assembleGetterForName($domainCode) . 'Domain';
Severity: Minor
Found in tests/Health/Afflictions/AfflictionDomainTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_agility_malus is not named in camelCase.
Open

    public function I_can_get_agility_malus()
    {
        $wound = $this->createWound();
        $woundBoundary = $this->createWoundBoundary(20);
        $this->addSizeCalculation($wound, $woundBoundary, 123);
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/SeveredArmTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_knack_malus is not named in camelCase.
Open

    public function I_can_get_knack_malus()
    {
        $wound = $this->createWound();
        $woundBoundary = $this->createWoundBoundary(20);
        $this->addSizeCalculation($wound, $woundBoundary, 123);
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/SeveredArmTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_charisma_malus is not named in camelCase.
Open

    public function I_can_get_charisma_malus()
    {
        $thirst = Thirst::createIt(new Health(), AfflictionSize::getIt(567));
        self::assertSame(-567, $thirst->getStrengthMalus());
    }
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/ThirstTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_charisma_malus is not named in camelCase.
Open

    abstract public function I_can_get_charisma_malus();
Severity: Minor
Found in tests/Health/Afflictions/AfflictionTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_both_minus_and_plus_pertinence is not named in camelCase.
Open

    public function I_can_get_both_minus_and_plus_pertinence()
    {
        $pertinenceClass = $this->getPertinenceClass();
        $classConstantName = "{$pertinenceClass}::" . strtoupper($pertinenceClass::getPertinenceCode());
        self::assertTrue(defined($classConstantName), "Expected constant {$classConstantName}");
Severity: Minor
Found in tests/Health/Afflictions/ElementalPertinence/ElementalPertinenceTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_knack_malus is not named in camelCase.
Open

    public function I_can_get_knack_malus()
    {
        $wound = $this->createWound();
        $woundBoundary = $this->createWoundBoundary(20);
        $this->addSizeCalculation($wound, $woundBoundary, $filledHalfOfRows = 123);
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/BleedingTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_heal_malus is not named in camelCase.
Open

    public function I_can_get_heal_malus()
    {
        $wound = $this->createWound();
        $woundBoundary = $this->createWoundBoundary(20);
        $this->addSizeCalculation($wound, $woundBoundary, 123);
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/ColdTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_knack_malus is not named in camelCase.
Open

    public function I_can_get_knack_malus()
    {
        $hunger = Hunger::createIt(new Health(), $this->createAfflictionSize(21));
        self::assertSame(-11, $hunger->getKnackMalus());
    }
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/HungerTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_find_out_if_apply_even_on_success_against_trap is not named in camelCase.
Open

    public function I_can_find_out_if_apply_even_on_success_against_trap()
    {
        $hungerEffect = HungerEffect::getIt();
        self::assertTrue($hungerEffect->isEffectiveEvenOnSuccessAgainstTrap());
    }
Severity: Minor
Found in tests/Health/Afflictions/Effects/HungerEffectTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_strength_and_knack_malus is not named in camelCase.
Open

    public function I_can_get_strength_and_knack_malus()
    {
        $severedArmEffect = SeveredArmEffect::getIt();
        self::assertSame(-123, $severedArmEffect->getStrengthMalus($this->createSeveredArm(123)));
        self::assertSame(-246, $severedArmEffect->getKnackMalus($this->createSeveredArm(123)));
Severity: Minor
Found in tests/Health/Afflictions/Effects/SeveredArmEffectTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_charisma_malus is not named in camelCase.
Open

    public function I_can_get_charisma_malus()
    {
        $afflictionReflection = new \ReflectionClass(self::getSutClass());
        $afflictionConstructor = $afflictionReflection->getConstructor();
        $afflictionConstructor->setAccessible(true);
Severity: Minor
Found in tests/Health/Afflictions/AfflictionByWoundTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_knack_malus is not named in camelCase.
Open

    abstract public function I_can_get_knack_malus();
Severity: Minor
Found in tests/Health/Afflictions/AfflictionTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_create_severed_arm_with_negative_value is not named in camelCase.
Open

    public function I_can_not_create_severed_arm_with_negative_value()
    {
        $this->expectException(\DrdPlus\Health\Afflictions\Exceptions\AfflictionSizeCanNotBeNegative::class);
        try {
            SeveredArm::createIt($this->createWound(), 0);
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/SeveredArmTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_malus_to_activities is not named in camelCase.
Open

    public function I_can_get_malus_to_activities()
    {
        $seriousWound = $this->createWound();
        $someTerriblePain = Pain::createIt(
            $seriousWound,
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/PainTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_heal_malus is not named in camelCase.
Open

    public function I_can_get_heal_malus()
    {
        $wound = $this->createWound();
        $woundBoundary = $this->createWoundBoundary(20);
        $this->addSizeCalculation($wound, $woundBoundary, 123);
Severity: Minor
Found in tests/Health/Afflictions/SpecificAfflictions/SeveredArmTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language