jaroslavtyc/drd-plus-health

View on GitHub

Showing 669 of 669 total issues

The method I_can_ask_it_if_may_suffer_from_wounds is not named in camelCase.
Open

    public function I_can_ask_it_if_may_suffer_from_wounds(): void
    {
        $woundBoundary = $this->createWoundBoundary(5);
        $health = $this->createHealthToTest($woundBoundary);
        self::assertFalse($health->maySufferFromWounds($woundBoundary));
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_add_affliction_of_unknown_wound is not named in camelCase.
Open

    public function I_can_not_add_affliction_of_unknown_wound(): void
    {
        $this->expectException(\DrdPlus\Health\Exceptions\UnknownAfflictionOriginatingWound::class);
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(5));
        $affliction = $this->createAffliction($this->createSeriousWound());
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_add_affliction_with_to_health_unknown_wound is not named in camelCase.
Open

    public function I_can_not_add_affliction_with_to_health_unknown_wound(): void
    {
        $this->expectException(\DrdPlus\Health\Exceptions\UnknownAfflictionOriginatingWound::class);
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(5));
        $seriousWound = $health->addWound(
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it_for_treatment is not named in camelCase.
Open

    public function I_can_use_it_for_treatment(): void
    {
        $healingPower = HealingPower::createForTreatment(
            123,
            $this->createToughness(3),
Severity: Minor
Found in tests/Health/HealingPowerTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_should_roll_against_malus_from_wounds_because_of_heal_of_serious_wound is not named in camelCase.
Open

    public function I_should_roll_against_malus_from_wounds_because_of_heal_of_serious_wound($willValue, $rollValue, $expectedMalus): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(10));
        $seriousWound = $health->addWound($this->createWoundSize(15),
            SeriousWoundOriginCode::getElementalWoundOrigin(),
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method Malus_can_not_decrease_on_fresh_wound is not named in camelCase.
Open

    public function Malus_can_not_decrease_on_fresh_wound(int $willValue, int $rollValue, int $expectedMalus): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(5));

        $health->addWound($this->createWoundSize(5),
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_get_highest_malus_from_wound_and_pains is not named in camelCase.
Open

    public function I_get_highest_malus_from_wound_and_pains(): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(12));
        $damnSeriousWound = $health->addWound($this->createWoundSize(15),
            SeriousWoundOriginCode::getPsychicalWoundOrigin(),
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_knack_malus_from_afflictions is not named in camelCase.
Open

    public function I_can_get_knack_malus_from_afflictions(): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(123));
        $seriousWound = $health->addWound($this->createWoundSize(70),
            SeriousWoundOriginCode::getPsychicalWoundOrigin(),
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it(): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(123));
        self::assertSame(369, $health->getRemainingHealthAmount($woundBoundary));
        self::assertSame(369, $health->getHealthMaximum($woundBoundary));
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_should_roll_against_malus_from_wounds_because_of_regeneration is not named in camelCase.
Open

    public function I_should_roll_against_malus_from_wounds_because_of_regeneration($willValue, $rollValue, $expectedMalus): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(10));
        $health->addWound($this->createWoundSize(15),
            SeriousWoundOriginCode::getElementalWoundOrigin(),
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_regenerate_if_roll_on_malus_expected is not named in camelCase.
Open

    public function I_can_not_regenerate_if_roll_on_malus_expected(): void
    {
        $this->expectException(\DrdPlus\Health\Exceptions\NeedsToRollAgainstMalusFromWoundsFirst::class);
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(10));
        try {
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_intelligence_malus_from_afflictions is not named in camelCase.
Open

    public function I_can_get_intelligence_malus_from_afflictions(): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(123));
        $seriousWound = $health->addWound($this->createWoundSize(70),
            SeriousWoundOriginCode::getPsychicalWoundOrigin(),
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_easily_find_out_if_creature_is_conscious_and_alive is not named in camelCase.
Open

    public function I_can_easily_find_out_if_creature_is_conscious_and_alive(
        int $woundBoundaryValue,
        int $wound,
        bool $isConscious,
        bool $isAlive
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_should_roll_against_malus_from_wounds_because_of_new_wound is not named in camelCase.
Open

    public function I_should_roll_against_malus_from_wounds_because_of_new_wound($willValue, $rollValue, $expectedMalus): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(10));
        $health->addWound($this->createWoundSize(10), SeriousWoundOriginCode::getElementalWoundOrigin(), $woundBoundary);
        self::assertTrue($health->needsToRollAgainstMalusFromWounds());
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_add_same_affliction_twice is not named in camelCase.
Open

    public function I_can_not_add_same_affliction_twice(): void
    {
        $this->expectException(\DrdPlus\Health\Exceptions\AfflictionIsAlreadyRegistered::class);
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(5));
        $wound = $health->addWound(
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_strength_malus_from_afflictions is not named in camelCase.
Open

    public function I_can_get_strength_malus_from_afflictions(): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(123));
        $seriousWound = $health->addWound($this->createWoundSize(70),
            SeriousWoundOriginCode::getPsychicalWoundOrigin(),
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_agility_malus_from_afflictions is not named in camelCase.
Open

    public function I_can_get_agility_malus_from_afflictions(): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(123));
        $seriousWound = $health->addWound($this->createWoundSize(70),
            SeriousWoundOriginCode::getPsychicalWoundOrigin(),
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_create_it_from_glare is not named in camelCase.
Open

    public function I_can_create_it_from_glare(int $malus, bool $isShined): void
    {
        $glared = Glared::createFromGlare($this->createGlare($malus, $isShined), $health = new Health());
        self::assertSame($malus, $glared->getCurrentMalus());
        self::assertSame($isShined, $glared->isShined());

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_lower_malus_by_getting_used_to_darkness is not named in camelCase.
Open

    public function I_can_lower_malus_by_getting_used_to_darkness(): void
    {
        $glared = Glared::createFromGlare($this->createGlare(-36, false), new Health());

        self::assertSame(-36, $glared->getCurrentMalus());

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it_for_regeneration is not named in camelCase.
Open

    public function I_can_use_it_for_regeneration(): void
    {
        foreach ([true, false] as $hasNativeRegeneration) {
            $tables = $this->createTablesWithWoundsTable($expectedValue = -7 + 123 + 456 + 789 + ($hasNativeRegeneration ? +4 : 0) - 5 /* toughness */, 112233);
            $tables->shouldReceive('getHealingByActivityTable')
Severity: Minor
Found in tests/Health/HealingPowerTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language