Sign upLogin

jaroslavtyc/drd-plus-health

View on GitHub
Star

Showing 669 of 669 total issues

The method Malus_can_increase_on_fresh_wound is not named in camelCase.
Open

    public function Malus_can_increase_on_fresh_wound(int $willValue, int $rollValue, int $expectedMalus): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(5));

        $health->addWound(
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_heal_it_both_partially_and_fully is not named in camelCase.
Open

    public function I_can_heal_it_both_partially_and_fully(): void
    {
        $wound = $this->createWound(
            $health = $this->createHealth(),
            new WoundSize($woundSizeValue = 3),
Severity: Minor
Found in tests/Health/WoundTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_heal_serious_wound_from_different_health is not named in camelCase.
Open

    public function I_can_not_heal_serious_wound_from_different_health(): void
    {
        $this->expectException(\DrdPlus\Health\Exceptions\UnknownSeriousWoundToHeal::class);
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(5));
        $seriousWound = $health->addWound($this->createWoundSize(5),
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_use_negative_value is not named in camelCase.
Open

    public function I_can_not_use_negative_value(): void
    {
        $this->expectException(\DrdPlus\Health\Exceptions\TreatmentBoundaryCanNotBeNegative::class);
        $this->expectExceptionMessageMatches('~-1~');
        TreatmentBoundary::getIt(-1);
Severity: Minor
Found in tests/Health/TreatmentBoundaryTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it_as_an_integer is not named in camelCase.
Open

    public function I_can_use_it_as_an_integer(): void
    {
        $woundSize = new WoundSize(123);
        self::assertInstanceOf(IntegerInterface::class, $woundSize);
        self::assertSame(123, $woundSize->getValue());
Severity: Minor
Found in tests/Health/WoundSizeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_used_to_darkness_by_long_waiting is not named in camelCase.
Open

    public function I_can_get_used_to_darkness_by_long_waiting(): void
    {
        $glared = Glared::createFromGlare($this->createGlare(-21 /* malus */, false), new Health());

        self::assertSame(-21, $glared->getCurrentMalus());
Severity: Minor
Found in tests/Health/Inflictions/GlaredTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it(): Wound
    {
        $wound = $this->createWound(
            $health = $this->createHealth(),
            new WoundSize($woundSizeValue = 3),
Severity: Minor
Found in tests/Health/WoundTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_be_seriously_wounded is not named in camelCase.
Open

    public function I_can_be_seriously_wounded(): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(6));

        $seriousWoundByStab = $health->addWound(
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_healed_serious_wounds is not named in camelCase.
Open

    public function I_can_get_healed_serious_wounds(): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(6));

        $seriousWoundByStab = $health->addWound(
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_heal_serious_wound_not_created_by_current_health is not named in camelCase.
Open

    public function I_can_not_heal_serious_wound_not_created_by_current_health(): void
    {
        $this->expectException(\DrdPlus\Health\Exceptions\UnknownSeriousWoundToHeal::class);
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(5));
        $healthReflection = new \ReflectionClass($health);
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_heal_reason is not named in camelCase.
Open

    public function I_can_use_heal_reason(): void
    {
        $healReason = ReasonToRollAgainstMalusFromWounds::getHealReason();
        self::assertTrue($healReason->becauseOfHeal());
        self::assertFalse($healReason->becauseOfWound());
Severity: Minor
Found in tests/Health/ReasonToRollAgainstMalusTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_create_positive_malus is not named in camelCase.
Open

    public function I_can_not_create_positive_malus()
    {
        $this->expectException(\DrdPlus\Health\Exceptions\UnexpectedMalusValue::class);
        $this->expectExceptionMessageMatches('~1~');
        MalusFromWounds::getIt(1);
Severity: Minor
Found in tests/Health/MalusFromWoundsTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_use_negative_value is not named in camelCase.
Open

    public function I_can_not_use_negative_value(): void
    {
        $this->expectException(\DrdPlus\Health\Exceptions\WoundSizeCanNotBeNegative::class);
        $this->expectExceptionMessageMatches('~-1~');
        new WoundSize(-1);
Severity: Minor
Found in tests/Health/WoundSizeTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_ask_it_if_I_am_suffering_from_wounds is not named in camelCase.
Open

    public function I_can_ask_it_if_I_am_suffering_from_wounds(): void
    {
        $woundBoundary = $this->createWoundBoundary(5);
        $health = $this->createHealthToTest($woundBoundary);
        self::assertFalse($health->mayHaveMalusFromWounds($woundBoundary));
Severity: Minor
Found in tests/Health/HealthTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_lower_malus_by_getting_used_to_shine is not named in camelCase.
Open

    public function I_can_lower_malus_by_getting_used_to_shine(): void
    {
        $glared = Glared::createFromGlare($this->createGlare(-15, true), new Health());

        self::assertSame(-15, $glared->getCurrentMalus());
Severity: Minor
Found in tests/Health/Inflictions/GlaredTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_get_used_to_darkness_by_very_long_waiting_when_blinded is not named in camelCase.
Open

    public function I_can_get_used_to_darkness_by_very_long_waiting_when_blinded(): void
    {
        $blinded = Glared::createFromGlare($this->createGlare($malus = -21, false /* not shined = blinded */), new Health());

        self::assertSame($malus, $blinded->getCurrentMalus());
Severity: Minor
Found in tests/Health/Inflictions/GlaredTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_use_it is not named in camelCase.
Open

    public function I_can_use_it()
    {
        $malusFromWounds = MalusFromWounds::getIt(-2);
        self::assertInstanceOf(MalusFromWounds::class, $malusFromWounds);
        self::assertSame(-2, $malusFromWounds->getValue());
Severity: Minor
Found in tests/Health/MalusFromWoundsTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_am_stopped_by_specific_exception_on_invalid_value is not named in camelCase.
Open

    public function I_am_stopped_by_specific_exception_on_invalid_value(): void
    {
        $this->expectException(\DrdPlus\Health\Exceptions\TreatmentBoundaryCanNotBeNegative::class);
        $this->expectExceptionMessageMatches('~Why you ask me?~');
        TreatmentBoundary::getIt('Why you ask me?');
Severity: Minor
Found in tests/Health/TreatmentBoundaryTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_create_wound_directly is not named in camelCase.
Open

    public function I_can_not_create_wound_directly(): void
    {
        $this->expectException(\DrdPlus\Health\Exceptions\WoundHasToBeCreatedByHealthItself::class);
        $this->createWound(
            $this->createHealth(false /* not open for new wounds */),
Severity: Minor
Found in tests/Health/WoundTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method I_can_not_create_unknown_reason is not named in camelCase.
Open

    public function I_can_not_create_unknown_reason(): void
    {
        $this->expectException(\DrdPlus\Health\Exceptions\UnknownReasonToRollAgainstMalus::class);
        $this->expectExceptionMessageMatches('~hypochondriac~');
        ReasonToRollAgainstMalusFromWounds::getEnum('hypochondriac');
Severity: Minor
Found in tests/Health/ReasonToRollAgainstMalusTest.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language