jaroslavtyc/drd-plus-health

Method __construct has 11 arguments (exceeds 4 allowed). Consider refactoring.

Open

        SeriousWound $seriousWound, // wound can be healed, but never disappears - just stays healed
        AfflictionProperty $property,
        AfflictionDangerousness $dangerousness,
        AfflictionDomain $domain,
        AfflictionVirulence $virulence,

Method __construct has 11 arguments (exceeds 4 allowed). Consider refactoring.

Open

        Health $health,
        AfflictionProperty $property,
        AfflictionDangerousness $dangerousness,
        AfflictionDomain $domain,
        AfflictionVirulence $virulence,

Method It_is_linked_with_health_immediately has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function It_is_linked_with_health_immediately()
    {
        $woundBoundary = $this->mockery(WoundBoundary::class);
        $woundBoundary->shouldReceive('getValue')
            ->andReturn(5);

Method I_should_roll_against_malus_from_wounds_because_of_heal_of_ordinary_wound has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function I_should_roll_against_malus_from_wounds_because_of_heal_of_ordinary_wound($willValue, $rollValue, $expectedMalus): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(10));
        $health->addWound($this->createWoundSize(4),
            SeriousWoundOriginCode::getElementalWoundOrigin(),

The class HealthTest has 50 public methods and attributes. Consider reducing the number of public items to less than 45.

Open

class HealthTest extends TestWithMockery
{
    /**
     * @test
     */

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

public class Foo {
    public $value;
    public $something;
    public $var;
    // [... more more public attributes ...]

    public function doWork() {}
    public function doMoreWork() {}
    public function doWorkAgain() {}
    // [... more more public methods ...]
}

Method I_can_not_heal_already_treated_serious_wound has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function I_can_not_heal_already_treated_serious_wound(): void
    {
        $this->expectException(\DrdPlus\Health\Exceptions\ExpectedFreshWoundToHeal::class);
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(5));
        $seriousWound = $health->addWound(

Method Malus_is_not_increased_on_new_heal_by_worse_roll has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function Malus_is_not_increased_on_new_heal_by_worse_roll(): void
    {
        $health = $this->createHealthToTest($woundBoundary = $this->createWoundBoundary(5));
        self::assertSame(0, $health->getSignificantMalusFromPains($woundBoundary));

Method I_can_use_it has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function I_can_use_it(): Wound
    {
        $wound = $this->createWound(
            $health = $this->createHealth(),
            new WoundSize($woundSizeValue = 3),

Method createForRegeneration has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

        RaceCode $raceCode,
        SubRaceCode $subRaceCode,
        Toughness $toughness,
        ActivityAffectingHealingCode $activityAffectingHealingCode,
        ConditionsAffectingHealingCode $conditionsAffectingHealingCode,

The class Hunger has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13.

Open

class Hunger extends Affliction
{

    /**
     * @param Health $health

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

The class Bleeding has a coupling between objects value of 18. Consider to reduce the number of dependencies under 13.

Open

class Bleeding extends AfflictionByWound
{
    public const BLEEDING = 'bleeding';

    /**

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

The class Pain has a coupling between objects value of 15. Consider to reduce the number of dependencies under 13.

Open

class Pain extends AfflictionByWound
{
    public const PAIN = 'pain';

    /**

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

The class Health has a coupling between objects value of 33. Consider to reduce the number of dependencies under 13.

Open

class Health extends StrictObject
{
    /**
     * @var array|Wound[]
     */

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

The class SeveredArm has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13.

Open

class SeveredArm extends AfflictionByWound
{
    public const SEVERED_ARM = 'severed_arm';
    public const COMPLETELY_SEVERED_ARM = 'completely_severed_arm';
    public const COMPLETELY_SEVERED_ARM_SIZE = 6;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

The class Cold has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.

Open

class Cold extends AfflictionByWound
{
    public const COLD = 'cold';

    /**

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

The class CrackedBones has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13.

Open

class CrackedBones extends AfflictionByWound
{
    public const CRACKED_BONES = 'cracked_bones';

    /**

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

The class AfflictionByWoundTest has a coupling between objects value of 23. Consider to reduce the number of dependencies under 13.

Open

abstract class AfflictionByWoundTest extends AfflictionTest
{

    /**
     * @test

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

The class BleedingTest has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.

Open

class BleedingTest extends AfflictionByWoundTest
{
    /**
     * @return Bleeding
     */

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

The class Thirst has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.

Open

class Thirst extends Affliction
{

    /**
     * @param Health $health

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

The class SeveredArmTest has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13.

Open

class SeveredArmTest extends AfflictionByWoundTest
{
    /**
     * @return SeveredArm
     */

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}