jaroslavtyc/drd-plus-therugist-spells

View on GitHub

Showing 142 of 142 total issues

Avoid excessively long variable names like $baseNumberOfSituations. Keep variable name length under 20.
Open

$baseNumberOfSituations = $this->getBaseNumberOfSituations();
Severity: Minor
Found in DrdPlus/Theurgist/Spells/Modifier.php by phpmd

Avoid excessively long variable names like $additionByDifficultyNotation. Keep variable name length under 20.
Open

public function __construct($additionByDifficultyNotation, int $currentAddition = null)

Avoid excessively long variable names like $numberOfWaypointsValues. Keep variable name length under 20.
Open

$numberOfWaypointsValues = $this->getValue($modifierCode, self::NUMBER_OF_WAYPOINTS);

Avoid excessively long variable names like $radiusModifiersChange. Keep variable name length under 20.
Open

$radiusModifiersChange = $this->getParameterBonusFromModifiers(ModifierMutableSpellParameterCode::RADIUS);
Severity: Minor
Found in DrdPlus/Theurgist/Spells/Formula.php by phpmd

Avoid excessively long variable names like $spellSpeedWithAddition. Keep variable name length under 20.
Open

$spellSpeedWithAddition = $this->getSpellSpeedWithAddition();
Severity: Minor
Found in DrdPlus/Theurgist/Spells/Formula.php by phpmd

Avoid excessively long variable names like $modifierSpellParameterChanges. Keep variable name length under 20.
Open

private $modifierSpellParameterChanges;
Severity: Minor
Found in DrdPlus/Theurgist/Spells/Modifier.php by phpmd

Avoid excessively long variable names like $modifierSpellParameterValues. Keep variable name length under 20.
Open

array $modifierSpellParameterValues,
Severity: Minor
Found in DrdPlus/Theurgist/Spells/Modifier.php by phpmd

Avoid excessively long variable names like $formulaSpellParameterValues. Keep variable name length under 20.
Open

array $formulaSpellParameterValues = [],
Severity: Minor
Found in DrdPlus/Theurgist/Spells/Formula.php by phpmd

Avoid excessively long variable names like $sumOfDifficultyChange. Keep variable name length under 20.
Open

$sumOfDifficultyChange = 0;

Avoid excessively long variable names like $mutableSpellParameter. Keep variable name length under 20.
Open

foreach (FormulaMutableSpellParameterCode::getPossibleValues() as $mutableSpellParameter) {
Severity: Minor
Found in DrdPlus/Theurgist/Spells/Formula.php by phpmd

Avoid excessively long variable names like $modifierRealmsAffectionPeriod. Keep variable name length under 20.
Open

$modifierRealmsAffectionPeriod = $modifierRealmsAffection->getAffectionPeriod()->getValue();
Severity: Minor
Found in DrdPlus/Theurgist/Spells/Formula.php by phpmd

Avoid excessively long variable names like $difficultyAdditionPerStep. Keep variable name length under 20.
Open

private $difficultyAdditionPerStep;

Avoid excessively long variable names like $spellTraitTrapPropertyValue. Keep variable name length under 20.
Open

private function sanitizeSpellTraitTrapPropertyChange(int $spellTraitTrapPropertyValue = null): int

Avoid excessively long variable names like $difficultyPerAdditionStep. Keep variable name length under 20.
Open

private $difficultyPerAdditionStep;

Avoid excessively long variable names like $parametersDifficultyChangeSum. Keep variable name length under 20.
Open

$parametersDifficultyChangeSum = 0;
Severity: Minor
Found in DrdPlus/Theurgist/Spells/Modifier.php by phpmd

Avoid excessively long class names like InvalidValueForSpellTraitDifficultyChange. Keep class name length under 40.
Open

class InvalidValueForSpellTraitDifficultyChange extends \InvalidArgumentException implements Logic
{
 
}

Avoid excessively long class names like AdditionByDifficultyWithoutStepsCanNotBeChanged. Keep class name length under 40.
Open

class AdditionByDifficultyWithoutStepsCanNotBeChanged extends \LogicException implements Logic
{
 
}

Avoid excessively long class names like InvalidFormatOfAdditionByDifficultyNotation. Keep class name length under 40.
Open

class InvalidFormatOfAdditionByDifficultyNotation extends \InvalidArgumentException implements Logic
{
 
}

Avoid excessively long variable names like $epicenterShiftWithAddition. Keep variable name length under 20.
Open

$epicenterShiftWithAddition = $this->getEpicenterShiftWithAddition();
Severity: Minor
Found in DrdPlus/Theurgist/Spells/Formula.php by phpmd

Avoid excessively long variable names like $numberOfSituationsValue. Keep variable name length under 20.
Open

$numberOfSituationsValue = $this->getValue($modifierCode, self::NUMBER_OF_SITUATIONS);
Severity
Category
Status
Source
Language