Sign upLogin

jdel/gosspks

View on GitHub
Star
cfg/cfg.go

Summary

Maintainability
A
2 hrs
Test Coverage

Function InitConfig has 63 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func InitConfig(cfgFile string, homeDir string) {
    // Instantiate goSSPKSHome ASAP
    goSSPKSHome = getOrCreateHome(homeDir)

    if cfgFile != "" {
Severity: Minor
Found in cfg/cfg.go - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func GetPackagesCacheDuration() time.Duration {
    var err error
    packagesDuration := viper.GetString("gosspks.cache.packages.duration")
    cacheDuration := cache.DefaultCacheDuration
    if cacheDuration, err = time.ParseDuration(packagesDuration); err != nil {
    Severity: Minor
    Found in cfg/cfg.go and 1 other location - About 35 mins to fix
    cfg/cfg.go on lines 231..240

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 104.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func GetModelsCacheDuration() time.Duration {
    var err error
    modelsDuration := viper.GetString("gosspks.cache.models.duration")
    cacheDuration := cache.DefaultCacheDuration
    if cacheDuration, err = time.ParseDuration(modelsDuration); err != nil {
    Severity: Minor
    Found in cfg/cfg.go and 1 other location - About 35 mins to fix
    cfg/cfg.go on lines 206..215

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 104.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Your code does not pass gofmt in 1 place. Go fmt your code!
    Open

    package cfg // import jdel.org/gosspks/cfg
    Severity: Minor
    Found in cfg/cfg.go by gofmt

    There are no issues that match your filters.

    Category
    Status