Showing 247 of 247 total issues

File RestoUtil.php has 269 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*
 * Copyright 2018 Jérôme Gasperi
 *
 * Licensed under the Apache License, version 2.0 (the "License");
Severity: Minor
Found in app/resto/core/utils/RestoUtil.php - About 2 hrs to fix

    File ATOMFeed.php has 269 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /*
     * Copyright 2018 Jérôme Gasperi
     *
     * Licensed under the Apache License, version 2.0 (the "License");
    Severity: Minor
    Found in app/resto/core/xml/ATOMFeed.php - About 2 hrs to fix

      Method featureArrayToKeysValues has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function featureArrayToKeysValues($collection, $featureArray, $protected, $updatabled)
          {
              // Initialize
              $keysAndValues = array(
                  'links' => isset($featureArray['links']) ? json_encode($featureArray['links'], JSON_UNESCAPED_SLASHES) : null,
      Severity: Major
      Found in app/resto/core/dbfunctions/FeaturesFunctions.php - About 2 hrs to fix

        File RestoCollection.php has 266 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
        /*
         * Copyright 2018 Jérôme Gasperi
         *
         * Licensed under the Apache License, version 2.0 (the "License");
        Severity: Minor
        Found in app/resto/core/RestoCollection.php - About 2 hrs to fix

          File Tag.php has 264 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          /*
           * Copyright 2018 Jérôme Gasperi
           *
           * Licensed under the Apache License, version 2.0 (the "License");
          Severity: Minor
          Found in app/resto/core/addons/Tag.php - About 2 hrs to fix

            Method analyze has 57 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function analyze($params, $model)
                {
                    /*
                     * Store original params
                     */
            Severity: Major
            Found in app/resto/core/RestoQueryAnalyzer.php - About 2 hrs to fix

              Method storeCollectionDescription has 55 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function storeCollectionDescription($collection)
                  {
                      /*
                       * First generate a right keywords array
                       */
              Severity: Major
              Found in app/resto/core/dbfunctions/CollectionsFunctions.php - About 2 hrs to fix

                FiltersFunctions has 21 functions (exceeds 20 allowed). Consider refactoring.
                Open

                class FiltersFunctions
                {
                    /*
                     * Non search filters are excluded from search
                     */
                Severity: Minor
                Found in app/resto/core/dbfunctions/FiltersFunctions.php - About 2 hrs to fix

                  Method toArray has 54 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function toArray()
                      {
                          $collections = array(
                              'stac_version' => STAC::STAC_VERSION,
                              'id' => $this->context->osDescription['ShortName'],
                  Severity: Major
                  Found in app/resto/core/RestoCollections.php - About 2 hrs to fix

                    Method formatUserProfile has 54 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public static function formatUserProfile($rawProfile)
                        {
                            // Empty profile
                            $profile = array();
                    
                    
                    Severity: Major
                    Found in app/resto/core/dbfunctions/UsersFunctions.php - About 2 hrs to fix

                      Function storeFeatures has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function storeFeatures($collection, $body, $params)
                          {
                              // Convert input to resto model
                              $data = $this->inputToResto($body, $collection, $params);
                      
                      
                      Severity: Minor
                      Found in app/resto/core/RestoModel.php - About 2 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function sendMail has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function sendMail($params, $smtp = array())
                          {
                              if (! isset($params) || ! is_array($params)) {
                                  return false;
                              }
                      Severity: Minor
                      Found in app/resto/core/RestoNotifier.php - About 2 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function updateUserProfile has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function updateUserProfile($profile, $storageInfo)
                          {
                              if (!is_array($profile) || !isset($profile['email'])) {
                                  RestoLogUtil::httpError(400);
                              }
                      Severity: Minor
                      Found in app/resto/core/dbfunctions/UsersFunctions.php - About 2 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method storeFeatures has 52 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function storeFeatures($collection, $body, $params)
                          {
                              // Convert input to resto model
                              $data = $this->inputToResto($body, $collection, $params);
                      
                      
                      Severity: Major
                      Found in app/resto/core/RestoModel.php - About 2 hrs to fix

                        Method updateFeature has 52 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function updateFeature($feature, $collection, $newFeatureArray)
                            {
                                if (!isset($feature)) {
                                    RestoLogUtil::httpError(404);
                                }
                        Severity: Major
                        Found in app/resto/core/dbfunctions/FeaturesFunctions.php - About 2 hrs to fix

                          Method prepareFilters has 51 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function prepareFilters($paramsWithOperation, $sortKey)
                              {
                                  $filters = array();
                                  $sortFilters = array();
                          
                          
                          Severity: Major
                          Found in app/resto/core/dbfunctions/FiltersFunctions.php - About 2 hrs to fix

                            Method storeFeature has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function storeFeature($id, $collection, $featureArray)
                                {
                                    $keysValues = $this->featureArrayToKeysValues(
                                        $collection,
                                        $featureArray,
                            Severity: Minor
                            Found in app/resto/core/dbfunctions/FeaturesFunctions.php - About 2 hrs to fix

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                          $filter = $start . pg_escape_string($this->context->dbDriver->getConnection(), 'POLYGON((' . $coords[0] . ' ' . $coords[1] . ',' . $coords[0] . ' ' . $coords[3] . ',' . $coords[2] . ' ' . $coords[3] . ',' . $coords[2] . ' ' . $coords[1] . ',' . $coords[0] . ' ' . $coords[1] . '))') . $end;
                              Severity: Major
                              Found in app/resto/core/dbfunctions/FiltersFunctions.php and 1 other location - About 2 hrs to fix
                              app/resto/core/dbfunctions/FiltersFunctions.php on lines 403..403

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 121.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                          'wkt' => isset($coords) ? 'POLYGON((' . $coords[0] . ' ' . $coords[1] . ',' . $coords[0] . ' ' . $coords[3] . ',' . $coords[2] . ' ' . $coords[3] . ',' . $coords[2] . ' ' . $coords[1] . ',' . $coords[0] . ' ' . $coords[1] . '))' : $filterValue['value'],
                              Severity: Major
                              Found in app/resto/core/dbfunctions/FiltersFunctions.php and 1 other location - About 2 hrs to fix
                              app/resto/core/dbfunctions/FiltersFunctions.php on lines 481..481

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 121.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Method setParameters has 49 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  private function setParameters($format)
                                  {
                                      foreach ($this->model->searchFilters as $filterName => $filter) {
                                          if (isset($filter) && $filterName != 'searchTerms' && !isset($filter['hidden'])) {
                                              $this->startElement('parameters:Parameter');
                              Severity: Minor
                              Found in app/resto/core/xml/OSDD.php - About 1 hr to fix
                                Severity
                                Category
                                Status
                                Source
                                Language