Sign upLogin

jumaallan/AndelaCryptoApp

View on GitHub
Star

Showing 56 of 56 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public static int getDarkerColor(@ColorInt int color, float darkerAmount) {
        float[] hsv = new float[3];
        Color.colorToHSV(color, hsv);
        hsv[2] *= darkerAmount;
        return Color.HSVToColor(hsv);
Severity: Minor
Found in app/src/main/java/com/androidstudy/andelatrackchallenge/utils/Easel.java and 1 other location - About 35 mins to fix
app/src/main/java/com/androidstudy/andelatrackchallenge/utils/ThemeUtils.java on lines 26..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method draw has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public void draw(@NonNull Canvas canvas) {
        super.draw(canvas);

        int width = getWidth();
Severity: Minor
Found in app/src/main/java/com/androidstudy/andelatrackchallenge/view/ScrimInsetsFrameLayout.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            itemView.setOnClickListener(view -> {
                if (onItemClickListener != null) {
                    int position = getAdapterPosition();
                    onItemClickListener.onItemClick(countries.get(position), position);
                }
Severity: Minor
Found in app/src/main/java/com/androidstudy/andelatrackchallenge/picker/currency/CurrencyAdapter.java and 1 other location - About 30 mins to fix
app/src/main/java/com/androidstudy/andelatrackchallenge/adapter/CardsAdapter.java on lines 255..260

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            itemView.setOnClickListener(v -> {
                if (onItemClickListener != null) {
                    int position = getAdapterPosition();
                    onItemClickListener.onItemClick(countries.get(position), position);
                }
Severity: Minor
Found in app/src/main/java/com/androidstudy/andelatrackchallenge/adapter/CardsAdapter.java and 1 other location - About 30 mins to fix
app/src/main/java/com/androidstudy/andelatrackchallenge/picker/currency/CurrencyAdapter.java on lines 69..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this method.
Open

        if (country.ethStatus != ethStatus) return false;
Severity: Major
Found in app/src/main/java/com/androidstudy/andelatrackchallenge/models/Country.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return code.equals(country.code);
    Severity: Major
    Found in app/src/main/java/com/androidstudy/andelatrackchallenge/models/Country.java - About 30 mins to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  ethTextView.setText(country.eth > 0
                    ? String.format(Locale.getDefault(), currencyFormat, country.code, CurrencyUtils.format.format(ethCountry))
                    : "...");
      Severity: Minor
      Found in app/src/main/java/com/androidstudy/andelatrackchallenge/adapter/CardsAdapter.java and 1 other location - About 30 mins to fix
      app/src/main/java/com/androidstudy/andelatrackchallenge/adapter/CardsAdapter.java on lines 296..298

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid too many return statements within this method.
      Open

              if (country.btcStatus != btcStatus) return false;
      Severity: Major
      Found in app/src/main/java/com/androidstudy/andelatrackchallenge/models/Country.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                if (refreshedAt != country.refreshedAt) return false;
        Severity: Major
        Found in app/src/main/java/com/androidstudy/andelatrackchallenge/models/Country.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  if (Float.compare(country.eth, eth) != 0) return false;
          Severity: Major
          Found in app/src/main/java/com/androidstudy/andelatrackchallenge/models/Country.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    if (!name.equals(country.name)) return false;
            Severity: Major
            Found in app/src/main/java/com/androidstudy/andelatrackchallenge/models/Country.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      if (!country.isFavorite == isFavorite) return false;
              Severity: Major
              Found in app/src/main/java/com/androidstudy/andelatrackchallenge/models/Country.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        if (!currency.equals(country.currency)) return false;
                Severity: Major
                Found in app/src/main/java/com/androidstudy/andelatrackchallenge/models/Country.java - About 30 mins to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                              btcTextView.setText(country.btc > 0
                    ? String.format(Locale.getDefault(), currencyFormat, country.code, CurrencyUtils.format.format(btcCountry))
                    : "...");
                  Severity: Minor
                  Found in app/src/main/java/com/androidstudy/andelatrackchallenge/adapter/CardsAdapter.java and 1 other location - About 30 mins to fix
                  app/src/main/java/com/androidstudy/andelatrackchallenge/adapter/CardsAdapter.java on lines 300..302

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 40.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method updateTaskDescription has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private void updateTaskDescription(int position) {
        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
            String title = getTitle().toString();
            Drawable iconDrawable = getApplicationInfo().loadIcon(getPackageManager());
            Bitmap icon = iconDrawable instanceof BitmapDrawable
                  Severity: Minor
                  Found in app/src/main/java/com/androidstudy/andelatrackchallenge/WelcomeActivity.java - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method tintEdgeEffect has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      @TargetApi(21)
    public static boolean tintEdgeEffect(@NonNull View scrollableView, @ColorInt int color) {
        //http://stackoverflow.com/questions/27104521/android-lollipop-scrollview-edge-effect-color
        boolean outcome = false;
        final String[] edgeGlows = {"mEdgeGlowTop", "mEdgeGlowBottom", "mEdgeGlowLeft", "mEdgeGlowRight"};
                  Severity: Minor
                  Found in app/src/main/java/com/androidstudy/andelatrackchallenge/utils/Easel.java - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language