Sign upLogin

kanadeko/Kuro

View on GitHub
Star

Showing 36 of 36 total issues

Function migrate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

exports.migrate = function() {
    console.log('Starting migration')
    _msg.edit('*Starting migration to kuro v4.1.0, this might take a while depending how many stickers you have. Check the console.*')

    try {
Severity: Minor
Found in commands/s.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    kuro.db.schema.createTableIfNotExists(_table, (table) => {
        table.increments()
        table.string('game')
    }).then(() => {
        kuro.db.table(_table).then((row) => {
Severity: Minor
Found in commands/playing.js and 1 other location - About 45 mins to fix
commands/status.js on lines 8..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    kuro.db.schema.createTableIfNotExists(_table, (table) => {
        table.increments()
        table.string('status')
    }).then(() => {
        kuro.db.table(_table).then((row) => {
Severity: Minor
Found in commands/status.js and 1 other location - About 45 mins to fix
commands/playing.js on lines 8..25

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            kuro.db.table(_table).insert({ status: 'online' }).then(function() {}) // eslint-disable-line
Severity: Minor
Found in commands/status.js and 1 other location - About 35 mins to fix
commands/playing.js on lines 21..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            kuro.db.table(_table)
                .insert({ game: '' })
                .then(function() {}) // eslint-disable-line
Severity: Minor
Found in commands/playing.js and 1 other location - About 35 mins to fix
commands/status.js on lines 21..21

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

    return this.list()
Severity: Major
Found in commands/tag.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        if (_stickers.hasOwnProperty(args[0])) return this.sendSticker(args[0])
    Severity: Major
    Found in commands/s.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return msg.delete()
      Severity: Major
      Found in kuro.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            if (_tags.hasOwnProperty(args[0])) return _msg.edit(_tags[args[0]])
        Severity: Major
        Found in commands/tag.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              if (args[0] === 'migrate') return this.migrate()
          Severity: Major
          Found in commands/s.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return kuro.modules[config.commandError.module][config.commandError.function](msg, cmd)
            Severity: Major
            Found in kuro.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  if (args[0] === 'list') return this.list()
              Severity: Major
              Found in commands/s.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    if (args[0] === 'ren') return this.ren(newargs)
                Severity: Major
                Found in commands/s.js - About 30 mins to fix

                  Function run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  exports.run = function(msg) {
    if (!radioInfo) return msg.edit('No data available');

    const artist = `${radioInfo.artist_name}` ? `${radioInfo.artist_name} - ` : '';
    const nowplaying = `${artist}${radioInfo.song_name}`;
                  Severity: Minor
                  Found in commands/np.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  exports.run = function(msg) {
    msg.edit('*Loading...*')
    require('request').get('http://smugs.safe.moe/api/v1/i/r', (error, response, body) => {
        if (!error && response.statusCode === 200) {
            try {
                  Severity: Minor
                  Found in commands/smug.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  exports.run = function(msg, args) {
    _msg = msg

    let newargs = []
    for (let i = 1; i < args.length; i++) {
                  Severity: Minor
                  Found in commands/tag.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language