Sign upLogin

kubenetworks/kubevpn

View on GitHub
Star

Showing 526 of 526 total issues

Similar blocks of code found in 12 locations. Consider refactoring.
Open

func _Daemon_Status_Handler(srv interface{}, ctx context.Context, dec func(interface{}) error, interceptor grpc.UnaryServerInterceptor) (interface{}, error) {
    in := new(StatusRequest)
    if err := dec(in); err != nil {
        return nil, err
    }
Severity: Major
Found in pkg/daemon/rpc/daemon_grpc.pb.go and 11 other locations - About 2 hrs to fix
pkg/daemon/rpc/daemon_grpc.pb.go on lines 776..792
pkg/daemon/rpc/daemon_grpc.pb.go on lines 794..810
pkg/daemon/rpc/daemon_grpc.pb.go on lines 812..828
pkg/daemon/rpc/daemon_grpc.pb.go on lines 830..846
pkg/daemon/rpc/daemon_grpc.pb.go on lines 895..911
pkg/daemon/rpc/daemon_grpc.pb.go on lines 913..929
pkg/daemon/rpc/daemon_grpc.pb.go on lines 931..947
pkg/daemon/rpc/daemon_grpc.pb.go on lines 967..983
pkg/daemon/rpc/daemon_grpc.pb.go on lines 1027..1043
pkg/dhcp/rpc/dhcpserver_grpc.pb.go on lines 92..108
pkg/dhcp/rpc/dhcpserver_grpc.pb.go on lines 110..126

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 221.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function SshJump has 28 return statements (exceeds 4 allowed).
Open

func SshJump(ctx context.Context, conf *SshConfig, flags *pflag.FlagSet, print bool) (path string, err error) {
    if conf.Addr == "" && conf.ConfigAlias == "" {
        if flags != nil {
            lookup := flags.Lookup("kubeconfig")
            if lookup != nil {
Severity: Major
Found in pkg/ssh/ssh.go - About 2 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    func DownloadFileWithName(uri, name string) (string, error) {
    resp, err := getWithRetry(uri)
    if err != nil {
        return "", err
    }
    Severity: Major
    Found in pkg/util/krew/sha256.go and 1 other location - About 2 hrs to fix
    pkg/util/file.go on lines 16..46

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 220.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    func DownloadFileWithName(uri, name string) (string, error) {
    resp, err := getWithRetry(uri)
    if err != nil {
        return "", err
    }
    Severity: Major
    Found in pkg/util/file.go and 1 other location - About 2 hrs to fix
    pkg/util/krew/sha256.go on lines 19..49

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 220.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method Options.Connect has 87 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (option *Options) Connect(ctx context.Context, sshConfig *pkgssh.SshConfig, transferImage bool, portBindings nat.PortMap) error {
    switch option.ConnectMode {
    case ConnectModeHost:
        daemonCli := daemon.GetClient(false)
        if daemonCli == nil {
    Severity: Major
    Found in pkg/dev/options.go - About 2 hrs to fix

      Function CmdClone has a Cognitive Complexity of 33 (exceeds 20 allowed). Consider refactoring.
      Open

      func CmdClone(f cmdutil.Factory) *cobra.Command {
    var options = handler.CloneOptions{}
    var sshConf = &pkgssh.SshConfig{}
    var extraRoute = &handler.ExtraRouteInfo{}
    var transferImage bool
      Severity: Minor
      Found in cmd/kubevpn/cmds/clone.go - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      UnimplementedDaemonServer has 22 methods (exceeds 20 allowed). Consider refactoring.
      Open

      type UnimplementedDaemonServer struct {
}
      Severity: Minor
      Found in pkg/daemon/rpc/daemon_grpc.pb.go - About 2 hrs to fix

        Method Server.redirectToSudoDaemon has 83 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (svr *Server) redirectToSudoDaemon(req *rpc.ConnectRequest, resp rpc.Daemon_ConnectServer) (e error) {
    cli := svr.GetClient(true)
    if cli == nil {
        return fmt.Errorf("sudo daemon not start")
    }
        Severity: Major
        Found in pkg/daemon/action/connect.go - About 2 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  RunE: func(cmd *cobra.Command, args []string) error {
            leave, err := daemon.GetClient(false).Leave(cmd.Context(), &rpc.LeaveRequest{
                Workloads: args,
            })
            if err != nil {
          Severity: Major
          Found in cmd/kubevpn/cmds/leave.go and 1 other location - About 2 hrs to fix
          cmd/kubevpn/cmds/remove.go on lines 37..55

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 209.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  RunE: func(cmd *cobra.Command, args []string) error {
            leave, err := daemon.GetClient(false).Remove(cmd.Context(), &rpc.RemoveRequest{
                Workloads: args,
            })
            if err != nil {
          Severity: Major
          Found in cmd/kubevpn/cmds/remove.go and 1 other location - About 2 hrs to fix
          cmd/kubevpn/cmds/leave.go on lines 39..57

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 209.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function CmdSSH has 82 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func CmdSSH(_ cmdutil.Factory) *cobra.Command {
    var sshConf = &pkgssh.SshConfig{}
    var ExtraCIDR []string
    cmd := &cobra.Command{
        Use:   "ssh",
          Severity: Major
          Found in cmd/kubevpn/cmds/ssh.go - About 2 hrs to fix

            Function CmdGet has 82 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func CmdGet(f cmdutil.Factory) *cobra.Command {
    var printFlags = cmdget.NewGetPrintFlags()
    cmd := &cobra.Command{
        Use:    "get",
        Hidden: true,
            Severity: Major
            Found in cmd/kubevpn/cmds/get.go - About 2 hrs to fix

              Function legacyWaitExitOrRemoved has a Cognitive Complexity of 32 (exceeds 20 allowed). Consider refactoring.
              Open

              func legacyWaitExitOrRemoved(ctx context.Context, apiClient client.APIClient, containerID string, waitRemove bool) <-chan int {
    var removeErr error
    statusChan := make(chan int)
    exitCode := 125
              Severity: Minor
              Found in pkg/dev/docker_utils.go - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method Server.redirectConnectForkToSudoDaemon has 81 lines of code (exceeds 50 allowed). Consider refactoring.
              Open

              func (svr *Server) redirectConnectForkToSudoDaemon(req *rpc.ConnectRequest, resp rpc.Daemon_ConnectServer) (err error) {
    cli := svr.GetClient(true)
    if cli == nil {
        return fmt.Errorf("sudo daemon not start")
    }
              Severity: Major
              Found in pkg/daemon/action/connect-fork.go - About 2 hrs to fix

                Method admissionReviewHandler.handleCreate has 80 lines of code (exceeds 50 allowed). Consider refactoring.
                Open

                func (h *admissionReviewHandler) handleCreate(ar v1.AdmissionReview) *v1.AdmissionResponse {
    raw := ar.Request.Object.Raw
    pod := corev1.Pod{}
    deserializer := codecs.UniversalDeserializer()
    if _, _, err := deserializer.Decode(raw, nil, &pod); err != nil {
                Severity: Major
                Found in pkg/webhook/pods.go - About 2 hrs to fix

                  File gssapi_ccache.go has 508 lines of code (exceeds 500 allowed). Consider refactoring.
                  Open

                  package ssh

import (
    "bytes"
    "encoding/binary"
                  Severity: Minor
                  Found in pkg/ssh/gssapi_ccache.go - About 2 hrs to fix

                    Method CCache.writeCredential has 24 return statements (exceeds 4 allowed).
                    Open

                    func (c *CCache) writeCredential(cred *Credential, endian *binary.ByteOrder) ([]byte, error) {
    var byteString bytes.Buffer
    var err error

    b := &byteString
                    Severity: Major
                    Found in pkg/ssh/gssapi_ccache.go - About 2 hrs to fix

                      daemonClient has 21 methods (exceeds 20 allowed). Consider refactoring.
                      Open

                      type daemonClient struct {
    cc grpc.ClientConnInterface
}
                      Severity: Minor
                      Found in pkg/daemon/rpc/daemon_grpc.pb.go - About 2 hrs to fix

                        Function runContainer has 79 lines of code (exceeds 50 allowed). Consider refactoring.
                        Open

                        func runContainer(ctx context.Context, dockerCli command.Cli, runConfig *RunConfig) error {
    config := runConfig.config
    stdout, stderr := dockerCli.Out(), dockerCli.Err()
    apiClient := dockerCli.Client()
                        Severity: Major
                        Found in pkg/dev/docker_utils.go - About 2 hrs to fix

                          Method Server.ConnectFork has 79 lines of code (exceeds 50 allowed). Consider refactoring.
                          Open

                          func (svr *Server) ConnectFork(req *rpc.ConnectRequest, resp rpc.Daemon_ConnectForkServer) (err error) {
    defer func() {
        util.InitLoggerForServer(true)
        log.SetOutput(svr.LogFile)
        config.Debug = false
                          Severity: Major
                          Found in pkg/daemon/action/connect-fork.go - About 2 hrs to fix
                            Severity
                            Category
                            Status
                            Source
                            Language