kubenetworks/kubevpn

View on GitHub

Showing 526 of 526 total issues

Function main has 70 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func main() {
    // git describe --tags `git rev-list --tags --max-count=1`
    commitId, err2 := exec.Command("git", "rev-list", "--tags", "--max-count=1").Output()
    if err2 != nil {
        panic(err2)
Severity: Minor
Found in pkg/util/krew/main.go - About 1 hr to fix

    Function ConvertK8sApiServerToDomain has 69 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func ConvertK8sApiServerToDomain(kubeConfigPath string) (newPath string, err error) {
        var kubeConfigBytes []byte
        kubeConfigBytes, err = os.ReadFile(kubeConfigPath)
        if err != nil {
            return
    Severity: Minor
    Found in pkg/util/kube.go - About 1 hr to fix

      Function init has 69 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func init() {
          http.Handle("/ws", websocket.Handler(func(conn *websocket.Conn) {
              var sshConfig pkgssh.SshConfig
              b := conn.Request().Header.Get("ssh")
              if err := json.Unmarshal([]byte(b), &sshConfig); err != nil {
      Severity: Minor
      Found in pkg/daemon/handler/ssh.go - About 1 hr to fix

        Method CloneOptions.SyncDir has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
        Open

        func (d *CloneOptions) SyncDir(ctx context.Context, labels string) error {
            list, err := util.GetRunningPodList(ctx, d.targetClientset, d.TargetNamespace, labels)
            if err != nil {
                return err
            }
        Severity: Minor
        Found in pkg/handler/clone.go - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method Manager.RentIP has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
        Open

        func (m *Manager) RentIP(ctx context.Context) (*net.IPNet, *net.IPNet, error) {
            addrs, _ := net.InterfaceAddrs()
            var isAlreadyExistedFunc = func(ip net.IP) bool {
                for _, addr := range addrs {
                    if addr == nil {
        Severity: Minor
        Found in pkg/dhcp/dhcp.go - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function CmdDisconnect has 68 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func CmdDisconnect(f cmdutil.Factory) *cobra.Command {
            var all = false
            var clusterIDs []string
            cmd := &cobra.Command{
                Use:   "disconnect",
        Severity: Minor
        Found in cmd/kubevpn/cmds/disconnect.go - About 1 hr to fix

          Function InjectVPNSidecar has 68 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func InjectVPNSidecar(ctx1 context.Context, factory util.Factory, namespace, workload string, c util2.PodRouteConfig) error {
              object, err := util2.GetUnstructuredObject(factory, namespace, workload)
              if err != nil {
                  return err
              }
          Severity: Minor
          Found in pkg/inject/proxy.go - About 1 hr to fix

            Method Server.Get has 68 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func (svr *Server) Get(ctx context.Context, req *rpc.GetRequest) (*rpc.GetResponse, error) {
                if svr.connect == nil || svr.connect.Context() == nil {
                    return nil, errors.New("not connected")
                }
                if svr.resourceLists == nil {
            Severity: Minor
            Found in pkg/daemon/action/get.go - About 1 hr to fix

              Function NewStack has 68 lines of code (exceeds 50 allowed). Consider refactoring.
              Open

              func NewStack(ctx context.Context, tun stack.LinkEndpoint) *stack.Stack {
                  s := stack.New(stack.Options{
                      NetworkProtocols: []stack.NetworkProtocolFactory{
                          ipv4.NewProtocol,
                          ipv6.NewProtocol,
              Severity: Minor
              Found in pkg/core/gvisorstack.go - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                func (c *fakeUDPTunnelConnector) ConnectContext(ctx context.Context, conn net.Conn) (net.Conn, error) {
                    //defer conn.SetDeadline(time.Time{})
                    switch con := conn.(type) {
                    case *net.TCPConn:
                        err := con.SetNoDelay(true)
                Severity: Major
                Found in pkg/core/tcphandler.go and 1 other location - About 1 hr to fix
                pkg/core/gvisorudphandler.go on lines 25..42

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 171.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                func (c *gvisorUDPOverTCPTunnelConnector) ConnectContext(ctx context.Context, conn net.Conn) (net.Conn, error) {
                    switch con := conn.(type) {
                    case *net.TCPConn:
                        err := con.SetNoDelay(true)
                        if err != nil {
                Severity: Major
                Found in pkg/core/gvisorudphandler.go and 1 other location - About 1 hr to fix
                pkg/core/tcphandler.go on lines 23..41

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 171.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method PortForwarder.handleConnection has 67 lines of code (exceeds 50 allowed). Consider refactoring.
                Open

                func (pf *PortForwarder) handleConnection(conn net.Conn, port ForwardedPort) {
                    defer conn.Close()
                
                    if pf.out != nil {
                        fmt.Fprintf(pf.out, "Handling connection for %d\n", port.Local)
                Severity: Minor
                Found in pkg/util/portforward.go - About 1 hr to fix

                  Method SvrOption.Start has 67 lines of code (exceeds 50 allowed). Consider refactoring.
                  Open

                  func (o *SvrOption) Start(ctx context.Context) error {
                      l := &lumberjack.Logger{
                          Filename:   action.GetDaemonLogPath(),
                          MaxSize:    100,
                          MaxAge:     3,
                  Severity: Minor
                  Found in pkg/daemon/daemon.go - About 1 hr to fix

                    Function createTun has 67 lines of code (exceeds 50 allowed). Consider refactoring.
                    Open

                    func createTun(cfg Config) (conn net.Conn, itf *net.Interface, err error) {
                        if cfg.Addr == "" && cfg.Addr6 == "" {
                            err = fmt.Errorf("IPv4 address and IPv6 address can not be empty at same time")
                            return
                        }
                    Severity: Minor
                    Found in pkg/tun/tun_windows.go - About 1 hr to fix

                      Function gen has 67 lines of code (exceeds 50 allowed). Consider refactoring.
                      Open

                      func gen(connect *handler.ConnectOptions, clone *handler.CloneOptions) ([]*rpc.Proxy, []*rpc.Clone, error) {
                          var proxyList []*rpc.Proxy
                          if connect != nil && connect.GetClientset() != nil {
                              mapInterface := connect.GetClientset().CoreV1().ConfigMaps(connect.Namespace)
                              configMap, err := mapInterface.Get(context.Background(), config.ConfigMapPodTrafficManager, metav1.GetOptions{})
                      Severity: Minor
                      Found in pkg/daemon/action/status.go - About 1 hr to fix

                        Method ConnectOptions.DoConnect has 66 lines of code (exceeds 50 allowed). Consider refactoring.
                        Open

                        func (c *ConnectOptions) DoConnect(ctx context.Context, isLite bool) (err error) {
                            c.ctx, c.cancel = context.WithCancel(ctx)
                        
                            log.Info("Starting connect")
                            m := dhcp.NewDHCPManager(c.clientset.CoreV1().ConfigMaps(c.Namespace), c.Namespace)
                        Severity: Minor
                        Found in pkg/handler/connect.go - About 1 hr to fix

                          Function CmdAlias has 66 lines of code (exceeds 50 allowed). Consider refactoring.
                          Open

                          func CmdAlias(f cmdutil.Factory) *cobra.Command {
                              var localFile, remoteAddr string
                              cmd := &cobra.Command{
                                  Use:   "alias",
                                  Short: i18n.T("Config file alias to execute command simply"),
                          Severity: Minor
                          Found in cmd/kubevpn/cmds/alias.go - About 1 hr to fix

                            Method ConnectOptions.setupDNS has 66 lines of code (exceeds 50 allowed). Consider refactoring.
                            Open

                            func (c *ConnectOptions) setupDNS(ctx context.Context) error {
                                const port = 53
                                const portTCP = 10800
                                pod, err := c.GetRunningPodList(ctx)
                                if err != nil {
                            Severity: Minor
                            Found in pkg/handler/connect.go - About 1 hr to fix

                              Method wsHandler.installKubevpnOnRemote has 66 lines of code (exceeds 50 allowed). Consider refactoring.
                              Open

                              func (w *wsHandler) installKubevpnOnRemote(ctx context.Context, sshClient *ssh.Client) (err error) {
                                  defer func() {
                                      if err == nil {
                                          w.Log("Remote daemon server version: %s", startDaemonProcess(sshClient))
                                      }
                              Severity: Minor
                              Found in pkg/daemon/handler/ssh.go - About 1 hr to fix

                                Method Krb5InitiatorClient.InitSecContext has 66 lines of code (exceeds 50 allowed). Consider refactoring.
                                Open

                                func (k *Krb5InitiatorClient) InitSecContext(target string, token []byte, isGSSDelegCreds bool) ([]byte, bool, error) {
                                    GSSAPIFlags := []int{
                                        ContextFlagREADY,
                                        gssapi.ContextFlagInteg,
                                        gssapi.ContextFlagMutual,
                                Severity: Minor
                                Found in pkg/ssh/gssapi.go - About 1 hr to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language