kubenetworks/kubevpn

View on GitHub

Showing 526 of 526 total issues

Function CmdGet has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
Open

func CmdGet(f cmdutil.Factory) *cobra.Command {
    var printFlags = cmdget.NewGetPrintFlags()
    cmd := &cobra.Command{
        Use:    "get",
        Hidden: true,
Severity: Minor
Found in cmd/kubevpn/cmds/get.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createContainer has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
Open

func createContainer(ctx context.Context, dockerCli command.Cli, runConfig *RunConfig) (string, error) {
    config := runConfig.config
    hostConfig := runConfig.hostConfig
    networkingConfig := runConfig.networkingConfig
    var (
Severity: Minor
Found in pkg/dev/docker_utils.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createOutboundPod has 17 return statements (exceeds 4 allowed).
Open

func createOutboundPod(ctx context.Context, factory cmdutil.Factory, clientset *kubernetes.Clientset, namespace string) (err error) {
    innerIpv4CIDR := net.IPNet{IP: config.RouterIP, Mask: config.CIDR.Mask}
    innerIpv6CIDR := net.IPNet{IP: config.RouterIP6, Mask: config.CIDR6.Mask}

    service, err := clientset.CoreV1().Services(namespace).Get(ctx, config.ConfigMapPodTrafficManager, metav1.GetOptions{})
Severity: Major
Found in pkg/handler/remote.go - About 1 hr to fix

    Function runContainer has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
    Open

    func runContainer(ctx context.Context, dockerCli command.Cli, runConfig *RunConfig) error {
        config := runConfig.config
        stdout, stderr := dockerCli.Out(), dockerCli.Err()
        apiClient := dockerCli.Client()
    
    
    Severity: Minor
    Found in pkg/dev/docker_utils.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method CloneOptions.DoClone has 17 return statements (exceeds 4 allowed).
    Open

    func (d *CloneOptions) DoClone(ctx context.Context, kubeconfigJsonBytes []byte) error {
        var args []string
        if len(d.Headers) != 0 {
            args = append(args, "--headers", labels.Set(d.Headers).String())
        }
    Severity: Major
    Found in pkg/handler/clone.go - About 1 hr to fix

      Method CopyOptions.untarAll has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
      Open

      func (o *CopyOptions) untarAll(prefix string, dest localPath, reader io.Reader) error {
          // TODO: use compression here?
          tarReader := tar.NewReader(reader)
          var linkList []tar.Header
          var genDstFilename = func(headerName string) localPath {
      Severity: Minor
      Found in pkg/cp/cp.go - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method ConnectOptions.upgradeDeploy has 64 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (c *ConnectOptions) upgradeDeploy(ctx context.Context) error {
          deploy, err := c.clientset.AppsV1().Deployments(c.Namespace).Get(ctx, config.ConfigMapPodTrafficManager, metav1.GetOptions{})
          if err != nil {
              return err
          }
      Severity: Minor
      Found in pkg/handler/connect.go - About 1 hr to fix

        Function CmdStatus has 64 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func CmdStatus(f cmdutil.Factory) *cobra.Command {
            var aliasName string
            var localFile string
            var remoteAddr string
            var format string
        Severity: Minor
        Found in cmd/kubevpn/cmds/status.go - About 1 hr to fix

          Function legacyWaitExitOrRemoved has 64 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func legacyWaitExitOrRemoved(ctx context.Context, apiClient client.APIClient, containerID string, waitRemove bool) <-chan int {
              var removeErr error
              statusChan := make(chan int)
              exitCode := 125
          
          
          Severity: Minor
          Found in pkg/dev/docker_utils.go - About 1 hr to fix

            Method Server.SshStart has 64 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func (svr *Server) SshStart(ctx context.Context, req *rpc.SshStartRequest) (resp *rpc.SshStartResponse, err error) {
                mux.Lock()
                defer mux.Unlock()
            
                var clientIP net.IP
            Severity: Minor
            Found in pkg/daemon/action/sshdaemon.go - About 1 hr to fix

              Function TransferImage has 16 return statements (exceeds 4 allowed).
              Open

              func TransferImage(ctx context.Context, conf *SshConfig, imageSource, imageTarget string, out io.Writer) error {
                  client, cli, err := GetClient()
                  if err != nil {
                      log.Errorf("Failed to get docker client: %v", err)
                      return err
              Severity: Major
              Found in pkg/ssh/image.go - About 1 hr to fix

                Function CmdReset has 62 lines of code (exceeds 50 allowed). Consider refactoring.
                Open

                func CmdReset(f cmdutil.Factory) *cobra.Command {
                    var sshConf = &pkgssh.SshConfig{}
                    cmd := &cobra.Command{
                        Use:   "reset",
                        Short: "Reset all resource create by kubevpn in k8s cluster",
                Severity: Minor
                Found in cmd/kubevpn/cmds/reset.go - About 1 hr to fix

                  Function UDPForwarder has 62 lines of code (exceeds 50 allowed). Consider refactoring.
                  Open

                  func UDPForwarder(s *stack.Stack) func(id stack.TransportEndpointID, pkt *stack.PacketBuffer) bool {
                      GvisorUDPForwardAddr := GvisorUDPForwardAddr
                      return udp.NewForwarder(s, func(request *udp.ForwarderRequest) {
                          endpointID := request.ID()
                          log.Debugf("[TUN-UDP] LocalPort: %d, LocalAddress: %s, RemotePort: %d, RemoteAddress %s",
                  Severity: Minor
                  Found in pkg/core/gvisorudpforwarder.go - About 1 hr to fix

                    Function CmdDaemon has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
                    Open

                    func CmdDaemon(_ cmdutil.Factory) *cobra.Command {
                        var opt = &daemon.SvrOption{}
                        cmd := &cobra.Command{
                            Use:   "daemon",
                            Short: i18n.T("Startup kubevpn daemon server"),
                    Severity: Minor
                    Found in cmd/kubevpn/cmds/daemon.go - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function ConvertK8sApiServerToDomain has 15 return statements (exceeds 4 allowed).
                    Open

                    func ConvertK8sApiServerToDomain(kubeConfigPath string) (newPath string, err error) {
                        var kubeConfigBytes []byte
                        kubeConfigBytes, err = os.ReadFile(kubeConfigPath)
                        if err != nil {
                            return
                    Severity: Major
                    Found in pkg/util/kube.go - About 1 hr to fix

                      Method Manager.updateDHCPConfigMap has 15 return statements (exceeds 4 allowed).
                      Open

                      func (m *Manager) updateDHCPConfigMap(ctx context.Context, f func(ipv4 *ipallocator.Range, ipv6 *ipallocator.Range) error) error {
                          cm, err := m.client.Get(ctx, config.ConfigMapPodTrafficManager, metav1.GetOptions{})
                          if err != nil {
                              return fmt.Errorf("failed to get configmap DHCP server, err: %v", err)
                          }
                      Severity: Major
                      Found in pkg/dhcp/dhcp.go - About 1 hr to fix

                        Function createTun has 15 return statements (exceeds 4 allowed).
                        Open

                        func createTun(cfg Config) (conn net.Conn, itf *net.Interface, err error) {
                            if cfg.Addr == "" && cfg.Addr6 == "" {
                                err = fmt.Errorf("IPv4 address and IPv6 address can not be empty at same time")
                                return
                            }
                        Severity: Major
                        Found in pkg/tun/tun_windows.go - About 1 hr to fix

                          Function CmdCp has 60 lines of code (exceeds 50 allowed). Consider refactoring.
                          Open

                          func CmdCp(f cmdutil.Factory) *cobra.Command {
                              o := cp.NewCopyOptions(genericiooptions.IOStreams{
                                  In:     os.Stdin,
                                  Out:    os.Stdout,
                                  ErrOut: os.Stderr,
                          Severity: Minor
                          Found in cmd/kubevpn/cmds/cp.go - About 1 hr to fix

                            Function recursiveTar has 60 lines of code (exceeds 50 allowed). Consider refactoring.
                            Open

                            func recursiveTar(srcDir, srcFile localPath, destDir, destFile remotePath, tw *tar.Writer) error {
                                matchedPaths, err := srcDir.Join(srcFile).Glob()
                                if err != nil {
                                    return err
                                }
                            Severity: Minor
                            Found in pkg/cp/cp.go - About 1 hr to fix

                              Method ConnectOptions.getCIDR has 59 lines of code (exceeds 50 allowed). Consider refactoring.
                              Open

                              func (c *ConnectOptions) getCIDR(ctx context.Context, m *dhcp.Manager) (err error) {
                                  defer func() {
                                      if err == nil {
                                          u, err2 := url.Parse(c.config.Host)
                                          if err2 != nil {
                              Severity: Minor
                              Found in pkg/handler/connect.go - About 1 hr to fix
                                Severity
                                Category
                                Status
                                Source
                                Language