Sign upLogin

kunagpal/express-boilerplate

View on GitHub
Star

Showing 9 of 9 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        updateMany: function (filter, data, options, callback) {
            _.isFunction(options) && (callback = options) && (options = {});
            _.isFunction(data) && (callback = data) && (options = {}) && (data = filter) && (filter = {});

            return collection.updateMany(filter, sanitiseUpdate(data), options, callback);
Severity: Major
Found in utils/misc/index.js and 1 other location - About 3 hrs to fix
utils/misc/index.js on lines 152..157

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        updateOne: function (filter, datum, options, callback) {
            _.isFunction(options) && (callback = options) && (options = {});
            _.isFunction(datum) && (callback = datum) && (options = {}) && (datum = filter) && (filter = {});

            return collection.updateOne(filter, sanitiseUpdate(datum), options, callback);
Severity: Major
Found in utils/misc/index.js and 1 other location - About 3 hrs to fix
utils/misc/index.js on lines 171..176

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function exports has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function (done) {
    mongodb.connect(process.env.MONGO_URI || `mongodb://127.0.0.1:27017/${_.kebabCase(name)}${env ? '-' + env : ''}`,
        { w: 1 }, function (mongoError, db) {
            if (mongoError) { throw mongoError; }
Severity: Major
Found in app.js - About 2 hrs to fix

    File user.test.js has 263 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    describe('User', function () {
    beforeEach(testUtils.db.user);
    afterEach(function (done) {
        testUtils.db.purge(done);
    });
    Severity: Minor
    Found in test/unit/app/api/user.test.js - About 2 hrs to fix

      Function makeModel has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      exports.makeModel = function (modelName, db) {
    if (!(modelName && db)) { return {}; }

    var defaults = {},
        attributes = [],
      Severity: Major
      Found in utils/misc/index.js - About 2 hrs to fix

        Function exports has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = function (testDir, done) {
    _.isFunction(testDir) && (done = testDir) && (testDir = process.argv.splice(2)[0]);

    if (!testDir) { return done(new Error('A valid test directory is required')); }
        Severity: Minor
        Found in scripts/test/run.js - About 1 hr to fix

          Function exports has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

          module.exports = function (next) {
    try {
        fs.mkdirSync(TARGET_DIR); // eslint-disable-line no-sync
    } catch (e) {} // eslint-disable-line no-empty, brace-style
          Severity: Minor
          Found in scripts/misc/pack.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function passportCallback has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              passportCallback = function (req, token, refresh, profile, done) {
          Severity: Minor
          Found in utils/auth/passport.js - About 35 mins to fix

            Function makeModel has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            exports.makeModel = function (modelName, db) {
    if (!(modelName && db)) { return {}; }

    var defaults = {},
        attributes = [],
            Severity: Minor
            Found in utils/misc/index.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language