Sign upLogin

kwn/number-to-words

View on GitHub
Star

Showing 207 of 207 total issues

Function toCurrencyWords has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public function toCurrencyWords($currency, $decimal, $fraction = null)
    {
        $return = '';
        $currency = strtoupper($currency);
Severity: Minor
Found in src/Legacy/Numbers/Words/Locale/Dk.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function showDigitsGroup has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    private function showDigitsGroup($number, $noun, $forceNoun = false, $forcePlural = false)
    {
        $ret = '';

        $units = $number % 10;
Severity: Minor
Found in src/Legacy/Numbers/Words/Locale/Ro.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Es.php has 280 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace NumberToWords\Legacy\Numbers\Words\Locale;

use NumberToWords\Exception\NumberToWordsException;
Severity: Minor
Found in src/Legacy/Numbers/Words/Locale/Es.php - About 2 hrs to fix

    File Bg.php has 279 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace NumberToWords\Legacy\Numbers\Words\Locale;

use NumberToWords\Legacy\Numbers\Words;
    Severity: Minor
    Found in src/Legacy/Numbers/Words/Locale/Bg.php - About 2 hrs to fix

      Method toWords has 67 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function toWords($number, $use_suffix = true, $use_spaces = true)
    {
        $space = $use_spaces ? ' ' : '';
        if (!is_numeric($number)) {
            return false;
      Severity: Major
      Found in src/Legacy/Numbers/Words/Locale/Ka.php - About 2 hrs to fix

        Function getWordsBySplittingIntoTriplets has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

            private function getWordsBySplittingIntoTriplets(int $number): array
    {
        $words = [];
        $triplets = $this->numberToTripletsConverter->convertToTriplets($number);
        Severity: Minor
        Found in src/NumberTransformer/GenericNumberTransformer.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function transformToWords has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

            public function transformToWords(int $number, int $power): string
    {
        $units = $number % 10;
        $tens = (int) ($number / 10) % 10;
        $hundreds = (int) ($number / 100) % 10;
        Severity: Minor
        Found in src/Language/Bulgarian/BulgarianTripletTransformer.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method showDigitsGroup has 62 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function showDigitsGroup($num, $last = false)
    {
        $return = '';

        $ones = $num % 10;
        Severity: Major
        Found in src/Legacy/Numbers/Words/Locale/Fr.php - About 2 hrs to fix

          Method toCurrencyWords has 60 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function toCurrencyWords($currency, $decimal, $fraction = null)
    {
        $currency = strtoupper($currency);

        if (!array_key_exists($currency, static::$currencyNames)) {
          Severity: Major
          Found in src/Legacy/Numbers/Words/Locale/Ru.php - About 2 hrs to fix

            Method toWords has 57 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function toWords($num = 0)
    {
        $ret = [];

        $ret_minus = '';
            Severity: Major
            Found in src/Legacy/Numbers/Words/Locale/Bg.php - About 2 hrs to fix

              Function toCurrencyWords has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function toCurrencyWords($currency, $decimal, $fraction = null)
    {
        $currency = strtoupper($currency);

        if (!array_key_exists($currency, self::$currencyNames)) {
              Severity: Minor
              Found in src/Legacy/Numbers/Words/Locale/Tr.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function toCurrencyWords has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function toCurrencyWords($currency, $decimal, $fraction = null)
    {
        $currency = strtoupper($currency);

        if (!array_key_exists($currency, self::$currencyNames)) {
              Severity: Minor
              Found in src/Legacy/Numbers/Words/Locale/Uz.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function toWords has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function toWords($number, $use_suffix = true, $use_spaces = true)
    {
        $space = $use_spaces ? ' ' : '';
        if (!is_numeric($number)) {
            return false;
              Severity: Minor
              Found in src/Legacy/Numbers/Words/Locale/Ka.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method toWords has 55 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function toWords(int $amount, string $currency, ?CurrencyTransformerOptions $options = null): string
    {
        $dictionary = new BulgarianDictionary();
        $nounGenderInflector = new BulgarianNounGenderInflector();
        $numberToTripletsConverter = new NumberToTripletsConverter();
              Severity: Major
              Found in src/CurrencyTransformer/BulgarianCurrencyTransformer.php - About 2 hrs to fix

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                <?php

namespace NumberToWords\NumberTransformer;

use NumberToWords\Language\Slovak\SlovakDictionary;
                Severity: Major
                Found in src/NumberTransformer/SlovakNumberTransformer.php and 2 other locations - About 2 hrs to fix
                src/NumberTransformer/PolishNumberTransformer.php on lines 1..29
                src/NumberTransformer/SerbianNumberTransformer.php on lines 1..29

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 124.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    private static $exponent = [
        0 => [''],
        3 => ['ribu'],
        6 => ['juta'],
        9 => ['milyar'],
                Severity: Major
                Found in src/Legacy/Numbers/Words/Locale/Id.php and 1 other location - About 2 hrs to fix
                src/Legacy/Numbers/Words/Locale/Ms.php on lines 15..29

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 124.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                <?php

namespace NumberToWords\NumberTransformer;

use NumberToWords\Language\Polish\PolishDictionary;
                Severity: Major
                Found in src/NumberTransformer/PolishNumberTransformer.php and 2 other locations - About 2 hrs to fix
                src/NumberTransformer/SerbianNumberTransformer.php on lines 1..29
                src/NumberTransformer/SlovakNumberTransformer.php on lines 1..29

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 124.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    private static $exponent = [
        0 => [''],
        3 => ['ribu'],
        6 => ['juta'],
        9 => ['bilion'],
                Severity: Major
                Found in src/Legacy/Numbers/Words/Locale/Ms.php and 1 other location - About 2 hrs to fix
                src/Legacy/Numbers/Words/Locale/Id.php on lines 15..29

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 124.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                <?php

namespace NumberToWords\NumberTransformer;

use NumberToWords\Language\Serbian\SerbianDictionary;
                Severity: Major
                Found in src/NumberTransformer/SerbianNumberTransformer.php and 2 other locations - About 2 hrs to fix
                src/NumberTransformer/PolishNumberTransformer.php on lines 1..29
                src/NumberTransformer/SlovakNumberTransformer.php on lines 1..29

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 124.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                <?php

namespace NumberToWords\NumberTransformer;

use NumberToWords\Language\Albanian\AlbanianDictionary;
                Severity: Major
                Found in src/NumberTransformer/AlbanianNumberTransformer.php and 1 other location - About 2 hrs to fix
                src/NumberTransformer/KurdishNumberTransformer.php on lines 1..29

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 123.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language