kwn/number-to-words

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace NumberToWords\NumberTransformer;

use NumberToWords\Language\Albanian\AlbanianDictionary;

Found in src/NumberTransformer/AlbanianNumberTransformer.php and 1 other location - About 2 hrs to fix

Read up
Read up

src/NumberTransformer/KurdishNumberTransformer.php on lines 1..29

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 123.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Function `toWords` has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    protected function toWords($num = 0, $noun = [])
    {
        if (empty($noun)) {
            $noun = [null, null, Gender::GENDER_ABSTRACT];
        }

Found in src/Legacy/Numbers/Words/Locale/Ro.php - About 2 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `toCurrencyWords` has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function toCurrencyWords($currency, $decimal, $fraction = null)
    {
        $negative = 0;
        $ret = [];
        $noDecimals = false;

Found in src/Legacy/Numbers/Words/Locale/Pt/Br.php - About 2 hrs to fix

File `It.php` has 253 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace NumberToWords\Legacy\Numbers\Words\Locale;

use NumberToWords\Legacy\Numbers\Words;

Found in src/Legacy/Numbers/Words/Locale/It.php - About 2 hrs to fix

Method `toWords` has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function toWords(int $amount, string $currency, ?CurrencyTransformerOptions $options = null): string
    {
        $dictionary = new SerbianDictionary();
        $nounGenderInflector = new SerbianNounGenderInflector();
        $numberToTripletsConverter = new NumberToTripletsConverter();

Found in src/CurrencyTransformer/SerbianCurrencyTransformer.php - About 2 hrs to fix

Method `showDigitsGroup` has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function showDigitsGroup($num, $gender = 0, $last = false)
    {
        /* A storage array for the return string.
             Positions 1, 3, 5 are intended for digit words
             and everything else (0, 2, 4) for "and" words.

Found in src/Legacy/Numbers/Words/Locale/Bg.php - About 2 hrs to fix

Method `toWords` has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function toWords(int $amount, string $currency, ?CurrencyTransformerOptions $options = null): string
    {
        $dictionary = new GermanDictionary();
        $numberToTripletsConverter = new NumberToTripletsConverter();
        $tripletTransformer = new GermanTripletTransformer($dictionary);

Found in src/CurrencyTransformer/GermanCurrencyTransformer.php - About 1 hr to fix

Method `showDigitsGroup` has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function showDigitsGroup($number, $last = false)
    {
        $ret = '';

        $units = $number % 10;

Found in src/Legacy/Numbers/Words/Locale/Fr/Be.php - About 1 hr to fix

Function `toWords` has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function toWords(int $amount, string $currency, ?CurrencyTransformerOptions $options = null): string
    {
        $dictionary = new EnglishDictionary();
        $numberToTripletsConverter = new NumberToTripletsConverter();
        $tripletTransformer = new EnglishTripletTransformer($dictionary);

Found in src/CurrencyTransformer/EnglishCurrencyTransformer.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `toWords` has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function toWords(int $amount, string $currency, ?CurrencyTransformerOptions $options = null): string
    {
        $dictionary = new GermanDictionary();
        $numberToTripletsConverter = new NumberToTripletsConverter();
        $tripletTransformer = new GermanTripletTransformer($dictionary);

Found in src/CurrencyTransformer/GermanCurrencyTransformer.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `toWords` has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    protected function toWords($num)
    {
        $ret = '';
        $num = strval($num);

Found in src/Legacy/Numbers/Words/Locale/Uz.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `toWords` has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function toWords(int $amount, string $currency, ?CurrencyTransformerOptions $options = null): string
    {
        $dictionary = new AlbanianDictionary();
        $numberToTripletsConverter = new NumberToTripletsConverter();
        $tripletTransformer = new AlbanianTripletTransformer($dictionary);

Found in src/CurrencyTransformer/AlbanianCurrencyTransformer.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `toWords` has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function toWords(int $amount, string $currency, ?CurrencyTransformerOptions $options = null): string
    {
        $dictionary = new AzerbaijaniDictionary();
        $numberToTripletsConverter = new NumberToTripletsConverter();
        $tripletTransformer = new AzerbaijaniTripletTransformer($dictionary);

Found in src/CurrencyTransformer/AzerbaijaniCurrencyTransformer.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `toWords` has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    protected function toWords($num)
    {
        $ret = '';
        $num = strval($num);

Found in src/Legacy/Numbers/Words/Locale/Tr.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `toWords` has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function toWords(int $amount, string $currency, ?CurrencyTransformerOptions $options = null): string
    {
        $dictionary = new UzbekDictionary();
        $numberToTripletsConverter = new NumberToTripletsConverter();
        $tripletTransformer = new UzbekTripletTransformer($dictionary);

Found in src/CurrencyTransformer/UzbekCurrencyTransformer.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Method `toWords` has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function toWords(int $amount, string $currency, ?CurrencyTransformerOptions $options = null): string
    {
        $dictionary = new AlbanianDictionary();
        $numberToTripletsConverter = new NumberToTripletsConverter();
        $tripletTransformer = new AlbanianTripletTransformer($dictionary);

Found in src/CurrencyTransformer/AlbanianCurrencyTransformer.php - About 1 hr to fix

Method `toWords` has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function toWords(int $amount, string $currency, ?CurrencyTransformerOptions $options = null): string
    {
        $dictionary = new AzerbaijaniDictionary();
        $numberToTripletsConverter = new NumberToTripletsConverter();
        $tripletTransformer = new AzerbaijaniTripletTransformer($dictionary);

Found in src/CurrencyTransformer/AzerbaijaniCurrencyTransformer.php - About 1 hr to fix

Method `toWords` has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function toWords(int $amount, string $currency, ?CurrencyTransformerOptions $options = null): string
    {
        $dictionary = new EnglishDictionary();
        $numberToTripletsConverter = new NumberToTripletsConverter();
        $tripletTransformer = new EnglishTripletTransformer($dictionary);

Found in src/CurrencyTransformer/EnglishCurrencyTransformer.php - About 1 hr to fix

Method `toWords` has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function toWords(int $amount, string $currency, ?CurrencyTransformerOptions $options = null): string
    {
        $dictionary = new UzbekDictionary();
        $numberToTripletsConverter = new NumberToTripletsConverter();
        $tripletTransformer = new UzbekTripletTransformer($dictionary);

Found in src/CurrencyTransformer/UzbekCurrencyTransformer.php - About 1 hr to fix

Similar blocks of code found in 5 locations. Consider refactoring.
Open

<?php

namespace NumberToWords\NumberTransformer;

use NumberToWords\Language\Latvian\LatvianDictionary;

Found in src/NumberTransformer/LatvianNumberTransformer.php and 4 other locations - About 1 hr to fix

Read up
Read up

src/NumberTransformer/AzerbaijaniNumberTransformer.php on lines 1..28

src/NumberTransformer/EnglishNumberTransformer.php on lines 1..28

src/NumberTransformer/GermanNumberTransformer.php on lines 1..28

src/NumberTransformer/UzbekNumberTransformer.php on lines 1..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76