lancew/DojoList

View on GitHub

Showing 1,912 of 1,912 total issues

Function has a complexity of 23.
Open

Mapstraction.prototype.addPolyline = function(polyline, old) {
Severity: Minor
Found in js/mapstraction.js by eslint

Limit Cyclomatic Complexity (complexity)

Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

function a(x) {
    if (true) {
        return x; // 1st path
    } else if (false) {
        return x+1; // 2nd path
    } else {
        return 4; // 3rd path
    }
}

Rule Details

This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

Examples of incorrect code for a maximum of 2:

/*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else if (false) {
        return x+1;
    } else {
        return 4; // 3rd path
    }
}

Examples of correct code for a maximum of 2:

/*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else {
        return 4;
    }
}

Options

Optionally, you may specify a max object property:

"complexity": ["error", 2]

is equivalent to

"complexity": ["error", { "max": 2 }]

Deprecated: the object property maximum is deprecated. Please use the property max instead.

When Not To Use It

If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

Further Reading

Related Rules

  • [max-depth](max-depth.md)
  • [max-len](max-len.md)
  • [max-nested-callbacks](max-nested-callbacks.md)
  • [max-params](max-params.md)
  • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

Method Dojo_Editform_end has 89 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function Dojo_Editform_end() 
{
    if (!Validate_form($_POST) ) {
        $resp = recaptcha_check_answer(
            option('recaptcha_private_key'),
Severity: Major
Found in controllers/dojo.php - About 3 hrs to fix

    Function has a complexity of 21.
    Open

    Mapstraction.writeInclude = function(api, key, version) {
    Severity: Minor
    Found in js/mapstraction.js by eslint

    Limit Cyclomatic Complexity (complexity)

    Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

    function a(x) {
        if (true) {
            return x; // 1st path
        } else if (false) {
            return x+1; // 2nd path
        } else {
            return 4; // 3rd path
        }
    }

    Rule Details

    This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

    Examples of incorrect code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/
    
    function a(x) {
        if (true) {
            return x;
        } else if (false) {
            return x+1;
        } else {
            return 4; // 3rd path
        }
    }

    Examples of correct code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/
    
    function a(x) {
        if (true) {
            return x;
        } else {
            return 4;
        }
    }

    Options

    Optionally, you may specify a max object property:

    "complexity": ["error", 2]

    is equivalent to

    "complexity": ["error", { "max": 2 }]

    Deprecated: the object property maximum is deprecated. Please use the property max instead.

    When Not To Use It

    If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

    Further Reading

    Related Rules

    • [max-depth](max-depth.md)
    • [max-len](max-len.md)
    • [max-nested-callbacks](max-nested-callbacks.md)
    • [max-params](max-params.md)
    • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

    Function has a complexity of 21.
    Open

    Mapstraction.prototype.removeAllPolylines = function() {
    Severity: Minor
    Found in js/mapstraction.js by eslint

    Limit Cyclomatic Complexity (complexity)

    Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

    function a(x) {
        if (true) {
            return x; // 1st path
        } else if (false) {
            return x+1; // 2nd path
        } else {
            return 4; // 3rd path
        }
    }

    Rule Details

    This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

    Examples of incorrect code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/
    
    function a(x) {
        if (true) {
            return x;
        } else if (false) {
            return x+1;
        } else {
            return 4; // 3rd path
        }
    }

    Examples of correct code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/
    
    function a(x) {
        if (true) {
            return x;
        } else {
            return 4;
        }
    }

    Options

    Optionally, you may specify a max object property:

    "complexity": ["error", 2]

    is equivalent to

    "complexity": ["error", { "max": 2 }]

    Deprecated: the object property maximum is deprecated. Please use the property max instead.

    When Not To Use It

    If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

    Further Reading

    Related Rules

    • [max-depth](max-depth.md)
    • [max-len](max-len.md)
    • [max-nested-callbacks](max-nested-callbacks.md)
    • [max-params](max-params.md)
    • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

    Function setBounds has 84 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Mapstraction.prototype.setBounds = function(bounds){
        if(this.loaded[this.api] === false) {
            var me = this;
            this.onload[this.api].push( function() {
                me.setBounds(bounds);
    Severity: Major
    Found in js/mapstraction.js - About 3 hrs to fix

      Function KMLparser has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

      function KMLparser(path,map){ //path: url to the kml file. map: div where the map is
         var request = GXmlHttp.create();
         request.open('GET', path, true);
         request.onreadystatechange = function(){        
              if (request.readyState == 4){
      Severity: Minor
      Found in js/KMLparser.js - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        next: function(element, expression, index) {
          element = $(element);
          if (arguments.length == 1) return $(Selector.handlers.nextElementSibling(element));
          var nextSiblings = element.nextSiblings();
          return Object.isNumber(expression) ? nextSiblings[expression] :
      Severity: Major
      Found in js/prototype/prototype-1.6.0.3.js and 1 other location - About 3 hrs to fix
      js/prototype/prototype-1.6.0.3.js on lines 1753..1759

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 100.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        previous: function(element, expression, index) {
          element = $(element);
          if (arguments.length == 1) return $(Selector.handlers.previousElementSibling(element));
          var previousSiblings = element.previousSiblings();
          return Object.isNumber(expression) ? previousSiblings[expression] :
      Severity: Major
      Found in js/prototype/prototype-1.6.0.3.js and 1 other location - About 3 hrs to fix
      js/prototype/prototype-1.6.0.3.js on lines 1761..1767

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 100.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function getMapType has 80 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Mapstraction.prototype.getMapType = function() {
          if(this.loaded[this.api] === false) {
              var me = this;
              return -1;
          }
      Severity: Major
      Found in js/mapstraction.js - About 3 hrs to fix

        Method Create_dojo has 78 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function Create_dojo($dojo, $file = null)
        {
            Backup_data();
            
            $xml = Load_Xml_data();
        Severity: Major
        Found in lib/dojo.model.php - About 3 hrs to fix

          Method request_uri has 78 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function request_uri($env = null)
          {
            static $uri = null;
            if(is_null($env))
            {
          Severity: Major
          Found in lib/limonade.php - About 3 hrs to fix

            Function getStyle has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
            Open

              Element.Methods.getStyle = function(element, style) {
                element = $(element);
                style = (style == 'float' || style == 'cssFloat') ? 'styleFloat' : style.camelize();
                var value = element.style[style];
                if (!value && element.currentStyle) value = element.currentStyle[style];
            Severity: Minor
            Found in js/prototype/prototype-1.6.0.3.js - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function serializeElements has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
            Open

              serializeElements: function(elements, options) {
                if (typeof options != 'object') options = { hash: !!options };
                else if (Object.isUndefined(options.hash)) options.hash = true;
                var key, value, submitted = false, submit = options.submit;
            
            
            Severity: Minor
            Found in js/prototype/prototype-1.6.0.3.js - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function has a complexity of 18.
            Open

            Mapstraction.prototype.setBounds = function(bounds){
            Severity: Minor
            Found in js/mapstraction.js by eslint

            Limit Cyclomatic Complexity (complexity)

            Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

            function a(x) {
                if (true) {
                    return x; // 1st path
                } else if (false) {
                    return x+1; // 2nd path
                } else {
                    return 4; // 3rd path
                }
            }

            Rule Details

            This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

            Examples of incorrect code for a maximum of 2:

            /*eslint complexity: ["error", 2]*/
            
            function a(x) {
                if (true) {
                    return x;
                } else if (false) {
                    return x+1;
                } else {
                    return 4; // 3rd path
                }
            }

            Examples of correct code for a maximum of 2:

            /*eslint complexity: ["error", 2]*/
            
            function a(x) {
                if (true) {
                    return x;
                } else {
                    return 4;
                }
            }

            Options

            Optionally, you may specify a max object property:

            "complexity": ["error", 2]

            is equivalent to

            "complexity": ["error", { "max": 2 }]

            Deprecated: the object property maximum is deprecated. Please use the property max instead.

            When Not To Use It

            If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

            Further Reading

            Related Rules

            • [max-depth](max-depth.md)
            • [max-len](max-len.md)
            • [max-nested-callbacks](max-nested-callbacks.md)
            • [max-params](max-params.md)
            • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

            Function Hash has 74 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            var Hash = Class.create(Enumerable, (function() {
            
              function toQueryPair(key, value) {
                if (Object.isUndefined(value)) return key;
                return key + '=' + encodeURIComponent(String.interpret(value));
            Severity: Major
            Found in js/prototype/prototype-1.6.0.3.js - About 2 hrs to fix

              Method route_build has 74 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function route_build($method, $path_or_array, $callback, $options = array())
              {
                $method = strtoupper($method);
                if(!in_array($method, request_methods())) 
                  trigger_error("'$method' request method is unkown or unavailable.", E_USER_WARNING);
              Severity: Major
              Found in lib/limonade.php - About 2 hrs to fix

                Function has a complexity of 17.
                Open

                Mapstraction.prototype.setCenter = function(point, options) {
                Severity: Minor
                Found in js/mapstraction.js by eslint

                Limit Cyclomatic Complexity (complexity)

                Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

                function a(x) {
                    if (true) {
                        return x; // 1st path
                    } else if (false) {
                        return x+1; // 2nd path
                    } else {
                        return 4; // 3rd path
                    }
                }

                Rule Details

                This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

                Examples of incorrect code for a maximum of 2:

                /*eslint complexity: ["error", 2]*/
                
                function a(x) {
                    if (true) {
                        return x;
                    } else if (false) {
                        return x+1;
                    } else {
                        return 4; // 3rd path
                    }
                }

                Examples of correct code for a maximum of 2:

                /*eslint complexity: ["error", 2]*/
                
                function a(x) {
                    if (true) {
                        return x;
                    } else {
                        return 4;
                    }
                }

                Options

                Optionally, you may specify a max object property:

                "complexity": ["error", 2]

                is equivalent to

                "complexity": ["error", { "max": 2 }]

                Deprecated: the object property maximum is deprecated. Please use the property max instead.

                When Not To Use It

                If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

                Further Reading

                Related Rules

                • [max-depth](max-depth.md)
                • [max-len](max-len.md)
                • [max-nested-callbacks](max-nested-callbacks.md)
                • [max-params](max-params.md)
                • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

                Function has a complexity of 17.
                Open

                Mapstraction.prototype.setCenterAndZoom = function(point, zoom) {
                Severity: Minor
                Found in js/mapstraction.js by eslint

                Limit Cyclomatic Complexity (complexity)

                Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

                function a(x) {
                    if (true) {
                        return x; // 1st path
                    } else if (false) {
                        return x+1; // 2nd path
                    } else {
                        return 4; // 3rd path
                    }
                }

                Rule Details

                This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

                Examples of incorrect code for a maximum of 2:

                /*eslint complexity: ["error", 2]*/
                
                function a(x) {
                    if (true) {
                        return x;
                    } else if (false) {
                        return x+1;
                    } else {
                        return 4; // 3rd path
                    }
                }

                Examples of correct code for a maximum of 2:

                /*eslint complexity: ["error", 2]*/
                
                function a(x) {
                    if (true) {
                        return x;
                    } else {
                        return 4;
                    }
                }

                Options

                Optionally, you may specify a max object property:

                "complexity": ["error", 2]

                is equivalent to

                "complexity": ["error", { "max": 2 }]

                Deprecated: the object property maximum is deprecated. Please use the property max instead.

                When Not To Use It

                If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

                Further Reading

                Related Rules

                • [max-depth](max-depth.md)
                • [max-len](max-len.md)
                • [max-nested-callbacks](max-nested-callbacks.md)
                • [max-params](max-params.md)
                • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

                Method 'id' has a complexity of 17.
                Open

                    id: function(nodes, root, id, combinator) {
                Severity: Minor
                Found in js/prototype/prototype-1.6.0.3.js by eslint

                Limit Cyclomatic Complexity (complexity)

                Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

                function a(x) {
                    if (true) {
                        return x; // 1st path
                    } else if (false) {
                        return x+1; // 2nd path
                    } else {
                        return 4; // 3rd path
                    }
                }

                Rule Details

                This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

                Examples of incorrect code for a maximum of 2:

                /*eslint complexity: ["error", 2]*/
                
                function a(x) {
                    if (true) {
                        return x;
                    } else if (false) {
                        return x+1;
                    } else {
                        return 4; // 3rd path
                    }
                }

                Examples of correct code for a maximum of 2:

                /*eslint complexity: ["error", 2]*/
                
                function a(x) {
                    if (true) {
                        return x;
                    } else {
                        return 4;
                    }
                }

                Options

                Optionally, you may specify a max object property:

                "complexity": ["error", 2]

                is equivalent to

                "complexity": ["error", { "max": 2 }]

                Deprecated: the object property maximum is deprecated. Please use the property max instead.

                When Not To Use It

                If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

                Further Reading

                Related Rules

                • [max-depth](max-depth.md)
                • [max-len](max-len.md)
                • [max-nested-callbacks](max-nested-callbacks.md)
                • [max-params](max-params.md)
                • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

                Function addMethods has 73 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                Element.addMethods = function(methods) {
                  var F = Prototype.BrowserFeatures, T = Element.Methods.ByTag;
                
                  if (!methods) {
                    Object.extend(Form, Form.Methods);
                Severity: Major
                Found in js/prototype/prototype-1.6.0.3.js - About 2 hrs to fix
                  Severity
                  Category
                  Status
                  Source
                  Language