Sign upLogin

lud/press

View on GitHub
Star

Showing 13 of 13 total issues

PressService has 38 functions (exceeds 20 allowed). Consider refactoring.
Open

class PressService
{

    const FILE_PATH_TYPE = 1;
    const URL_PATH_TYPE = 2;
Severity: Minor
Found in src/Lud/Press/PressService.php - About 5 hrs to fix

    File PressService.php has 341 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php namespace Lud\Press;

// @todo split object responsibilities

use Illuminate\Support\Facades\Route;
    Severity: Minor
    Found in src/Lud/Press/PressService.php - About 4 hrs to fix

      Method parseMeta has 61 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function parseMeta()
    {

        //@todo refactor : set an array of defaults, then build the meta object
        // from the defaults and then override
      Severity: Major
      Found in src/Lud/Press/PressFile.php - About 2 hrs to fix

        Function parseMeta has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            public function parseMeta()
    {

        //@todo refactor : set an array of defaults, then build the meta object
        // from the defaults and then override
        Severity: Minor
        Found in src/Lud/Press/PressFile.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method build has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function build($forceRebuild = false)
    {
        if (null !== $this->ramCache && !$forceRebuild) {
            return $this->ramCache;
        }
        Severity: Minor
        Found in src/Lud/Press/PressIndex.php - About 1 hr to fix

          Method makeReduce has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function makeReduce($name, $value)
    {
        switch ($name) {
            case 'all':
                return function(Collection $collection) {
          Severity: Minor
          Found in src/Lud/Press/PressIndex.php - About 1 hr to fix

            Method showCollection has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function showCollection(Route $route, Router $router)
    {

        // We extract the params not set in the query from the URL
        $queryParams = $route->parameters();
            Severity: Minor
            Found in src/Lud/Press/PressPubController.php - About 1 hr to fix

              Function build has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function build($forceRebuild = false)
    {
        if (null !== $this->ramCache && !$forceRebuild) {
            return $this->ramCache;
        }
              Severity: Minor
              Found in src/Lud/Press/PressIndex.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function replaceStrParts has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function replaceStrParts($schema, $values)
    {
        if (is_callable($values)) {
            $getVal = $values;
        } else {
              Severity: Minor
              Found in src/Lud/Press/PressService.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                              return function(Collection $collection) {
                    return $collection->count();
                };
              Severity: Major
              Found in src/Lud/Press/PressIndex.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return function(Collection $collection) use ($value) {
                    return $collection->filter(function($meta) use ($value) {
                        return starts_with($meta->rel_path, $value);
                    });
                };
                Severity: Major
                Found in src/Lud/Press/PressIndex.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return $this->ramCache;
                  Severity: Major
                  Found in src/Lud/Press/PressIndex.php - About 30 mins to fix

                    Function showCollection has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function showCollection(Route $route, Router $router)
    {

        // We extract the params not set in the query from the URL
        $queryParams = $route->parameters();
                    Severity: Minor
                    Found in src/Lud/Press/PressPubController.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language