lugu/qiloop

Similar blocks of code found in 5 locations. Consider refactoring.

Open

func (p *proxyALMotion) WakeUp() error {
    var ret struct{}
    args := bus.NewParams("()")
    resp := bus.NewResponse("v", &ret)
    err := p.Proxy().Call2("wakeUp", args, resp)

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

func (p *proxyALMotion) Rest() error {
    var ret struct{}
    args := bus.NewParams("()")
    resp := bus.NewResponse("v", &ret)
    err := p.Proxy().Call2("rest", args, resp)

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

func (p *proxyALMotion) WaitUntilMoveIsFinished() error {
    var ret struct{}
    args := bus.NewParams("()")
    resp := bus.NewResponse("v", &ret)
    err := p.Proxy().Call2("waitUntilMoveIsFinished", args, resp)

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

func (p *proxyALRobotPosture) StopMove() error {
    var ret struct{}
    args := bus.NewParams("()")
    resp := bus.NewResponse("v", &ret)
    err := p.Proxy().Call2("stopMove", args, resp)

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

func (p *proxyALMotion) MoveInit() error {
    var ret struct{}
    args := bus.NewParams("()")
    resp := bus.NewResponse("v", &ret)
    err := p.Proxy().Call2("moveInit", args, resp)

• Read up
  Read up

Method Message.Read has 7 return statements (exceeds 4 allowed).

Open

func (m *Message) Read(r io.Reader) error {

    // Read the complete header, then parse the fields.
    b := make([]byte, HeaderSize)
    if err := basic.ReadN(r, b, HeaderSize); err != nil {

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if ret.Signature() != "v" {
            writing = append(writing, jen.If(jen.Err().Op("=").Add(v.Type.Marshal(v.Name, "&buf")).Op(";").Err().Op("!=").Nil()).Block(
                jen.Id(`return ret, fmt.Errorf("serialize `+v.Name+`: %s", err)`),
            ))
        } else {

• Read up
  Read up

Avoid deeply nested control flow statements.

Open

            if err == nil {
                err = fmt.Errorf("no progress")
            }

Avoid deeply nested control flow statements.

Open

            if err != nil {
                return fmt.Errorf("read %v: %w",
                    v.Type().Name(), err)
            }

Function Parse has 7 return statements (exceeds 4 allowed).

Open

func Parse(input string) (Type, error) {
    text := []byte(input)

    root, rest := typeSignature(parsec.NewScanner(text))
    if root == nil {

Avoid deeply nested control flow statements.

Open

            if err == nil {
                err = fmt.Errorf("no progress")
            }

Function convertFrom has 7 return statements (exceeds 4 allowed).

Open

func convertFrom(v, w reflect.Value) error {

    errConversion := fmt.Errorf("Failed to convert %v into %v",
        v.Type(), w.Type())

Avoid deeply nested control flow statements.

Open

    } else if logCommand.Used {
        logger(serverURL, logLevel)
    } else if serverCommand.Used {
        server(serverURL)
    } else if traceCommand.Used {

Method signalHandler.RegisterEvent has 7 return statements (exceeds 4 allowed).

Open

func (o *signalHandler) RegisterEvent(msg *net.Message, from Channel) error {

    buf := bytes.NewBuffer(msg.Payload)
    objectID, err := basic.ReadUint32(buf)
    if err != nil {

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        } else {
            writing = append(writing, jen.If(jen.Err().Op("=").Add(v.Type.Marshal(v.Name, "&buf")).Op(";").Err().Op("!=").Nil()).Block(
                jen.Id(`return fmt.Errorf("serialize `+v.Name+`: %s", err)`),
            ))
        }

• Read up
  Read up

Method proxy.Call2 has 7 return statements (exceeds 4 allowed).

Open

func (p proxy) Call2(method string, args Params, ret Response) error {
    methodID, sig, err := p.MetaObject().MethodID(method, args.Signature())
    if err != nil {
        return err
    }

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (s *Session) findServiceName(name string) (i services.ServiceInfo, err error) {
    s.serviceListMutex.Lock()
    defer s.serviceListMutex.Unlock()
    for _, service := range s.serviceList {
        if service.Name == name {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func (s *Session) findServiceID(uid uint32) (i services.ServiceInfo, err error) {
    s.serviceListMutex.Lock()
    defer s.serviceListMutex.Unlock()
    for _, service := range s.serviceList {
        if service.ServiceId == uid {

• Read up
  Read up

Function GenerateIDL has 6 return statements (exceeds 4 allowed).

Open

func GenerateIDL(writer io.Writer, packageName string, objs map[string]object.MetaObject) error {
    set := signature.NewTypeSet()

    fmt.Fprintf(writer, "package %s\n", packageName)
    scope := NewScope()

Method pipeListener.Accept has 6 return statements (exceeds 4 allowed).

Open

func (c pipeListener) Accept() (Stream, error) {
    conn, err := c.l.AcceptUnix()
    if err != nil {
        return nil, err
    }