Sign upLogin

luyadev/luya-module-cms

View on GitHub
Star

Showing 326 of 326 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        $blockItemFixture = new NgRestModelFixture([
            'modelClass' => NavItemPageBlockItem::class,
            'fixtureData' => [
                'item1' => [
                    'id' => 1,
Severity: Major
Found in tests/src/base/BlockPlaceholderIterationTest.php and 1 other location - About 4 hrs to fix
tests/src/base/BlockPlaceholderIterationTest.php on lines 55..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 182.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        $blockItemFixture = new NgRestModelFixture([
            'modelClass' => NavItemPageBlockItem::class,
            'fixtureData' => [
                'item1' => [
                    'id' => 1,
Severity: Major
Found in tests/src/base/BlockPlaceholderIterationTest.php and 1 other location - About 4 hrs to fix
tests/src/base/BlockPlaceholderIterationTest.php on lines 138..175

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 182.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File NavItemController.php has 372 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace luya\cms\admin\apis;

use luya\cms\admin\Module;
Severity: Minor
Found in src/admin/apis/NavItemController.php - About 4 hrs to fix

    File NavItemPage.php has 370 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace luya\cms\models;

use luya\cms\admin\Module;
    Severity: Minor
    Found in src/models/NavItemPage.php - About 4 hrs to fix

      File Item.php has 358 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php

namespace luya\cms\menu;

use luya\admin\models\User;
      Severity: Minor
      Found in src/menu/Item.php - About 4 hrs to fix

        Method testRenderToolbar has 114 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function testRenderToolbar()
    {
        //region Fictures

        $adminGroupFixture = new ActiveRecordFixture([
        Severity: Major
        Found in tests/src/controllers/DefaultControllerTest.php - About 4 hrs to fix

          File BlockController.php has 352 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php

namespace luya\cms\frontend\commands;

use luya\cms\models\Block;
          Severity: Minor
          Found in src/frontend/commands/BlockController.php - About 4 hrs to fix

            Nav has 34 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class Nav extends ActiveRecord
{
    use TaggableTrait;

    /**
            Severity: Minor
            Found in src/models/Nav.php - About 4 hrs to fix

              Function actionUpdatePageItem has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function actionUpdatePageItem($navItemId, $navItemType): array|bool
    {
        $model = NavItem::findOne($navItemId);

        if (!$model) {
              Severity: Minor
              Found in src/admin/apis/NavItemController.php - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method actionUpdatePageItem has 105 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function actionUpdatePageItem($navItemId, $navItemType): array|bool
    {
        $model = NavItem::findOne($navItemId);

        if (!$model) {
              Severity: Major
              Found in src/admin/apis/NavItemController.php - About 4 hrs to fix

                Menu has 33 functions (exceeds 20 allowed). Consider refactoring.
                Open

                class Menu extends Component implements \ArrayAccess, QueryOperatorFieldInterface
{
    use CacheableTrait;

    /**
                Severity: Minor
                Found in src/Menu.php - About 4 hrs to fix

                  File Menu.php has 336 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php

namespace luya\cms;

use luya\cms\menu\InjectItemInterface;
                  Severity: Minor
                  Found in src/Menu.php - About 4 hrs to fix

                    Method afterSetup has 99 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function afterSetup()
    {
        parent::afterSetup();

        $this->createAdminUserFixture([
                    Severity: Major
                    Found in tests/src/admin/apis/MenuControllerTest.php - About 3 hrs to fix

                      File NavControllerTest.php has 331 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      <?php

namespace cmstests\src\admin\apis;

use cmstests\WebModelTestCase;
                      Severity: Minor
                      Found in tests/src/admin/apis/NavControllerTest.php - About 3 hrs to fix

                        Method testSetUrlRuleParamsForI18nSlugUrlRules has 98 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function testSetUrlRuleParamsForI18nSlugUrlRules()
    {
        $langFixture = $this->createAdminLangFixture([
            'de' => [
                'id' => 1,
                        Severity: Major
                        Found in tests/src/widgets/LangSwitcherSqliteTest.php - About 3 hrs to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                          <?php

namespace cmstests\data\blocks\import;

use luya\cms\base\PhpBlock;
                          Severity: Major
                          Found in tests/data/blocks/import/TestBlock.php and 1 other location - About 3 hrs to fix
                          tests/data/blocks/TestBlock.php on lines 1..43

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 156.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                          <?php

namespace cmstests\data\blocks;

use luya\cms\base\PhpBlock;
                          Severity: Major
                          Found in tests/data/blocks/TestBlock.php and 1 other location - About 3 hrs to fix
                          tests/data/blocks/import/TestBlock.php on lines 1..43

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 156.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Method testModuleBlock has 90 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function testModuleBlock()
    {
        $tpl = <<<'EOT'
<?php
                          Severity: Major
                          Found in tests/src/frontend/commands/BlockControllerTest.php - About 3 hrs to fix

                            File NavItem.php has 316 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            <?php

namespace luya\cms\models;

use luya\admin\base\GenericSearchInterface;
                            Severity: Minor
                            Found in src/models/NavItem.php - About 3 hrs to fix

                              Function getItems has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  public static function getItems()
    {
        if (self::$items === null) {
            $items = Nav::find()
                ->select(['cms_nav.id', 'nav_item_id' => 'cms_nav_item.id', 'nav_container_id', 'parent_nav_id', 'is_hidden', 'layout_file', 'is_offline', 'is_draft', 'is_home', 'cms_nav_item.title'])
                              Severity: Minor
                              Found in src/admin/helpers/MenuHelper.php - About 3 hrs to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Severity
                              Category
                              Status
                              Source
                              Language