Sign upLogin

luyadev/luya-module-cms

View on GitHub
Star

Showing 326 of 326 total issues

Function updateNavItemData has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        $scope.updateNavItemData = function(itemCopy, typeDataCopy) {
            $scope.errors = [];
            var headers = {"headers" : { "Content-Type" : "application/x-www-form-urlencoded; charset=UTF-8" }};
            var navItemId = itemCopy.id;
Severity: Minor
Found in src/admin/resources/js/cmsadmin.js - About 1 hr to fix

    Method createRedirect has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function createRedirect($parentNavId, $navContainerId, $langId, $title, $alias, $redirectType, $redirectTypeValue, $description, $redirectTypeTarget, $anchor = null): array|int
    {
        $_errors = [];

        $nav = $this;
    Severity: Minor
    Found in src/models/Nav.php - About 1 hr to fix

      Method getLink has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getLink()
    {
        // take care of redirect
        if ($this->getType() === 3 && !empty($this->redirectMapData('value'))) {
            // generate convert object to determine correctn usage.
      Severity: Minor
      Found in src/menu/Item.php - About 1 hr to fix

        Method testActionCleanup has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function testActionCleanup()
    {
        PageScope::run($this->app, function (PageScope $scope) {
            $scope->createCmsNavFixture([]);
            $scope->createCmsNavItemFixture([]);
        Severity: Minor
        Found in tests/src/frontend/commands/PageControllerTest.php - About 1 hr to fix

          Function buildList has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              private function buildList(QueryIteratorFilter $iterator, $i = 1)
    {
        // Abort if maxDepth is set & reached
        if ($this->maxDepth !== null && $i >= ($this->maxDepth + 1)) {
            return "";
          Severity: Minor
          Found in src/widgets/NavTree.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method renderToolbar has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function renderToolbar($event)
    {
        Yii::info('LUYA CMS Toolbar rendering start', __METHOD__);

        $props = [];
          Severity: Minor
          Found in src/frontend/base/Controller.php - About 1 hr to fix

            Method testRegisterJsAssets has 39 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function testRegisterJsAssets()
    {
        // Simulate already registered js
        Yii::$app->view->js = [
            View::POS_READY => [
            Severity: Minor
            Found in tests/src/base/PhpBlockViewTest.php - About 1 hr to fix

              Method testParseRequest has 38 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function testParseRequest()
    {
        PageScope::run($this->app, function (PageScope $scope) {
            $this->createAdminGroupFixture(1);
            $this->createAdminUserFixture();
              Severity: Minor
              Found in tests/src/frontend/components/WebsiteBehaviorUrlRuleTest.php - About 1 hr to fix

                Method createModule has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function createModule($parentNavId, $navContainerId, $langId, $title, $alias, $moduleName, $description, $controllerName, $actionName, array $actionParams): array|int
    {
        $_errors = [];

        $nav = $this;
                Severity: Minor
                Found in src/models/Nav.php - About 1 hr to fix

                  Method bootstrap has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function bootstrap($app)
    {
        if ($app->hasModule('cms')) {
            // load cms url rules
            $app->on(Application::EVENT_BEFORE_REQUEST, function ($event) {
                  Severity: Minor
                  Found in src/frontend/Bootstrap.php - About 1 hr to fix

                    Method actionCreatePageVersion has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function actionCreatePageVersion()
    {
        $fromPageModel = null;
        $name = Yii::$app->request->post('name');
        $fromPageId = (int) Yii::$app->request->post('fromPageId');
                    Severity: Minor
                    Found in src/admin/apis/NavItemController.php - About 1 hr to fix

                      Method run has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function run()
    {
        $currentLang = Yii::$app->composition['langShortCode'];

        $rule = Yii::$app->menu->currentUrlRule;
                      Severity: Minor
                      Found in src/widgets/LangSwitcher.php - About 1 hr to fix

                        Method testActionDeepPageCopyAsTemplateSuccess has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function testActionDeepPageCopyAsTemplateSuccess()
    {
        // success
        PermissionScope::run($this->app, function (PermissionScope $scope) {
            $this->createAdminLangFixture();
                        Severity: Minor
                        Found in tests/src/admin/apis/NavControllerTest.php - About 1 hr to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                          while ($doVars) {
                    $item = $this->varCreator('Variabel (vars) #'.$i, 'var');
                    $this->phpdoc[] = '{{vars.'.$item['var'].'}}';
                    $this->viewFileDoc[] = '$this->varValue(\''.$item['var'].'\');';
                    $this->config['vars'][] = $item;
                          Severity: Major
                          Found in src/frontend/commands/BlockController.php and 1 other location - About 1 hr to fix
                          src/frontend/commands/BlockController.php on lines 380..387

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 109.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                          while ($doCfgs) {
                    $item = $this->varCreator('Configration (cfgs) #'.$i, 'cfg');
                    $this->phpdoc[] = '{{cfgs.'.$item['var'].'}}';
                    $this->viewFileDoc[] = '$this->cfgValue(\''.$item['var'].'\');';
                    $this->config['cfgs'][] = $item;
                          Severity: Major
                          Found in src/frontend/commands/BlockController.php and 1 other location - About 1 hr to fix
                          src/frontend/commands/BlockController.php on lines 370..377

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 109.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Function actionCleanup has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function actionCleanup()
    {
        $delete = [];
        $this->output("Blocks to delete:");
        foreach (Block::find()->all() as $block) {
                          Severity: Minor
                          Found in src/frontend/commands/BlockController.php - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function ensureInputValues has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                          Open

                              protected function ensureInputValues($event)
    {
        // sort index fixture

        if (!$this->isNewRecord) {
                          Severity: Minor
                          Found in src/models/NavItemPageBlockItem.php - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function fileArrayUpload has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public static function fileArrayUpload(array|string|null|int $value, $returnObject = false)
    {
        if (!empty($value) && is_array($value)) {
            $data = [];
            foreach ($value as $key => $item) {
                          Severity: Minor
                          Found in src/helpers/BlockHelper.php - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method testUpdateThemeConfig has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function testUpdateThemeConfig()
    {
        Yii::setAlias('@app', Yii::getAlias('@cmstests/tests/data'));
        $this->fixture->rebuild();
                          Severity: Minor
                          Found in tests/src/admin/importers/ThemeImporterTest.php - About 1 hr to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                            <?php

namespace luya\cms\base;

/**
                            Severity: Major
                            Found in src/base/BlockCfg.php and 1 other location - About 1 hr to fix
                            src/base/BlockVar.php on lines 1..26

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 108.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Severity
                            Category
                            Status
                            Source
                            Language