Sign upLogin

madbob/GASdottoNG

View on GitHub
Star

Showing 494 of 494 total issues

Similar blocks of code found in 7 locations. Consider refactoring.
Open

        Schema::create('delivery_gas', function (Blueprint $table) {
            $table->increments('id');
            $table->timestamps();

            $table->string('gas_id');
Severity: Major
Found in code/database/migrations/2015_11_21_011731_create_deliveries_table.php and 6 other locations - About 1 hr to fix
code/database/migrations/2015_11_21_011212_create_suppliers_table.php on lines 32..41
code/database/migrations/2015_11_21_011212_create_suppliers_table.php on lines 43..52
code/database/migrations/2015_11_21_011221_create_orders_table.php on lines 46..55
code/database/migrations/2015_11_21_011731_create_deliveries_table.php on lines 33..42
code/database/migrations/2018_01_27_204523_create_invoices_table.php on lines 27..36
code/database/migrations/2018_05_04_164033_create_receipts_table.php on lines 19..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 111.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

        Schema::create('booking_receipt', function (Blueprint $table) {
            $table->increments('id');
            $table->timestamps();

            $table->string('receipt_id');
Severity: Major
Found in code/database/migrations/2018_05_04_164033_create_receipts_table.php and 6 other locations - About 1 hr to fix
code/database/migrations/2015_11_21_011212_create_suppliers_table.php on lines 32..41
code/database/migrations/2015_11_21_011212_create_suppliers_table.php on lines 43..52
code/database/migrations/2015_11_21_011221_create_orders_table.php on lines 46..55
code/database/migrations/2015_11_21_011731_create_deliveries_table.php on lines 19..28
code/database/migrations/2015_11_21_011731_create_deliveries_table.php on lines 33..42
code/database/migrations/2018_01_27_204523_create_invoices_table.php on lines 27..36

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 111.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

        Schema::create('order_user', function (Blueprint $table) {
            $table->increments('id');
            $table->timestamps();

            $table->string('order_id');
Severity: Major
Found in code/database/migrations/2015_11_21_011221_create_orders_table.php and 6 other locations - About 1 hr to fix
code/database/migrations/2015_11_21_011212_create_suppliers_table.php on lines 32..41
code/database/migrations/2015_11_21_011212_create_suppliers_table.php on lines 43..52
code/database/migrations/2015_11_21_011731_create_deliveries_table.php on lines 19..28
code/database/migrations/2015_11_21_011731_create_deliveries_table.php on lines 33..42
code/database/migrations/2018_01_27_204523_create_invoices_table.php on lines 27..36
code/database/migrations/2018_05_04_164033_create_receipts_table.php on lines 19..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 111.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

        Schema::create('invoice_order', function (Blueprint $table) {
            $table->increments('id');
            $table->timestamps();

            $table->string('invoice_id');
Severity: Major
Found in code/database/migrations/2018_01_27_204523_create_invoices_table.php and 6 other locations - About 1 hr to fix
code/database/migrations/2015_11_21_011212_create_suppliers_table.php on lines 32..41
code/database/migrations/2015_11_21_011212_create_suppliers_table.php on lines 43..52
code/database/migrations/2015_11_21_011221_create_orders_table.php on lines 46..55
code/database/migrations/2015_11_21_011731_create_deliveries_table.php on lines 19..28
code/database/migrations/2015_11_21_011731_create_deliveries_table.php on lines 33..42
code/database/migrations/2018_05_04_164033_create_receipts_table.php on lines 19..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 111.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method commons has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function commons($user)
    {
        $ret = [];

        if ($user->can('users.admin', $user->gas)) {
Severity: Minor
Found in code/app/View/Icons/User.php - About 1 hr to fix

    Method getProductsWithFriendsAttribute has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getProductsWithFriendsAttribute()
    {
        return $this->innerCache('friends_products', function($obj) {
            /*
                Qui devo fare una copia di $this->products anziché usarlo
    Severity: Minor
    Found in code/app/Booking.php - About 1 hr to fix

      Method updateAccessType has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function updateAccessType($id, $request)
    {
        $user = Auth::user();
        if (is_null($user)) {
            throw new AuthException(401);
      Severity: Minor
      Found in code/app/Services/UsersService.php - About 1 hr to fix

        Method update has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function update($id, array $request)
    {
        $type = $this->updateAccessType($id, $request);
        if (is_object($type)) {
            return $type;
        Severity: Minor
        Found in code/app/Services/UsersService.php - About 1 hr to fix

          Method columnsByFeatures has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private static function columnsByFeatures($ret)
    {
        $current_gas = currentAbsoluteGas();

        if ($current_gas->hasFeature('shipping_places')) {
          Severity: Minor
          Found in code/app/Formatters/User.php - About 1 hr to fix

            Method handle has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function handle(VariantChanged $event)
    {
        $product = $event->variant->product;

        /*
            Severity: Minor
            Found in code/app/Listeners/ReviewProductVariantCombos.php - About 1 hr to fix

              Function testAccess has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function testAccess($modifier)
    {
        switch($modifier->target_type) {
            case 'App\Supplier':
                $this->ensureAuth(['supplier.modify' => $modifier->target]);
              Severity: Minor
              Found in code/app/Services/ModifiersService.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function postGdxp has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function postGdxp(Request $request)
    {
        // try {
            $archivepath = '';
            $working_dir = sys_get_temp_dir();
              Severity: Minor
              Found in code/app/Http/Controllers/ImportController.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function iconsLegendTrigger has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  static iconsLegendTrigger(node, legend_class)
    {
        /*
            Se clicco l'intestazione di un dropdown, passo oltre. Qui interviene
            il JS di Bootstrap per aprire e chiudere il dropdown stesso
              Severity: Minor
              Found in code/resources/assets/js/filters.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function handle has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function handle()
    {
        $hub = app()->make('GlobalScopeHub');
        $gas = $hub->getGasObj();
              Severity: Minor
              Found in code/app/Jobs/NotifyRemindOrder.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function postFixes has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function postFixes(Request $request, $id)
    {
        DB::beginTransaction();

        $order = $this->service->show($id, true);
              Severity: Minor
              Found in code/app/Http/Controllers/OrdersController.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function handle has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function handle()
    {
        $suppliers = Supplier::whereNotNull('remote_lastimport')->get();

        if ($suppliers->isEmpty() == false) {
              Severity: Minor
              Found in code/app/Console/Commands/CheckRemoteProducts.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function printableDate has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

              function printableDate($value, $short = false)
{
    if (is_null($value) || empty($value)) {
        return _i('Mai');
    }
              Severity: Minor
              Found in code/app/Helpers/Dates.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function handle has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function handle(VariantChanged $event)
    {
        $product = $event->variant->product;

        /*
              Severity: Minor
              Found in code/app/Listeners/ReviewProductVariantCombos.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function testApplication has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function testApplication($obj, $cache_type)
    {
        $this->appliesCache();

        $class = get_class($obj);
              Severity: Minor
              Found in code/app/Role.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function guessReplyTo has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function guessReplyTo($message, $from)
    {
        try {
            $reply = null;
              Severity: Minor
              Found in code/app/Notifications/Concerns/MailReplyTo.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language