Sign upLogin

madbob/GASdottoNG

View on GitHub
Star

Showing 494 of 494 total issues

Method allPermissions has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function allPermissions()
{
    $ret = [
        'App\Gas' => [
            'gas.access' => _i('Accesso consentito anche in manutenzione'),
Severity: Minor
Found in code/app/Helpers/Permissions.php - About 1 hr to fix

    Method computeStrings has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function computeStrings()
    {
        $names = [];
        $dates = [];
    Severity: Minor
    Found in code/app/Aggregate.php - About 1 hr to fix

      Method importJSON has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function importJSON($master, $json, $replace)
    {
        if (is_null($replace)) {
            $supplier = new Supplier();
            $supplier->payment_method = '';
      Severity: Minor
      Found in code/app/Importers/GDXP/Suppliers.php - About 1 hr to fix

        Function miscInnerCallbacks has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

        function miscInnerCallbacks(form, data) {
    if (locker == true) {
        return false;
    }
        Severity: Minor
        Found in code/resources/assets/js/gasdotto.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function postStatusSendinblue has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            public function postStatusSendinblue(Request $request)
    {
        if (env('MAIL_MAILER') == 'sendinblue') {
            /*
                Nota bene: qui arrivano tutte le segnalazioni webhook generate
        Severity: Minor
        Found in code/app/Http/Controllers/MailController.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function movementTypes has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

        function movementTypes($identifier = null, $with_trashed = false)
{
    static $types = null;

    if ($identifier == 'VOID') {
        Severity: Minor
        Found in code/app/Helpers/Accounting.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function readDefinition has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            private static function readDefinition($modifier, $json)
    {
        $definitions = [];

        if (isset($json->fixed)) {
        Severity: Minor
        Found in code/app/Importers/GDXP/Transformations.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function roleInit has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            private function roleInit($gas)
    {
        $queue = systemParameters('Roles');

        while(true) {
        Severity: Minor
        Found in code/database/seeders/DatabaseSeeder.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function formatShipping has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            public function formatShipping($order, $fields, $status, $shipping_place, $extra_modifiers)
    {
        $ret = (object) [
            'headers' => $fields->headers,
            'contents' => [],
        Severity: Minor
        Found in code/app/Printers/Concerns/Shipping.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            if ($index == 2) {
                        $mod = new Modifier();
                        $mod->modifier_type_id = 'sconto';
                        $mod->target_type = Product::class;
                        $mod->target_id = $prod->id;
        Severity: Major
        Found in code/database/seeders/DemoSeeder.php and 1 other location - About 1 hr to fix
        code/database/seeders/DemoSeeder.php on lines 176..188

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 112.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            if ($index == 0) {
                        $mod = new Modifier();
                        $mod->modifier_type_id = 'sconto';
                        $mod->target_type = Product::class;
                        $mod->target_id = $prod->id;
        Severity: Major
        Found in code/database/seeders/DemoSeeder.php and 1 other location - About 1 hr to fix
        code/database/seeders/DemoSeeder.php on lines 190..202

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 112.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function initDatesWidgets has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            static initDatesWidgets(container)
    {
        $('input.date', container).datepicker({
            format: 'DD dd MM yyyy',
            autoclose: true,
        Severity: Minor
        Found in code/resources/assets/js/widgets.js - About 1 hr to fix

          Method updateContacts has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function updateContacts($request)
    {
        $ids = [];
        $types = [];
        $values = [];
          Severity: Minor
          Found in code/app/Models/Concerns/ContactableTrait.php - About 1 hr to fix

            Method formatProduct has 39 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function formatProduct($fields, $formattable, $product_redux, $product, $internal_offsets)
    {
        $ret = [];

        if (is_null($product_redux) == false) {
            Severity: Minor
            Found in code/app/Printers/Concerns/Orders.php - About 1 hr to fix

              Method getDates has 38 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function getDates()
    {
        $dates = Date::where('type', 'order')->get();
        $today = date('Y-m-d');
        $aggregable = [];
              Severity: Minor
              Found in code/app/Console/Commands/OpenOrders.php - About 1 hr to fix

                Method getSummary has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private function getSummary($start, $end, $type, $target)
    {
        if ($type == 'all') {
            $data = $this->basicSummaryForAll($start, $end, $target);
        }
                Severity: Minor
                Found in code/app/Http/Controllers/StatisticsController.php - About 1 hr to fix

                  Method handleSummary has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      protected function handleSummary($obj, $request)
    {
        $subtype = $request['format'] ?? 'pdf';

        if ($subtype == 'gdxp') {
                  Severity: Minor
                  Found in code/app/Printers/Aggregate.php - About 1 hr to fix

                    Similar blocks of code found in 7 locations. Consider refactoring.
                    Open

                            Schema::create('gas_supplier', function (Blueprint $table) {
            $table->increments('id');
            $table->timestamps();

            $table->string('gas_id');
                    Severity: Major
                    Found in code/database/migrations/2015_11_21_011212_create_suppliers_table.php and 6 other locations - About 1 hr to fix
                    code/database/migrations/2015_11_21_011212_create_suppliers_table.php on lines 32..41
                    code/database/migrations/2015_11_21_011221_create_orders_table.php on lines 46..55
                    code/database/migrations/2015_11_21_011731_create_deliveries_table.php on lines 19..28
                    code/database/migrations/2015_11_21_011731_create_deliveries_table.php on lines 33..42
                    code/database/migrations/2018_01_27_204523_create_invoices_table.php on lines 27..36
                    code/database/migrations/2018_05_04_164033_create_receipts_table.php on lines 19..28

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 111.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 7 locations. Consider refactoring.
                    Open

                            Schema::create('delivery_order', function (Blueprint $table) {
            $table->increments('id');
            $table->timestamps();

            $table->string('delivery_id');
                    Severity: Major
                    Found in code/database/migrations/2015_11_21_011731_create_deliveries_table.php and 6 other locations - About 1 hr to fix
                    code/database/migrations/2015_11_21_011212_create_suppliers_table.php on lines 32..41
                    code/database/migrations/2015_11_21_011212_create_suppliers_table.php on lines 43..52
                    code/database/migrations/2015_11_21_011221_create_orders_table.php on lines 46..55
                    code/database/migrations/2015_11_21_011731_create_deliveries_table.php on lines 19..28
                    code/database/migrations/2018_01_27_204523_create_invoices_table.php on lines 27..36
                    code/database/migrations/2018_05_04_164033_create_receipts_table.php on lines 19..28

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 111.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 7 locations. Consider refactoring.
                    Open

                            Schema::create('supplier_user', function (Blueprint $table) {
            $table->increments('id');
            $table->timestamps();

            $table->string('user_id');
                    Severity: Major
                    Found in code/database/migrations/2015_11_21_011212_create_suppliers_table.php and 6 other locations - About 1 hr to fix
                    code/database/migrations/2015_11_21_011212_create_suppliers_table.php on lines 43..52
                    code/database/migrations/2015_11_21_011221_create_orders_table.php on lines 46..55
                    code/database/migrations/2015_11_21_011731_create_deliveries_table.php on lines 19..28
                    code/database/migrations/2015_11_21_011731_create_deliveries_table.php on lines 33..42
                    code/database/migrations/2018_01_27_204523_create_invoices_table.php on lines 27..36
                    code/database/migrations/2018_05_04_164033_create_receipts_table.php on lines 19..28

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 111.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language