Sign upLogin

madbob/GASdottoNG

View on GitHub
Star

Showing 494 of 494 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        $type->function = json_encode($this->voidFunctions([
            (object) [
                'method' => 'cash',
                'sender' => $this->format(['bank' => 'decrement']),
                'master' => $this->format(['cash' => 'decrement']),
Severity: Major
Found in code/app/Parameters/MovementType/UserDecredit.php and 2 other locations - About 2 hrs to fix
code/app/Parameters/MovementType/BookingPayment.php on lines 25..37
code/app/Parameters/MovementType/OrderPayment.php on lines 22..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 121.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public static function get($locale)
    {
        $ret = null;

        switch($locale) {
Severity: Major
Found in code/app/View/Texts/Days.php and 1 other location - About 2 hrs to fix
code/app/View/Texts/Months.php on lines 115..146

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 121.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public static function get($locale)
    {
        $ret = null;

        switch($locale) {
Severity: Major
Found in code/app/View/Texts/Months.php and 1 other location - About 2 hrs to fix
code/app/View/Texts/Days.php on lines 85..116

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 121.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method displayColumns has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function displayColumns()
    {
        $ret = [];

        $gas = currentAbsoluteGas();
Severity: Minor
Found in code/app/Product.php - About 1 hr to fix

    Function init has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        static init(container)
    {
        $('.triggers-all-checkbox', container).change(function() {
            $(this).prop('disabled', true);
    Severity: Minor
    Found in code/resources/assets/js/triggers.js - About 1 hr to fix

      Method formatShipping has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function formatShipping($order, $fields, $status, $shipping_place, $extra_modifiers)
    {
        $ret = (object) [
            'headers' => $fields->headers,
            'contents' => [],
      Severity: Minor
      Found in code/app/Printers/Concerns/Shipping.php - About 1 hr to fix

        Method update has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function update($id, array $request)
    {
        $modifier = $this->show($id);
        $this->testAccess($modifier);
        Severity: Minor
        Found in code/app/Services/ModifiersService.php - About 1 hr to fix

          Method output_csv has 48 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function output_csv($filename, $head, $contents, $format_callback, $out_file = null)
{
    $callback = function() use ($head, $contents, $format_callback, $out_file) {
        $csv_separator = currentAbsoluteGas()->getConfig('csv_separator');
          Severity: Minor
          Found in code/app/Helpers/Formatters.php - About 1 hr to fix

            Function updateContacts has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

                public function updateContacts($request)
    {
        $ids = [];
        $types = [];
        $values = [];
            Severity: Minor
            Found in code/app/Models/Concerns/ContactableTrait.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function initOnce has 47 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                static initOnce()
    {
        $('body').on('click', '.order-summary .toggle-product-abilitation', function() {
            $('.order-summary tr.product-disabled').toggle();
        })
            Severity: Minor
            Found in code/resources/assets/js/orders.js - About 1 hr to fix

              Function bookingTotal has 47 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  static bookingTotal(editor) {
        var form = $(editor).closest('form');
        var data = this.serializeBooking(form);
        var url = form.attr('data-dynamic-url');
              Severity: Minor
              Found in code/resources/assets/js/bookings.js - About 1 hr to fix

                Method serializeTransformations has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    function serializeTransformations($target, $json_target)
    {
        $transformations = [];
        $modifiers = $target->modifiers->filter(fn($m) => $m->active && in_array($m->modifierType->identifier, ['shipping', 'discount']));
                Severity: Minor
                Found in code/resources/views/gdxp/json/supplier.blade.php - About 1 hr to fix

                  Method handle has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function handle()
    {
        $this->doAlways();

        /*
                  Severity: Minor
                  Found in code/app/Console/Commands/FixDatabase.php - About 1 hr to fix

                    Method importJSON has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public static function importJSON($supplier, $json, $replace)
    {
        if (is_null($replace)) {
            $product = new Product();
        }
                    Severity: Minor
                    Found in code/app/Importers/GDXP/Products.php - About 1 hr to fix

                      Method fields has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function fields()
    {
        return [
            'name' => (object) [
                'label' => _i('Nome'),
                      Severity: Minor
                      Found in code/app/Importers/CSV/Products.php - About 1 hr to fix

                        Method update has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function update($id, array $request)
    {
        if ($id == 0) {
            $user = $this->ensureAuth(['supplier.orders' => null]);
            $suppliers = array_keys($user->targetsByAction('supplier.orders'));
                        Severity: Minor
                        Found in code/app/Services/DatesService.php - About 1 hr to fix

                          Method handle has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function handle()
    {
        $printer = new OrderPrinter();
        $notifiable_users = [];
        $all_files = [];
                          Severity: Minor
                          Found in code/app/Jobs/NotifyClosedOrder.php - About 1 hr to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                        if ($('#stats-summary-form', container).length != 0) {
                this.runSummaryStats();

                $('#stats-summary-form').submit((event) => {
                    event.preventDefault();
                            Severity: Major
                            Found in code/resources/assets/js/statistics.js and 1 other location - About 1 hr to fix
                            code/resources/assets/js/statistics.js on lines 17..24

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 71.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                        if ($('#stats-supplier-form', container).length != 0) {
                this.runSupplierStats();

                $('#stats-supplier-form').submit((event) => {
                    event.preventDefault();
                            Severity: Major
                            Found in code/resources/assets/js/statistics.js and 1 other location - About 1 hr to fix
                            code/resources/assets/js/statistics.js on lines 8..15

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 71.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Method handlingAttributes has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                private function handlingAttributes($booking, $modifier, $attribute)
    {
        /*
            Se l'ordine è chiuso (ma non consegnato e archiviato) attingo dai
            valori relativi, che includono sia il consegnato che il prenotato ma
                            Severity: Minor
                            Found in code/app/Singletons/ModifierEngine.php - About 1 hr to fix
                              Severity
                              Category
                              Status
                              Source
                              Language