Showing 9,653 of 9,653 total issues
Function loop
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
loop: function() {
var distance = this.to - this.pos,
factor = 1;
Function rescale
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
rescale: function(event) {
// calculate
var width = Math.min( $(window).width(), lightbox.width ),
height = Math.min( $(window).height(), lightbox.height ),
Function add
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
add: function(elem, to, from, hide) {
if ( !elem || Galleria.TOUCH ) {
return;
}
if (!idle.bound) {
Function loadTheme
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
Galleria.loadTheme = function( src, options ) {
var loaded = false,
length = _galleries.length;
Method admin_footer
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function admin_footer()
{
global $pagenow;
// Only run in post/page creation and edit screens
Function magnificPopup
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
$.fn.magnificPopup = function(options) {
_checkInstance();
var jqEl = $(this);
Method _resize
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function _resize($new_x, $new_y, $options = null)
{
// there's no technical reason why resize can't be called multiple
// times...it's just silly to do so
$scaleMethod = $this->_getOption('scaleMethod', $options, 'smooth');
Method image_type_to_mime_type
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
function image_type_to_mime_type($type)
{
switch ($type) {
case IMAGETYPE_GIF:
return 'image/gif';
Method rebuild
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function rebuild()
{
$data = $this->getTreeWithChildren();
$n = 0; // need a variable to hold the running n tally
Identical blocks of code found in 2 locations. Consider refactoring. Open
public function _generateTreeData(&$arr, $id, $level, &$n)
{
$arr[$id]['nlevel'] = $level;
$arr[$id]['nleft'] = ++$n;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 105.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
public function _generateTreeData(&$arr, $id, $level, &$n)
{
$arr[$id]['nlevel'] = $level;
$arr[$id]['nleft'] = ++$n;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 105.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function bindControls
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
bindControls: function() {
var i;
carousel.next.on( 'click:fast', function(e) {
Function rescale
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
rescale: function(event) {
// calculate
var width = M.min( $win.width()-40, lightbox.width ),
height = M.min( $win.height()-60, lightbox.height ),
Function bindControls
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
bindControls: function() {
var i;
carousel.next.on( 'click:fast', function(e) {
Function rescale
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
rescale: function(event) {
// calculate
var width = M.min( $win.width()-40, lightbox.width ),
height = M.min( $win.height()-60, lightbox.height ),
Function historyLoad
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
historyLoad: function(hash){
var newhash;
hash = decodeURIComponent(hash.replace(/\?.*$/, ''));
if (jQuery.browser.safari) {
Function scaleButtons
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
function scaleButtons( $btns, $capt, timeout )
{
if ( _viewScale )
{
var scale = _viewScale.getScale();
Method loadTableFromArrayWithReplace
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
function loadTableFromArrayWithReplace($table, $data, $search, $replace)
{
/** @var \XoopsMySQLDatabase $db */
$db = \XoopsDatabaseFactory::getDatabaseConnection();
Method resize_image
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function resize_image($orig_size, $dest_size, $dest_file_name)
{
// load image
$image = wp_get_image_editor($this->path);
Method updateBlock
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
function updateBlock($bid, $btitle, $bside, $bweight, $bvisible, $bcachetime, $bmodule, $options, $groups)
{
$myblock = new \XoopsBlock($bid);
$myblock->setVar('title', $btitle);
$myblock->setVar('weight', $bweight);