mambax7/extgallery

View on GitHub

Showing 9,653 of 9,653 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        while (false !== ($cat = $db->fetchArray($result))) {
            $grouppermHandler->addRight('public_displayed', $cat['cat_id'], XOOPS_GROUP_ADMIN, $moduleId);
            $grouppermHandler->addRight('public_displayed', $cat['cat_id'], XOOPS_GROUP_USERS, $moduleId);
            $grouppermHandler->addRight('public_displayed', $cat['cat_id'], XOOPS_GROUP_ANONYMOUS, $moduleId);
        }
Severity: Minor
Found in include/onupdate.php and 1 other location - About 45 mins to fix
include/update_function.php on lines 71..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 96.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        while (false !== ($cat = $db->fetchArray($result))) {
            $grouppermHandler->addRight('public_displayed', $cat['cat_id'], XOOPS_GROUP_ADMIN, $module_id);
            $grouppermHandler->addRight('public_displayed', $cat['cat_id'], XOOPS_GROUP_USERS, $module_id);
            $grouppermHandler->addRight('public_displayed', $cat['cat_id'], XOOPS_GROUP_ANONYMOUS, $module_id);
        }
Severity: Minor
Found in include/update_function.php and 1 other location - About 45 mins to fix
include/onupdate.php on lines 113..117

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 96.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid deeply nested control flow statements.
Open

                                        if ( type == 'image' && !current.big ) {
                                            current.big = current.image;
                                        }
Severity: Major
Found in assets/js/galleria/galleria-1.3.5.js - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                                            if ( type == 'image' && !current.big ) {
                                                current.big = current.image;
                                            }
    Severity: Major
    Found in assets/js/galleria/galleria-1.3.3.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              for ( var fn in timers[label] ) {
                                  window.clearInterval(timers[label][fn]);
                                  delete timers[label][fn];
                              }
      Severity: Major
      Found in assets/js/galleryview/timers.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if(el.is('img')) {
                                    el.attr('src', value);
                                } else {
                                    el.replaceWith( '<img src="'+value+'" class="' + el.attr('class') + '" />' );
                                }
        Severity: Major
        Found in assets/js/magnific_popup/jquery.magnific-popup.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              if (cachedHash != undefined) {
                                  jQuery.historyCurrentHash = location.hash.replace(/\?.*$/, '');
                                  jQuery.historyCallback(cachedHash);
                              }
          Severity: Major
          Found in assets/js/galleriffic/jquery.history.js - About 45 mins to fix

            Function easeOutBack has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                easeOutBack: function (x, t, b, c, d, s) {
            Severity: Minor
            Found in assets/js/galleryview/easing.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  if (historyDelta < 0) { // back button has been pushed
                                      // move items to forward stack
                                      for (var i = 0; i < Math.abs(historyDelta); i++) jQuery.historyForwardStack.unshift(jQuery.historyBackStack.pop());
                                  } else { // forward button has been pushed
                                      // move items to back stack
              Severity: Major
              Found in assets/js/galleriffic/jquery.history.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                        if ( fn.timerID ) {
                                            window.clearInterval(timers[label][fn.timerID]);
                                            delete timers[label][fn.timerID];
                                        }
                Severity: Major
                Found in assets/js/galleryview/timers.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                  } else if (jQuery.historyBackStack[jQuery.historyBackStack.length - 1] == undefined && !jQuery.isFirst) {
                                      // back button has been pushed to beginning and URL already pointed to hash (e.g. a bookmark)
                                      // document.URL doesn't change in Safari
                                      if (location.hash) {
                                          var current_hash = location.hash;
                  Severity: Major
                  Found in assets/js/galleriffic/jquery.history.js - About 45 mins to fix

                    Function easeInOutBack has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        easeInOutBack: function (x, t, b, c, d, s) {
                    Severity: Minor
                    Found in assets/js/galleryview/easing.js - About 45 mins to fix

                      Function custom_media_upload_tab_name has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function custom_media_upload_tab_name($tabs)
                          {
                              $metaslider_tabs = ['post_feed', 'layer', 'youtube', 'vimeo'];
                      
                              // restrict our tab changes to the meta slider plugin page
                      Severity: Minor
                      Found in assets/js/ml-slider/ml-slider.php - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function easeInBack has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          easeInBack: function (x, t, b, c, d, s) {
                      Severity: Minor
                      Found in assets/js/galleryview/easing.js - About 45 mins to fix

                        Function historyInit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                        Open

                            historyInit: function(callback, src){
                                jQuery.historyCallback = callback;
                                if (src) jQuery.historyIframeSrc = src;
                                var current_hash = location.hash.replace(/\?.*$/, '');
                        
                        
                        Severity: Minor
                        Found in assets/js/galleriffic/jquery.history.js - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Avoid deeply nested control flow statements.
                        Open

                                                    if(!opts.fade_panels) {
                                                        j_panels.hide().eq(i%item_count).show();
                                                    }
                        Severity: Major
                        Found in assets/js/galleryview/galleryview.js - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                                      if(!opts.fade_panels) {
                                                          j_panels.hide().eq(i%item_count).show();
                                                      }
                          Severity: Major
                          Found in assets/js/galleryview/galleryview.js - About 45 mins to fix

                            Method _parseLongOption has 6 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                protected static function _parseLongOption($arg, $long_options, &$opts, &$argIdx, $args, $skip_unknown)
                            Severity: Minor
                            Found in class/pear/Console/Getopt.php - About 45 mins to fix

                              Method PclTarHandleAddFile has 6 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  function PclTarHandleAddFile($p_tar, $p_filename, $p_mode, &$p_header, $p_add_dir, $p_remove_dir)
                              Severity: Minor
                              Found in class/pcltar.lib.php - About 45 mins to fix

                                Method PclTarHandleExtractByIndexList has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                        $p_tarname,
                                        $p_index_string,
                                        &$p_list_detail,
                                        $p_path,
                                        $p_remove_path,
                                Severity: Minor
                                Found in class/pcltar.lib.php - About 45 mins to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language