Sign upLogin

meifamily/ptt-alertor

View on GitHub
Star
command/command.go

Summary

Maintainability
D
1 day
Test Coverage

File command.go has 557 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package command

import (
    "bytes"
    "errors"
Severity: Minor
Found in command/command.go - About 3 hrs to fix

    Function HandleCommand has 101 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func HandleCommand(text string, userID string, isUser bool) string {
    command := strings.ToLower(strings.Fields(strings.TrimSpace(text))[0])
    if isUser {
        log.WithFields(log.Fields{
            "account": userID,
    Severity: Major
    Found in command/command.go - About 3 hrs to fix

      Function handleCommandLine has 80 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func handleCommandLine(userID, command, text string) string {
    var keywordStr, authorStr, push, boo string
    cl := flag.NewFlagSet("Ptt Alertor: <add|del> <-flag <argument>> <board> [board...]\nexample: add -k ptt -a chodino -p 10 ezsoft", flag.ContinueOnError)
    bf := new(bytes.Buffer)
    cl.SetOutput(bf)
      Severity: Major
      Found in command/command.go - About 2 hrs to fix

        Function HandleCommand has 14 return statements (exceeds 4 allowed).
        Open

        func HandleCommand(text string, userID string, isUser bool) string {
    command := strings.ToLower(strings.Fields(strings.TrimSpace(text))[0])
    if isUser {
        log.WithFields(log.Fields{
            "account": userID,
        Severity: Major
        Found in command/command.go - About 1 hr to fix

          Function handleCommandLine has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
          Open

          func handleCommandLine(userID, command, text string) string {
    var keywordStr, authorStr, push, boo string
    cl := flag.NewFlagSet("Ptt Alertor: <add|del> <-flag <argument>> <board> [board...]\nexample: add -k ptt -a chodino -p 10 ezsoft", flag.ContinueOnError)
    bf := new(bytes.Buffer)
    cl.SetOutput(bf)
          Severity: Minor
          Found in command/command.go - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function handlePushSum has 5 return statements (exceeds 4 allowed).
          Open

          func handlePushSum(command, account, board, sumStr string) (string, error) {
    if sum, err := strconv.Atoi(sumStr); err != nil || sum < 0 || sum > 100 {
        return "", errors.New("推噓文數需為介於 0-100 的數字")
    }
    boardNames := splitParamString(board)
          Severity: Major
          Found in command/command.go - About 35 mins to fix

            Function handleCommandLine has 5 return statements (exceeds 4 allowed).
            Open

            func handleCommandLine(userID, command, text string) string {
    var keywordStr, authorStr, push, boo string
    cl := flag.NewFlagSet("Ptt Alertor: <add|del> <-flag <argument>> <board> [board...]\nexample: add -k ptt -a chodino -p 10 ezsoft", flag.ContinueOnError)
    bf := new(bytes.Buffer)
    cl.SetOutput(bf)
            Severity: Major
            Found in command/command.go - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  case "新增推文數", "新增噓文數":
        re := regexp.MustCompile("^(新增推文數|新增噓文數)\\s+([^,，][\\w-_,，\\.]*[^,，:\\s]):?\\s+(100|[1-9][0-9]|[0-9])$")
        matched := re.MatchString(text)
        if !matched {
            errorTips := inputErrorTips
              Severity: Major
              Found in command/command.go and 1 other location - About 1 hr to fix
              command/command.go on lines 113..131

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 139.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  case "新增作者", "刪除作者":
        re := regexp.MustCompile("^(新增作者|刪除作者)\\s+([^,，][\\w-_,，\\.]*[^,，:\\s]):?\\s+(\\*|[\\s,\\w]+)$")
        matched := re.MatchString(text)
        if !matched {
            errorTips := inputErrorTips
              Severity: Major
              Found in command/command.go and 1 other location - About 1 hr to fix
              command/command.go on lines 132..150

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 139.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status