microting/eform-sdk-dotnet

View on GitHub

Showing 3,205 of 3,221 total issues

Method BuildTargetModel has 1544 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        protected override void BuildTargetModel(ModelBuilder modelBuilder)
        {
#pragma warning disable 612, 618
            string autoIDGenStrategy = "SqlServer:ValueGenerationStrategy";
            object autoIDGenStrategyValue = MySqlValueGenerationStrategy.IdentityColumn;

    Method BuildTargetModel has 1543 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            protected override void BuildTargetModel(ModelBuilder modelBuilder)
            {
    #pragma warning disable 612, 618
                string autoIDGenStrategy = "SqlServer:ValueGenerationStrategy";
                object autoIDGenStrategyValue = MySqlValueGenerationStrategy.IdentityColumn;
    Severity: Major
    Found in eFormCore/Migrations/20190923100451_ChangeStringToInt.Designer.cs - About 1 wk to fix

      Method Down has 1518 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              protected override void Down(MigrationBuilder migrationBuilder)
              {
                  migrationBuilder.DropForeignKey(
                      name: "FK_FolderTranslations_Folders_FolderId",
                      table: "FolderTranslations");

        Method BuildTargetModel has 1516 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                protected override void BuildTargetModel(ModelBuilder modelBuilder)
                {
        #pragma warning disable 612, 618
                    string autoIDGenStrategy = "SqlServer:ValueGenerationStrategy";
                    object autoIDGenStrategyValue = MySqlValueGenerationStrategy.IdentityColumn;

          Method BuildTargetModel has 1511 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  protected override void BuildTargetModel(ModelBuilder modelBuilder)
                  {
          #pragma warning disable 612, 618
                      string autoIDGenStrategy = "SqlServer:ValueGenerationStrategy";
                      object autoIDGenStrategyValue = SqlServerValueGenerationStrategy.IdentityColumn;
          Severity: Major
          Found in eFormCore/Migrations/20190806093044_AddingSiteGroups.Designer.cs - About 1 wk to fix

            File 20201220194822_FixingTableColumnNames.Designer.cs has 2657 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            using System;
            using Microsoft.EntityFrameworkCore;
            using Microsoft.EntityFrameworkCore.Infrastructure;
            using Microsoft.EntityFrameworkCore.Migrations;
            using Microting.eForm.Infrastructure;

              File 20201220201427_FixingQuestionSet.Designer.cs has 2655 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              using System;
              using Microsoft.EntityFrameworkCore;
              using Microsoft.EntityFrameworkCore.Infrastructure;
              using Microsoft.EntityFrameworkCore.Migrations;
              using Microting.eForm.Infrastructure;
              Severity: Major
              Found in eFormCore/Migrations/20201220201427_FixingQuestionSet.Designer.cs - About 1 wk to fix

                File 20201130204234_FixingSplitScreen.Designer.cs has 2655 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                using System;
                using Microsoft.EntityFrameworkCore;
                using Microsoft.EntityFrameworkCore.Infrastructure;
                using Microsoft.EntityFrameworkCore.Migrations;
                using Microting.eForm.Infrastructure;
                Severity: Major
                Found in eFormCore/Migrations/20201130204234_FixingSplitScreen.Designer.cs - About 1 wk to fix

                  File 20201222125152_HugheTableRenaming.Designer.cs has 2655 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  using System;
                  using Microsoft.EntityFrameworkCore;
                  using Microsoft.EntityFrameworkCore.Infrastructure;
                  using Microsoft.EntityFrameworkCore.Migrations;
                  using Microting.eForm.Infrastructure;
                  Severity: Major
                  Found in eFormCore/Migrations/20201222125152_HugheTableRenaming.Designer.cs - About 1 wk to fix

                    File 20201116164405_AddingDescriptionToEntityGroup.Designer.cs has 2655 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    using System;
                    using Microsoft.EntityFrameworkCore;
                    using Microsoft.EntityFrameworkCore.Infrastructure;
                    using Microsoft.EntityFrameworkCore.Migrations;
                    using Microting.eForm.Infrastructure;

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              [Test]
                              public async Task SQL_Template_TemplateFieldReadAll_ReturnsFieldList()
                              {
                                  // Arrance
                      
                      
                      eFormSDK.Integration.CheckLists.CoreTests/CoreTestAdvanced.cs on lines 335..583

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 3533.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              [Test]
                              public async Task Core_AdvancedTemplate_Advanced_TemplateFieldReadAll_returnslistofids()
                              {
                                  #region Templates
                      
                      
                      eFormSDK.Integration.Case.SqlControllerTests/SqlControllerTestCaseReadAllShort.cs on lines 690..940

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 3533.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Method BuildTargetModel has 1429 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              protected override void BuildTargetModel(ModelBuilder modelBuilder)
                              {
                      #pragma warning disable 612, 618
                                  string autoIDGenStrategy = "SqlServer:ValueGenerationStrategy";
                                  object autoIDGenStrategyValue = MySqlValueGenerationStrategy.IdentityColumn;

                        Method BuildTargetModel has 1425 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                protected override void BuildTargetModel(ModelBuilder modelBuilder)
                                {
                        #pragma warning disable 612, 618
                                    string autoIDGenStrategy = "SqlServer:ValueGenerationStrategy";
                                    object autoIDGenStrategyValue = MySqlValueGenerationStrategy.IdentityColumn;

                          Method BuildTargetModel has 1425 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                  protected override void BuildTargetModel(ModelBuilder modelBuilder)
                                  {
                          #pragma warning disable 612, 618
                                      string autoIDGenStrategy = "SqlServer:ValueGenerationStrategy";
                                      object autoIDGenStrategyValue = MySqlValueGenerationStrategy.IdentityColumn;

                            Method BuildTargetModel has 1424 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                    protected override void BuildTargetModel(ModelBuilder modelBuilder)
                                    {
                            #pragma warning disable 612, 618
                                        string autoIDGenStrategy = "SqlServer:ValueGenerationStrategy";
                                        object autoIDGenStrategyValue = MySqlValueGenerationStrategy.IdentityColumn;
                            Severity: Major
                            Found in eFormCore/Migrations/20190509074123_RefactoringidtoId.Designer.cs - About 1 wk to fix

                              Method BuildTargetModel has 1424 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                      protected override void BuildTargetModel(ModelBuilder modelBuilder)
                                      {
                              #pragma warning disable 612, 618
                                          string autoIDGenStrategy = "SqlServer:ValueGenerationStrategy";
                                          object autoIDGenStrategyValue = MySqlValueGenerationStrategy.IdentityColumn;

                                File SqlControllerTestEntity.cs has 2460 lines of code (exceeds 250 allowed). Consider refactoring.
                                Open

                                using System;
                                using System.Collections.Generic;
                                using System.Linq;
                                using System.Threading.Tasks;
                                using Microting.eForm;

                                  Method DownloadUploadedData has a Cognitive Complexity of 346 (exceeds 20 allowed). Consider refactoring.
                                  Open

                                          public async Task<bool> DownloadUploadedData(int uploadedDataId)
                                          {
                                              string methodName = "Core.DownloadUploadedData";
                                              Microting.eForm.Infrastructure.Data.Entities.UploadedData uploadedData =
                                                  await _sqlController.GetUploadedData(uploadedDataId).ConfigureAwait(false);
                                  Severity: Minor
                                  Found in eFormCore/Core.cs - About 6 days to fix

                                  Cognitive Complexity

                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                  A method's cognitive complexity is based on a few simple rules:

                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                  • Code is considered more complex for each "break in the linear flow of the code"
                                  • Code is considered more complex when "flow breaking structures are nested"

                                  Further reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                          [Test]
                                          public async Task SQL_EntityGroup_EntityGroupUpdate_UpdatesEntityGroup()
                                          {
                                              // Arrance
                                  
                                  
                                  eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestEntity.cs on lines 3639..4109

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 2741.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language