Showing 2,526 of 2,542 total issues
Method SQL_EntityGroup_EntityGroupAll_ReturnsEntityGroupsPaged
has 918 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public async Task SQL_EntityGroup_EntityGroupAll_ReturnsEntityGroupsPaged()
{
// Arrance
File CoreTestEntity.cs
has 1682 lines of code (exceeds 250 allowed). Consider refactoring. Open
using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Reflection;
File 20200120093951_CleanupInSight.Designer.cs
has 1645 lines of code (exceeds 250 allowed). Consider refactoring. Open
using System;
using Microsoft.EntityFrameworkCore;
using Microsoft.EntityFrameworkCore.Infrastructure;
using Microsoft.EntityFrameworkCore.Metadata;
using Microsoft.EntityFrameworkCore.Migrations;
File 20200116074236_AddingSiteTaggins.Designer.cs
has 1631 lines of code (exceeds 250 allowed). Consider refactoring. Open
using System;
using Microsoft.EntityFrameworkCore;
using Microsoft.EntityFrameworkCore.Infrastructure;
using Microsoft.EntityFrameworkCore.Metadata;
using Microsoft.EntityFrameworkCore.Migrations;
Similar blocks of code found in 2 locations. Consider refactoring. Open
[Test]
public async Task SQL_SiteWorker_SiteWorkerDelete_DeletesSiteWorker()
{
// Arrance
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 2117.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
[Test]
public async Task SQL_Worker_WorkerDelete_DeletesWorker()
{
// Arrance
#region Arrance
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 2117.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
File 20190924172326_AddingNewIndexOnCases.Designer.cs
has 1577 lines of code (exceeds 250 allowed). Consider refactoring. Open
using System;
using Microsoft.EntityFrameworkCore;
using Microsoft.EntityFrameworkCore.Infrastructure;
using Microsoft.EntityFrameworkCore.Metadata;
using Microsoft.EntityFrameworkCore.Migrations;
File 20190923100451_ChangeStringToInt.Designer.cs
has 1576 lines of code (exceeds 250 allowed). Consider refactoring. Open
using System;
using Microsoft.EntityFrameworkCore;
using Microsoft.EntityFrameworkCore.Infrastructure;
using Microsoft.EntityFrameworkCore.Metadata;
using Microsoft.EntityFrameworkCore.Migrations;
Method FieldValueReadAllValues
has a Cognitive Complexity of 221 (exceeds 20 allowed). Consider refactoring. Open
public async Task<List<List<KeyValuePair>>> FieldValueReadAllValues(int fieldId, List<int> caseIds,
string customPathForUploadedData, string decimalSeparator, string thousandSeparator, Language language,
bool gpsCoordinates)
{
string methodName = "SqlController.FieldValueReadAllValues";
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File 20190828054730_AddingNewVersionClasses.Designer.cs
has 1549 lines of code (exceeds 250 allowed). Consider refactoring. Open
using System;
using Microsoft.EntityFrameworkCore;
using Microsoft.EntityFrameworkCore.Infrastructure;
using Microsoft.EntityFrameworkCore.Metadata;
using Microsoft.EntityFrameworkCore.Migrations;
File 20190806093044_AddingSiteGroups.Designer.cs
has 1528 lines of code (exceeds 250 allowed). Consider refactoring. Open
using System;
using Microsoft.EntityFrameworkCore;
using Microsoft.EntityFrameworkCore.Infrastructure;
using Microsoft.EntityFrameworkCore.Metadata;
using Microsoft.EntityFrameworkCore.Migrations;
Method CreateDataItem
has 810 lines of code (exceeds 25 allowed). Consider refactoring. Open
private async Task CreateDataItem(int? parentFieldId, int elementId, DataItem dataItem, Language language)
{
string methodName = "SqlController.CreateDataItem";
try
{
File 20190711053344_AddingJasperDocxEnabledAttributesToCheckList.Designer.cs
has 1462 lines of code (exceeds 250 allowed). Consider refactoring. Open
using System;
using Microsoft.EntityFrameworkCore;
using Microsoft.EntityFrameworkCore.Infrastructure;
using Microsoft.EntityFrameworkCore.Metadata;
using Microsoft.EntityFrameworkCore.Migrations;
File 20190531092007_AddingMissingAIonLogs.Designer.cs
has 1458 lines of code (exceeds 250 allowed). Consider refactoring. Open
using System;
using Microsoft.EntityFrameworkCore;
using Microsoft.EntityFrameworkCore.Infrastructure;
using Microsoft.EntityFrameworkCore.Metadata;
using Microsoft.EntityFrameworkCore.Migrations;
File 20190515064952_FixingNamingForFieldValues.Designer.cs
has 1458 lines of code (exceeds 250 allowed). Consider refactoring. Open
using System;
using Microsoft.EntityFrameworkCore;
using Microsoft.EntityFrameworkCore.Infrastructure;
using Microsoft.EntityFrameworkCore.Metadata;
using Microsoft.EntityFrameworkCore.Migrations;
File 20190514053645_RefactoringAttributeNames.Designer.cs
has 1457 lines of code (exceeds 250 allowed). Consider refactoring. Open
using System;
using Microsoft.EntityFrameworkCore;
using Microsoft.EntityFrameworkCore.Infrastructure;
using Microsoft.EntityFrameworkCore.Metadata;
using Microsoft.EntityFrameworkCore.Migrations;
File 20190408084408_AddingMissingParentId.Designer.cs
has 1457 lines of code (exceeds 250 allowed). Consider refactoring. Open
using System;
using Microsoft.EntityFrameworkCore;
using Microsoft.EntityFrameworkCore.Infrastructure;
using Microsoft.EntityFrameworkCore.Metadata;
using Microsoft.EntityFrameworkCore.Migrations;
File 20190509074123_RefactoringidtoId.Designer.cs
has 1457 lines of code (exceeds 250 allowed). Consider refactoring. Open
using System;
using Microsoft.EntityFrameworkCore;
using Microsoft.EntityFrameworkCore.Infrastructure;
using Microsoft.EntityFrameworkCore.Metadata;
using Microsoft.EntityFrameworkCore.Migrations;
File 20190408081151_AddingFolders.Designer.cs
has 1455 lines of code (exceeds 250 allowed). Consider refactoring. Open
using System;
using Microsoft.EntityFrameworkCore;
using Microsoft.EntityFrameworkCore.Infrastructure;
using Microsoft.EntityFrameworkCore.Metadata;
using Microsoft.EntityFrameworkCore.Migrations;
File 20190319130214_AddingMissingForeignKeys.Designer.cs
has 1414 lines of code (exceeds 250 allowed). Consider refactoring. Open
using System;
using Microsoft.EntityFrameworkCore;
using Microsoft.EntityFrameworkCore.Infrastructure;
using Microsoft.EntityFrameworkCore.Metadata;
using Microsoft.EntityFrameworkCore.Migrations;