Sign upLogin

mtrevisan/HunLinter

View on GitHub
Star

Showing 338 of 403 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    @SuppressWarnings("ConstantConditions")
    public DictionarySorterAction(final ParserManager parserManager, final WorkerManager workerManager,
            final PropertyChangeListener propertyChangeListener){
        super("dictionary.sorter", new ImageIcon(DictionarySorterAction.class.getResource("/dictionary_sort.png")));
Severity: Major
Found in src/main/java/io/github/mtrevisan/hunlinter/actions/DictionarySorterAction.java and 1 other location - About 1 hr to fix
src/main/java/io/github/mtrevisan/hunlinter/actions/SelectFontAction.java on lines 66..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 86.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method variantsCheck has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    private void variantsCheck(final Inflection inflection){
        String derivedWord = inflection.getWord().toLowerCase(Locale.ROOT);
        for(int i = 0; i < WORD_SEPARATORS.length(); i ++)
            derivedWord = StringUtils.remove(derivedWord, WORD_SEPARATORS.charAt(i));
Severity: Minor
Found in src/main/java/io/github/mtrevisan/hunlinter/languages/vec/DictionaryCorrectnessCheckerVEC.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method mergeDistributions has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    protected static Map<String, List<DictionaryEntry>> mergeDistributions(final Map<String, List<DictionaryEntry>> compoundRules,
            final Map<String, List<DictionaryEntry>> distribution, final Integer compoundMinimumLength, final String forbiddenWordFlag){
        final List<Map.Entry<String, List<DictionaryEntry>>> list = new ArrayList<>(compoundRules.entrySet());
        list.addAll(distribution.entrySet());
Severity: Minor
Found in src/main/java/io/github/mtrevisan/hunlinter/parsers/dictionary/generators/WordGeneratorCompound.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method markDefaultStress has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public static String markDefaultStress(final String word){
        if("–".equals(word))
            return word;

        char delimiter = ' ';
Severity: Minor
Found in src/main/java/io/github/mtrevisan/hunlinter/languages/vec/WordVEC.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method traceback has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    private Trace traceback(int lastIndexA, int lastIndexB){
        final Trace trace = new Trace();
        trace.lastIndexA = lastIndexA - 1;
        trace.lastIndexB = lastIndexB - 1;
        trace.operations = new LinkedList<>();
Severity: Minor
Found in src/main/java/io/github/mtrevisan/hunlinter/services/text/SmithWatermanAlignment.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method register has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public final void register(final FileChangeListener listener, final String... patterns){
        Objects.requireNonNull(listener, "Listener cannot be null");

        if(watcher != null){
Severity: Minor
Found in src/main/java/io/github/mtrevisan/hunlinter/services/filelistener/FileListenerManager.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private double deletion(final int i, final int j){
        int highest = 0;
        for(int k = 1; k < i; k ++)
            if(scores[k][j] > scores[highest][j])
                highest = k;
Severity: Major
Found in src/main/java/io/github/mtrevisan/hunlinter/services/text/SmithWatermanAlignment.java and 1 other location - About 1 hr to fix
src/main/java/io/github/mtrevisan/hunlinter/services/text/SmithWatermanAlignment.java on lines 150..156

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 85.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private double insertion(final int i, final int j){
        int highest = 0;
        for(int k = 1; k < j; k ++)
            if(scores[i][k] > scores[i][highest])
                highest = k;
Severity: Major
Found in src/main/java/io/github/mtrevisan/hunlinter/services/text/SmithWatermanAlignment.java and 1 other location - About 1 hr to fix
src/main/java/io/github/mtrevisan/hunlinter/services/text/SmithWatermanAlignment.java on lines 158..164

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 85.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        return (serialized[arc]) << 24
            | (serialized[arc + 1] & 0xFF) << 16
            | (serialized[arc + 2] & 0xFF) << 8
            | (serialized[arc + 3] & 0xFF);
Severity: Major
Found in src/main/java/io/github/mtrevisan/hunlinter/datastructures/fsa/builders/FSABuilder.java and 1 other location - About 1 hr to fix
src/main/java/io/github/mtrevisan/hunlinter/datastructures/fsa/builders/ConstantArcSizeFSA.java on lines 107..110

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 76.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        return (data[arc]) << 24
            | (data[arc + 1] & 0xFF) << 16
            | (data[arc + 2] & 0xFF) << 8
            | (data[arc + 3] & 0xFF);
Severity: Major
Found in src/main/java/io/github/mtrevisan/hunlinter/datastructures/fsa/builders/ConstantArcSizeFSA.java and 1 other location - About 1 hr to fix
src/main/java/io/github/mtrevisan/hunlinter/datastructures/fsa/builders/FSABuilder.java on lines 218..221

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 76.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method validateAugmentedRule has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private static void validateAugmentedRule(final CharSequence cleanedRule, final String rule){
        final int count = RegexHelper.clear(cleanedRule, PATTERN_HYPHENATION_POINT).length();
        if(count != 1)
            throw new LinterException(MORE_HYPHENATION_DOTS, rule);
Severity: Minor
Found in src/main/java/io/github/mtrevisan/hunlinter/parsers/hyphenation/HyphenationParser.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method convertEntriesToRules has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private List<String> convertEntriesToRules(final String flag, final AffixType type, final boolean keepLongestCommonAffix,
            final List<LineEntry> entries){
        List<LineEntry> sortedEntries = Collections.emptyList();
        if(!entries.isEmpty()){
            //restore original rules
Severity: Minor
Found in src/main/java/io/github/mtrevisan/hunlinter/parsers/dictionary/RulesReducer.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method encode has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public final byte[] encode(final byte[] source, final byte[] target){
        //FIXME
        //Search for the infix that can be encoded and remove from `source` to get a maximum-length prefix of `target`.
        //This could be done more efficiently by running a smarter longest-common-subsequence algorithm and some pruning (?).
Severity: Minor
Found in src/main/java/io/github/mtrevisan/hunlinter/datastructures/fsa/stemming/TrimInfixAndSuffixEncoder.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method advance has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private ByteBuffer advance(){
        if(arcLimit == 0)
            return null;

        while(arcLimit > 0){
Severity: Minor
Found in src/main/java/io/github/mtrevisan/hunlinter/datastructures/fsa/lookup/ByteSequenceIterator.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method compare has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

        @Override
        public int compare(final byte[] left, final byte[] right){
            final int stride = 8;
            final int minLength = Math.min(left.length, right.length);
            final int strideLimit = minLength & -stride;
Severity: Minor
Found in src/main/java/io/github/mtrevisan/hunlinter/datastructures/fsa/builders/LexicographicalComparator.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method readCharacters has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private static Set<String> readCharacters(final Scanner scanner, final int numEntries) throws EOFException{
        final Set<String> wordBreakCharacters = new HashSet<>(numEntries);
        for(int i = 0; i < numEntries; i ++){
            ParserHelper.assertNotEOF(scanner);
Severity: Minor
Found in src/main/java/io/github/mtrevisan/hunlinter/parsers/affix/handlers/WordBreakTableHandler.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method removeClosestRepresentatives has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private static void removeClosestRepresentatives(final List<String> population, int limitPopulation, final int minimumDistance){
        int index = 0;
        limitPopulation = Math.min(limitPopulation, population.size());
        while(index < limitPopulation){
            final String elem = population.get(index);
Severity: Minor
Found in src/main/java/io/github/mtrevisan/hunlinter/parsers/dictionary/DictionaryStatistics.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method processSentence has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private void processSentence(){
        if(wordTokenizer == null){
            final AffixData affixData = parserManager.getAffixData();
            wordTokenizer = BaseBuilder.getWordTokenizer(affixData.getLanguage());
            charset = affixData.getCharset();
Severity: Minor
Found in src/main/java/io/github/mtrevisan/hunlinter/gui/panes/PoSFSALayeredPane.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method grow has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private void grow(){
        IntBlock lastDataBlock = blocks[indexOfLastDataBlock];

        //if the last Block is full, we need to make a new Block
        if(lastDataBlock.isFull()){
Severity: Minor
Found in src/main/java/io/github/mtrevisan/hunlinter/datastructures/dynamicarray/DynamicIntArray.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method hyphenateAddRule has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private void hyphenateAddRule(){
        final String language = parserManager.getLanguage();
        final Orthography orthography = BaseBuilder.getOrthography(language);
        String addedRuleText = orthography.correctOrthography(wordTextField.getText());
        final String addedRule = orthography.correctOrthography(addRuleTextField.getText().toLowerCase(Locale.ROOT));
Severity: Minor
Found in src/main/java/io/github/mtrevisan/hunlinter/gui/panes/HyphenationLayeredPane.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language