Sign upLogin

nheyek/SDP-2018

View on GitHub
Star

Showing 124 of 124 total issues

Method setAndAddQuestion has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void setAndAddQuestion() throws Throwable {
        //Select Course
        onView(withId(R.id.choice_course_button)).perform(scrollTo()).perform(click());
        UiDevice uiDevice = UiDevice.getInstance(InstrumentationRegistry.getInstrumentation());
        UiObject button = uiDevice.findObject(new UiSelector().text(SWENG.toString()));
Severity: Minor
Found in app/src/androidTest/java/ch/epfl/sweng/studyup/QuestionsTest/AddQuestionActivityTest.java - About 1 hr to fix

    Method getView has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Override
    public View getView(final int position, View convertView, final ViewGroup parent) {
        if(convertView==null){
            convertView=View.inflate(act, idLayout, null);
        }
    Severity: Minor
    Found in app/src/main/java/ch/epfl/sweng/studyup/utils/adapters/ListCourseAdapter.java - About 1 hr to fix

      Method setupListViewP has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          protected void setupListViewP(final List<UserData> userList) {
        ListView listView = findViewById(R.id.listViewPlayer);

        ArrayList<Integer> rates = new ArrayList<>();
        ArrayList<Integer> nb_answer = new ArrayList<>();
      Severity: Minor
      Found in app/src/main/java/ch/epfl/sweng/studyup/teacher/DisplayCourseStatsActivity.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method setupListViewQ has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          protected void setupListViewQ(final List<String> questions_course) {
        ListView listView = findViewById(R.id.listViewQuestionForStats);

        ArrayList<Integer> rates = new ArrayList<>();
        ArrayList<Integer> nb_answer = new ArrayList<>();
      Severity: Minor
      Found in app/src/main/java/ch/epfl/sweng/studyup/teacher/DisplayCourseStatsActivity.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          public void scheduleBackgroundLocation(){
        JobScheduler scheduler = (JobScheduler) getSystemService(Context.JOB_SCHEDULER_SERVICE);
        JobInfo jobInfo = new JobInfo.Builder(BackgroundLocation.BACKGROUND_LOCATION_ID, new ComponentName(this, BackgroundLocation.class)).setPeriodic(15 * 60 * 1000).build();
        scheduler.schedule(jobInfo);
        for(JobInfo job: scheduler.getAllPendingJobs()){
      Severity: Major
      Found in app/src/main/java/ch/epfl/sweng/studyup/player/HomeActivity.java and 1 other location - About 1 hr to fix
      app/src/main/java/ch/epfl/sweng/studyup/utils/navigation/NavigationStudent.java on lines 55..63

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 93.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          public void scheduleBackgroundLocation(){
        JobScheduler scheduler = (JobScheduler) getSystemService(Context.JOB_SCHEDULER_SERVICE);
        JobInfo jobInfo = new JobInfo.Builder(BackgroundLocation.BACKGROUND_LOCATION_ID, new ComponentName(this, BackgroundLocation.class)).setPeriodic(15 * 60 * 1000).build();
        scheduler.schedule(jobInfo);
        for(JobInfo job: scheduler.getAllPendingJobs()){
      Severity: Major
      Found in app/src/main/java/ch/epfl/sweng/studyup/utils/navigation/NavigationStudent.java and 1 other location - About 1 hr to fix
      app/src/main/java/ch/epfl/sweng/studyup/player/HomeActivity.java on lines 190..198

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 93.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          private ViewAction clickXY(final int x, final int y){
        return new GeneralClickAction(
                Tap.SINGLE,
                new CoordinatesProvider() {
                    @Override
      Severity: Major
      Found in app/src/androidTest/java/ch/epfl/sweng/studyup/ScheduleTest/ScheduleActivityStudentTest.java and 1 other location - About 1 hr to fix
      app/src/androidTest/java/ch/epfl/sweng/studyup/ScheduleTest/ScheduleActivityTeacherTest.java on lines 172..190

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 91.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          private ViewAction clickXY(final int x, final int y) {
        return new GeneralClickAction(
                Tap.SINGLE,
                new CoordinatesProvider() {
                    @Override
      Severity: Major
      Found in app/src/androidTest/java/ch/epfl/sweng/studyup/ScheduleTest/ScheduleActivityTeacherTest.java and 1 other location - About 1 hr to fix
      app/src/androidTest/java/ch/epfl/sweng/studyup/ScheduleTest/ScheduleActivityStudentTest.java on lines 133..151

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 91.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method addPlayerToTeachingStaff has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public void addPlayerToTeachingStaff(final Course c, final String sciper) {
        final DocumentReference courseRef = db.collection(FB_COURSES).document(c.name());
        courseRef.get()
                .addOnCompleteListener(new OnCompleteListener<DocumentSnapshot>() {
                    @Override
      Severity: Minor
      Found in app/src/main/java/ch/epfl/sweng/studyup/firebase/Firestore.java - About 1 hr to fix

        Method consume has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public void consume() {

        switch (this) {
            case XP_POTION:
                Player.get().addExperience(XP_STEP, MOST_RECENT_ACTIVITY);
        Severity: Minor
        Found in app/src/main/java/ch/epfl/sweng/studyup/items/Items.java - About 1 hr to fix

          Method getView has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  @Override
        public View getView(final int position, View convertView, ViewGroup parent) {
            if (convertView == null) {
                convertView = View.inflate(cnx, idLayout, null);
            }
          Severity: Minor
          Found in app/src/main/java/ch/epfl/sweng/studyup/teacher/QuestsActivityTeacher.java - About 1 hr to fix

            Method updateRemotePlayerDataFromLocal has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public void updateRemotePlayerDataFromLocal() {

        Player currPlayer = Player.get();
        Map<String, Object> localPlayerData = new HashMap<>();
            Severity: Minor
            Found in app/src/main/java/ch/epfl/sweng/studyup/firebase/Firestore.java - About 1 hr to fix

              Method addRequest has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public void addRequest(final String course, final String sciper, final String firstname, final String lastname) {
        CourseRequest request = new CourseRequest(Course.valueOf(course), sciper, firstname, lastname);
        if(!requests.contains(request))
            requests.add(request);
        setupListViews();
              Severity: Minor
              Found in app/src/main/java/ch/epfl/sweng/studyup/teacher/ManageCourseActivity.java - About 1 hr to fix

                Method editTrueFalseQuestionAnswerImagedToTextBasedTest has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    @Test
    public void editTrueFalseQuestionAnswerImagedToTextBasedTest() throws Throwable {
        q = new Question(questionUUID, this.getClass().getName(), true, 0, Constants.Course.SWENG.name(), "en");
        mActivityRule.launchActivity(new Intent().putExtra(AddOrEditQuestionActivity.class.getSimpleName(), q));
                Severity: Minor
                Found in app/src/androidTest/java/ch/epfl/sweng/studyup/QuestionsTest/EditQuestionActivityTest.java - About 1 hr to fix

                  Method updateScheduleTest has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      @Test
    public void updateScheduleTest(){
        Player.get().setRole(Constants.Role.student);
        mActivityRule.launchActivity(new Intent());
        Utils.waitAndTag(1000, "ScheduleActivityStudentTest");
                  Severity: Minor
                  Found in app/src/androidTest/java/ch/epfl/sweng/studyup/ScheduleTest/ScheduleActivityStudentTest.java - About 1 hr to fix

                    Method updateScheduleTest has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        @Test
    public void updateScheduleTest() {
        mActivityRule.launchActivity(new Intent().putExtra(COURSE_NAME_INTENT_SCHEDULE, Constants.Course.FakeCourse.name()));
        waitAndTag(1000, "ScheduleActivityTeacherTest");
                    Severity: Minor
                    Found in app/src/androidTest/java/ch/epfl/sweng/studyup/ScheduleTest/ScheduleActivityTeacherTest.java - About 1 hr to fix

                      Method loadUsers has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public static void loadUsers(final Callback callback) {
        final List<UserData> userList = new ArrayList<>();

        Firestore.get().getDb().collection(FB_USERS).get().addOnCompleteListener(new OnCompleteListener<QuerySnapshot>() {
            @Override
                      Severity: Minor
                      Found in app/src/main/java/ch/epfl/sweng/studyup/utils/StatsUtils.java - About 1 hr to fix

                        Method loadInterface has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            private void loadInterface() {
        // User picture
        ImageButton pic_button = findViewById(R.id.pic_btn);
        pic_button2 = findViewById(R.id.pic_btn2);
        image_view = findViewById(R.id.pic_imageview);
                        Severity: Minor
                        Found in app/src/main/java/ch/epfl/sweng/studyup/player/HomeActivity.java - About 1 hr to fix

                          Method onCreate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                          Open

                              @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_add_edit_question);
        setupToolbar(this);
                          Severity: Minor
                          Found in app/src/main/java/ch/epfl/sweng/studyup/questions/AddOrEditQuestionActivity.java - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method updateLocalDataFromRemote has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              @SuppressWarnings("unchecked")
    public void updateLocalDataFromRemote(Map<String, Object> remotePlayerData) {

        if (remotePlayerData.isEmpty()) {
            Log.e(TAG,"Unable to retrieve player data from Firebase.");
                          Severity: Minor
                          Found in app/src/main/java/ch/epfl/sweng/studyup/player/Player.java - About 1 hr to fix
                            Severity
                            Category
                            Status
                            Source
                            Language