Sign upLogin

odin-detector/odin-data

View on GitHub
Star
python/src/odin_data/control/frame_receiver_adapter.py

Summary

Maintainability
D
1 day
Test Coverage

Function send_to_clients has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
Open

    def send_to_clients(self, request_command, parameters, client_index=-1):
        """
        Intercept the base class send_to_clients method.
        Keep a record of any decoder specific configuration items and then if a single decoder config
        item is later changed send the full decoder configuration to the Frame Receiver application.
Severity: Minor
Found in python/src/odin_data/control/frame_receiver_adapter.py - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        for item in decoder_config:
                            self._decoder_config[index][item] = decoder_config[item]
            else:
Severity: Major
Found in python/src/odin_data/control/frame_receiver_adapter.py - About 45 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    for index in range(len(self._decoder_config)):
                    if self._decoder_config[index] is None:
                        self._decoder_config[index] = decoder_config
                    else:
                        for item in decoder_config:
    Severity: Major
    Found in python/src/odin_data/control/frame_receiver_adapter.py and 1 other location - About 3 hrs to fix
    python/src/odin_data/control/frame_receiver_adapter.py on lines 66..78

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if client_index == -1:
                for index in range(len(self._decoder_config)):
                    if self._decoder_config[index] is None:
                        self._decoder_config[index] = decoder_config
                    else:
    Severity: Major
    Found in python/src/odin_data/control/frame_receiver_adapter.py and 1 other location - About 3 hrs to fix
    python/src/odin_data/control/frame_receiver_adapter.py on lines 67..72

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status