Sign upLogin

onijim/owl-table

View on GitHub
Star

Showing 76 of 76 total issues

Avoid deeply nested control flow statements.
Open

                        if(tmp_a === tmp_b) {
                            tmp_a = a.index;
                            tmp_b = b.index;

                            if(tmp_a === tmp_b) {
Severity: Major
Found in lib/swift-search.js - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                    if (value.length !== 0) {
                    return false;
                }
    Severity: Major
    Found in src/services/owlFilter.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if(new_indexes[j] !== selected_indexes[j]) {
                            changed = true;
                            break;
                        }
      Severity: Major
      Found in lib/swift-box.js - About 45 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    var ourRow = owlUtils.firstRowIfExists(
                _.filter(this.data, function (datum) {
                    /* jshint ignore:start */
                    return datum.id == rowId;
                    /* jshint ignore:end */
        Severity: Minor
        Found in src/services/owlTableService.js and 1 other location - About 40 mins to fix
        src/services/owlTableService.js on lines 379..385

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    var ourRow = owlUtils.firstRowIfExists(
                _.filter(this.data, function (datum) {
                    /* jshint ignore:start */
                    return datum.id == rowId;
                    /* jshint ignore:end */
        Severity: Minor
        Found in src/services/owlTableService.js and 1 other location - About 40 mins to fix
        src/services/owlTableService.js on lines 360..366

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            function removeFocusClass(element) {
        var container_element = getElementCache(element).container;

        $(element).removeClass('swift-box-focus');
        $(container_element).removeClass('swift-box-focus');
        Severity: Minor
        Found in lib/swift-box.js and 1 other location - About 40 mins to fix
        lib/swift-box.js on lines 2051..2056

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            function addFocusClass(element) {
        var container_element = getElementCache(element).container;

        $(element).addClass('swift-box-focus');
        $(container_element).addClass('swift-box-focus');
        Severity: Minor
        Found in lib/swift-box.js and 1 other location - About 40 mins to fix
        lib/swift-box.js on lines 2062..2067

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function filterCell has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                filterCell: function (row, column, termCache, i, filter) {
        Severity: Minor
        Found in src/services/owlFilter.js - About 35 mins to fix

          Avoid too many return statements within this function.
          Open

                              return false;
          Severity: Major
          Found in src/services/owlFilter.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                                return false;
            Severity: Major
            Found in src/services/owlFilter.js - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  function focus(element) {
        var container_element = getElementCache(element).container;

        if(container_element) {
            container_element.focus();
              Severity: Minor
              Found in lib/swift-box.js and 1 other location - About 30 mins to fix
              lib/swift-box.js on lines 2039..2045

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Avoid too many return statements within this function.
              Open

                          return true;
              Severity: Major
              Found in src/services/owlFilter.js - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    function blur(element) {
        var container_element = getElementCache(element).container;

        if(container_element) {
            container_element.blur();
                Severity: Minor
                Found in lib/swift-box.js and 1 other location - About 30 mins to fix
                lib/swift-box.js on lines 2027..2033

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Avoid too many return statements within this function.
                Open

                                    return false;
                Severity: Major
                Found in src/services/owlFilter.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                      return false;
                  Severity: Major
                  Found in src/services/owlFilter.js - About 30 mins to fix

                    Function tableDidChange has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        tableDidChange: function (event, row, column) {
        if (typeof this.state.changedData[row.id] === 'undefined') {
            this.state.changedData[row.id] = {};
        }
                    Severity: Minor
                    Found in react_components/table.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language