Showing 396 of 431 total issues
Avoid deeply nested control flow statements. Confirmed
if r.by_package
pkg = Package.find_by_project_and_name(r.by_project, r.by_package)
return true if pkg && user.can_modify?(pkg)
else
prj = Project.find_by_name(r.by_project)
Avoid deeply nested control flow statements. Confirmed
raise NotMissingError, "Branch call with missingok parameter but branched source (#{params[:project]}/#{params[:package]}) exists." if Package.exists_by_project_and_name(params[:project], params[:package],
allow_remote_packages: true)
Method check_everbuilt
has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring. Open
def check_everbuilt(srep, arch)
@everbuilt = false
@eversucceeded = false
@buildcode = nil
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid deeply nested control flow statements. Confirmed
if Package.exists_by_project_and_name(incident_project.name, source_package, follow_project_links: false)
new_pkg = Package.get_by_project_and_name(incident_project.name, source_package, use_source: false, follow_project_links: false)
else
new_pkg = Package.new(name: source_package, title: pkg.title, description: pkg.description)
incident_project.packages << new_pkg
Avoid deeply nested control flow statements. Confirmed
if action[:forward]
action[:forward].each do |forward|
if forward[:project] == lprj && forward[:package] == lpkg
link_is_already_devel = true
break
Avoid deeply nested control flow statements. Confirmed
p[:target_package] += ".#{p[:link_target_project].name}" if @extend_names
Avoid deeply nested control flow statements. Open
if prj.is_a?(Project) && prj.find_attribute('OBS', 'BranchTarget')
@copy_from_devel = true
elsif pkg
prj = pkg.project
tpkg_name ||= pkg.releasename
Avoid deeply nested control flow statements. Confirmed
package_hash[:link_target_project] = update_pkg_via_devel_project.project if !link_target_project_valid? && !@copy_from_devel
Avoid deeply nested control flow statements. Confirmed
ltprj = pkg2.project if ltprj.find_attribute('OBS', 'BranchTarget').nil?
Method update_patchinfo
has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring. Open
def update_patchinfo(project, patchinfo, opts = {})
project.check_write_access!
@patchinfo = patchinfo
opts[:enfore_issue_update] ||= false
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method package_existence_consistency_check
has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring. Open
def package_existence_consistency_check(project, fix = false)
begin
project.reload
rescue ActiveRecord::RecordNotFound
# project disappeared ... may happen in running system
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid deeply nested control flow statements. Confirmed
next if pkg2.nil? || @packages.pluck(:package).include?(pkg2) # avoid double instances
Method can_be_unlocked?
has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring. Open
def can_be_unlocked?(with_exception = true)
if is_maintenance_incident?
requests = BsRequest.where(state: %i[new review declined]).joins(:bs_request_actions)
maintenance_release_requests = requests.where(bs_request_actions: { type: 'maintenance_release', source_project: name })
if maintenance_release_requests.exists?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method clone_repository_from
has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring. Open
def clone_repository_from(source_repository)
source_repository.repository_architectures.each do |ra|
repository_architectures.create(architecture: ra.architecture, position: ra.position)
end
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid deeply nested control flow statements. Confirmed
elsif options[:methods] != :attrib_namespace_name
options[:methods] = [options[:methods]] + [:attrib_namespace_name]
Avoid deeply nested control flow statements. Confirmed
options[:methods] << :attrib_namespace_name unless options[:methods].include?(:attrib_namespace_name)
Method call
has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring. Open
def call(options)
set_triggered_at
@scm_webhook = options[:scm_webhook]
workflow_run = options[:workflow_run]
raise Token::Errors::MissingPayload, 'A payload is required' if @scm_webhook.payload.blank?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid deeply nested control flow statements. Confirmed
p[:target_package] = params[:target_package] if params[:target_package]
Method headers_for_actions
has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring. Open
def headers_for_actions
ret = {}
payload['actions'].each_with_index do |a, index|
suffix = if payload['actions'].length == 1 || index.zero?
'X-OBS-Request-Action'
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method check_action_permission_source!
has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring. Open
def check_action_permission_source!
return unless source_project
sprj = Project.get_by_name(source_project)
raise UnknownProject, "Unknown source project #{source_project}" unless sprj
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"