Sign upLogin

ozanh/ugo

View on GitHub
Star
objects.go

Summary

Maintainability
C
1 day
Test Coverage

File objects.go has 1249 lines of code (exceeds 500 allowed). Consider refactoring.
Wontfix

// Copyright (c) 2020-2023 Ozan Hacıbekiroğlu.
// Use of this source code is governed by a MIT License
// that can be found in the LICENSE file.

package ugo
Severity: Major
Found in objects.go - About 2 days to fix

    Method Bool.BinaryOp has 98 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (o Bool) BinaryOp(tok token.Token, right Object) (Object, error) {
    bval := Int(0)
    if o {
        bval = Int(1)
    }
    Severity: Major
    Found in objects.go - About 2 hrs to fix

      Method RuntimeError.Format has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
      Open

      func (o *RuntimeError) Format(s fmt.State, verb rune) {
    switch verb {
    case 'v', 's':
        switch {
        case s.Flag('+'):
      Severity: Minor
      Found in objects.go - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method Map.Equal has 5 return statements (exceeds 4 allowed).
      Open

      func (o Map) Equal(right Object) bool {
    v, ok := right.(Map)
    if !ok {
        return false
    }
      Severity: Major
      Found in objects.go - About 35 mins to fix

        Method Array.IndexGet has 5 return statements (exceeds 4 allowed).
        Open

        func (o Array) IndexGet(index Object) (Object, error) {
    switch v := index.(type) {
    case Int:
        idx := int(v)
        if idx >= 0 && idx < len(o) {
        Severity: Major
        Found in objects.go - About 35 mins to fix

          Method Bool.BinaryOp has 5 return statements (exceeds 4 allowed).
          Open

          func (o Bool) BinaryOp(tok token.Token, right Object) (Object, error) {
    bval := Int(0)
    if o {
        bval = Int(1)
    }
          Severity: Major
          Found in objects.go - About 35 mins to fix

            Method Array.IndexSet has 5 return statements (exceeds 4 allowed).
            Open

            func (o Array) IndexSet(index, value Object) error {
    switch v := index.(type) {
    case Int:
        idx := int(v)
        if idx >= 0 && idx < len(o) {
            Severity: Major
            Found in objects.go - About 35 mins to fix

              Method Array.BinaryOp has 5 return statements (exceeds 4 allowed).
              Wontfix

              func (o Array) BinaryOp(tok token.Token, right Object) (Object, error) {
    switch tok {
    case token.Add:
        if v, ok := right.(Array); ok {
            arr := make(Array, 0, len(o)+len(v))
              Severity: Major
              Found in objects.go - About 35 mins to fix

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                    case Int:
        switch tok {
        case token.Add:
            return bval + v, nil
        case token.Sub:
                Severity: Major
                Found in objects.go and 3 other locations - About 3 hrs to fix
                numeric.go on lines 79..114
                numeric.go on lines 225..260
                numeric.go on lines 491..526

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 280.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        switch v := o[k].(type) {
        case String:
            sb.WriteString(strconv.Quote(v.String()))
        case Char:
            sb.WriteString(strconv.QuoteRune(rune(v)))
                Severity: Minor
                Found in objects.go and 1 other location - About 50 mins to fix
                objects.go on lines 898..907

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 120.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        switch v := o[i].(type) {
        case String:
            sb.WriteString(strconv.Quote(v.String()))
        case Char:
            sb.WriteString(strconv.QuoteRune(rune(v)))
                Severity: Minor
                Found in objects.go and 1 other location - About 50 mins to fix
                objects.go on lines 1132..1141

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 120.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status