Sign upLogin

ozanh/ugo

View on GitHub
Star
vm.go

Summary

Maintainability
F
5 days
Test Coverage

File vm.go has 1457 lines of code (exceeds 500 allowed). Consider refactoring.
Wontfix

// Copyright (c) 2020-2023 Ozan Hacıbekiroğlu.
// Use of this source code is governed by a MIT License
// that can be found in the LICENSE file.

package ugo
Severity: Major
Found in vm.go - About 3 days to fix

    Method VM.loop has a Cognitive Complexity of 163 (exceeds 20 allowed). Consider refactoring.
    Confirmed

    func (vm *VM) loop() {
VMLoop:
    for atomic.LoadInt64(&vm.abort) == 0 {
        vm.ip++
        switch vm.curInsts[vm.ip] {
    Severity: Minor
    Found in vm.go - About 3 days to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method VM.loop has 485 lines of code (exceeds 50 allowed). Consider refactoring.
    Invalid

    func (vm *VM) loop() {
VMLoop:
    for atomic.LoadInt64(&vm.abort) == 0 {
        vm.ip++
        switch vm.curInsts[vm.ip] {
    Severity: Major
    Found in vm.go - About 2 days to fix

      VM has 36 methods (exceeds 20 allowed). Consider refactoring.
      Open

      type VM struct {
    abort        int64
    sp           int
    ip           int
    curInsts     []byte
      Severity: Minor
      Found in vm.go - About 4 hrs to fix

        Method VM.xOpCallCompiled has a Cognitive Complexity of 42 (exceeds 20 allowed). Consider refactoring.
        Confirmed

        func (vm *VM) xOpCallCompiled(cfunc *CompiledFunction, numArgs, flags int) error {
    basePointer := vm.sp - numArgs
    numLocals := cfunc.NumLocals
    numParams := cfunc.NumParams
        Severity: Minor
        Found in vm.go - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method VM.xOpCallCompiled has 96 lines of code (exceeds 50 allowed). Consider refactoring.
        Confirmed

        func (vm *VM) xOpCallCompiled(cfunc *CompiledFunction, numArgs, flags int) error {
    basePointer := vm.sp - numArgs
    numLocals := cfunc.NumLocals
    numParams := cfunc.NumParams
        Severity: Major
        Found in vm.go - About 2 hrs to fix

          Method VM.xOpUnary has 69 lines of code (exceeds 50 allowed). Consider refactoring.
          Confirmed

          func (vm *VM) xOpUnary() error {
    tok := token.Token(vm.curInsts[vm.ip+1])
    right := vm.stack[vm.sp-1]
    var value Object
          Severity: Minor
          Found in vm.go - About 1 hr to fix

            Method VM.xOpSliceIndex has 65 lines of code (exceeds 50 allowed). Consider refactoring.
            Confirmed

            func (vm *VM) xOpSliceIndex() error {
    obj := vm.stack[vm.sp-3]
    left := vm.stack[vm.sp-2]
    right := vm.stack[vm.sp-1]
    vm.stack[vm.sp-3] = nil
            Severity: Minor
            Found in vm.go - About 1 hr to fix

              Method VM.xOpUnary has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
              Confirmed

              func (vm *VM) xOpUnary() error {
    tok := token.Token(vm.curInsts[vm.ip+1])
    right := vm.stack[vm.sp-1]
    var value Object
              Severity: Minor
              Found in vm.go - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method VM.loop has 13 return statements (exceeds 4 allowed).
              Wontfix

              func (vm *VM) loop() {
VMLoop:
    for atomic.LoadInt64(&vm.abort) == 0 {
        vm.ip++
        switch vm.curInsts[vm.ip] {
              Severity: Major
              Found in vm.go - About 1 hr to fix

                Method VM.xOpCallCompiled has 8 return statements (exceeds 4 allowed).
                Wontfix

                func (vm *VM) xOpCallCompiled(cfunc *CompiledFunction, numArgs, flags int) error {
    basePointer := vm.sp - numArgs
    numLocals := cfunc.NumLocals
    numParams := cfunc.NumParams
                Severity: Major
                Found in vm.go - About 50 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                      if err = vm.throwGenErr(err); err != nil {
                        vm.err = err
                        return
                    }
                  Severity: Major
                  Found in vm.go - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                    for i := vm.sp; i >= handler.sp; i-- {
                    vm.stack[i] = nil
                }
                    Severity: Major
                    Found in vm.go - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                          switch err {
                    case ErrNotIndexable:
                        err = ErrNotIndexable.NewError(target.TypeName())
                    case ErrIndexOutOfBounds:
                        err = ErrIndexOutOfBounds.NewError(index.String())
                      Severity: Major
                      Found in vm.go - About 45 mins to fix

                        Method VM.xOpCallName has 5 return statements (exceeds 4 allowed).
                        Confirmed

                        func (vm *VM) xOpCallName() error {
    numArgs := int(vm.curInsts[vm.ip+1])
    flags := int(vm.curInsts[vm.ip+2]) // 0 or 1
    obj := vm.stack[vm.sp-numArgs-2]
    name := vm.stack[vm.sp-1]
                        Severity: Major
                        Found in vm.go - About 35 mins to fix

                          Method VM.xOpCallObject has 5 return statements (exceeds 4 allowed).
                          Confirmed

                          func (vm *VM) xOpCallObject(callee Object, numArgs, flags int) error {
    if !callee.CanCall() {
        return ErrNotCallable.NewError(callee.TypeName())
    }
                          Severity: Major
                          Found in vm.go - About 35 mins to fix

                            Method VM.init has 5 return statements (exceeds 4 allowed).
                            Confirmed

                            func (vm *VM) init(globals Object, args ...Object) (Object, error) {
    if vm.bytecode == nil || vm.bytecode.Main == nil {
        return nil, errors.New("invalid Bytecode")
    }
                            Severity: Major
                            Found in vm.go - About 35 mins to fix

                              TODO found
                              Open

                                  // TODO (ozan): check why setting numParams fails some tests!
                              Severity: Minor
                              Found in vm.go by fixme

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Wontfix

                              func wantGEqXGotY(x, y int) string {
    buf := make([]byte, 0, 20)
    buf = append(buf, "want>="...)
    buf = strconv.AppendInt(buf, int64(x), 10)
    buf = append(buf, " got="...)
                              Severity: Minor
                              Found in vm.go and 1 other location - About 30 mins to fix
                              vm.go on lines 1531..1538

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 101.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Wontfix

                              func wantEqXGotY(x, y int) string {
    buf := make([]byte, 0, 20)
    buf = append(buf, "want="...)
    buf = strconv.AppendInt(buf, int64(x), 10)
    buf = append(buf, " got="...)
                              Severity: Minor
                              Found in vm.go and 1 other location - About 30 mins to fix
                              vm.go on lines 1540..1547

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 101.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              There are no issues that match your filters.

                              Category
                              Status