petrsvihlik/WopiHost

View on GitHub

Showing 59 of 59 total issues

Similar blocks of code found in 9 locations. Consider refactoring.
Open

public int BusinessUser
{
get => Convert.ToInt32(this["BUSINESS_USER"], CultureInfo.InvariantCulture);
set => this["BUSINESS_USER"] = value.ToString(CultureInfo.InvariantCulture);
}
Severity: Major
Found in src/WopiHost.Url/WopiUrlSettings.cs and 8 other locations - About 30 mins to fix
src/WopiHost.Url/WopiUrlSettings.cs on lines 44..48
src/WopiHost.Url/WopiUrlSettings.cs on lines 53..57
src/WopiHost.Url/WopiUrlSettings.cs on lines 62..66
src/WopiHost.Url/WopiUrlSettings.cs on lines 71..75
src/WopiHost.Url/WopiUrlSettings.cs on lines 80..84
src/WopiHost.Url/WopiUrlSettings.cs on lines 89..93
src/WopiHost.Url/WopiUrlSettings.cs on lines 107..111
src/WopiHost.Url/WopiUrlSettings.cs on lines 117..121

Similar blocks of code found in 9 locations. Consider refactoring.
Open

public int Perfstats
{
get => Convert.ToInt32(this["PERFSTATS"], CultureInfo.InvariantCulture);
set => this["PERFSTATS"] = value.ToString(CultureInfo.InvariantCulture);
}
Severity: Major
Found in src/WopiHost.Url/WopiUrlSettings.cs and 8 other locations - About 30 mins to fix
src/WopiHost.Url/WopiUrlSettings.cs on lines 44..48
src/WopiHost.Url/WopiUrlSettings.cs on lines 53..57
src/WopiHost.Url/WopiUrlSettings.cs on lines 62..66
src/WopiHost.Url/WopiUrlSettings.cs on lines 71..75
src/WopiHost.Url/WopiUrlSettings.cs on lines 80..84
src/WopiHost.Url/WopiUrlSettings.cs on lines 89..93
src/WopiHost.Url/WopiUrlSettings.cs on lines 98..102
src/WopiHost.Url/WopiUrlSettings.cs on lines 107..111

Avoid too many return statements within this method.
Open

return new ConflictResult();
Severity: Major
Found in src/WopiHost.Core/Controllers/ContainersController.cs - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

    return new LockMismatchResult(Response, reason: "Missing new lock identifier");
    Severity: Major
    Found in src/WopiHost.Core/Controllers/FilesController.cs - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

      return new LockMismatchResult(Response, existingLock.LockId);
      Severity: Major
      Found in src/WopiHost.Core/Controllers/FilesController.cs - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

        return new LockMismatchResult(Response, reason: "File not locked");
        Severity: Major
        Found in src/WopiHost.Core/Controllers/FilesController.cs - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

          return new ConflictResult();
          Severity: Major
          Found in src/WopiHost.Core/Controllers/ContainersController.cs - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

            return new LockMismatchResult(Response, reason: "Missing existing lock");
            Severity: Major
            Found in src/WopiHost.Core/Controllers/FilesController.cs - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

              return new JsonResult(
              new CreateChildContainerResponse(
              new(jsonResult.Data.Name, Url.GetWopiUrl(WopiResourceType.Container, newIdentifier)),
              jsonResult.Data));
              Severity: Major
              Found in src/WopiHost.Core/Controllers/ContainersController.cs - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                return new LockMismatchResult(Response, reason: "File not locked");
                Severity: Major
                Found in src/WopiHost.Core/Controllers/FilesController.cs - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                  return NotFound();
                  Severity: Major
                  Found in src/WopiHost.Core/Controllers/ContainersController.cs - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                    return new ConflictResult();
                    Severity: Major
                    Found in src/WopiHost.Core/Controllers/ContainersController.cs - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                      return Ok();
                      Severity: Major
                      Found in src/WopiHost.Core/Controllers/FilesController.cs - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                        return new LockMismatchResult(Response, "Could not create lock");
                        Severity: Major
                        Found in src/WopiHost.Core/Controllers/FilesController.cs - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                          return StatusCode(StatusCodes.Status500InternalServerError);
                          Severity: Major
                          Found in src/WopiHost.Core/Controllers/ContainersController.cs - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                            return StatusCode(StatusCodes.Status500InternalServerError);
                            Severity: Major
                            Found in src/WopiHost.Core/Controllers/ContainersController.cs - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                              return new StatusCodeResult(StatusCodes.Status500InternalServerError);
                              Severity: Major
                              Found in src/WopiHost.Core/Controllers/ContainersController.cs - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                return new LockMismatchResult(Response, "Could not create lock");
                                Severity: Major
                                Found in src/WopiHost.Core/Controllers/FilesController.cs - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                  return AuthenticateResult.Fail(ex);
                                  Severity: Major
                                  Found in src/WopiHost.Core/Security/Authentication/AccessTokenHandler.cs - About 30 mins to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language