propelorm/Propel2

View on GitHub

Showing 754 of 754 total issues

Function applyLimit has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
Open

    public function applyLimit(&$sql, $offset, $limit)
    {
        // make sure offset and limit are numeric
        if (!is_numeric($offset) || !is_numeric($limit)) {
            throw new InvalidArgumentException('MssqlAdapter::applyLimit() expects a number for argument 2 and 3');
Severity: Minor
Found in src/Propel/Runtime/Adapter/Pdo/MssqlAdapter.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function isUnique has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
Open

    public function isUnique(array $keys)
    {
        if (1 === count($keys)) {
            $column = $keys[0] instanceof Column ? $keys[0] : $this->getColumn($keys[0]);
            if ($column) {
Severity: Minor
Found in src/Propel/Generator/Model/Table.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function execute has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
Open

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $configOptions = [];

        if ($this->hasInputOption('connection', $input)) {
Severity: Minor
Found in src/Propel/Generator/Command/MigrationDiffCommand.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

QueryBuilder has 53 functions (exceeds 20 allowed). Consider refactoring.
Open

class QueryBuilder extends AbstractOMBuilder
{
    /**
     * Returns the package for the [base] object classes.
     *
Severity: Major
Found in src/Propel/Generator/Builder/Om/QueryBuilder.php - About 7 hrs to fix

    AbstractOMBuilder has 50 functions (exceeds 20 allowed). Consider refactoring.
    Open

    abstract class AbstractOMBuilder extends DataModelBuilder
    {
        /**
         * Declared fully qualified classnames, to build the 'namespace' statements
         * according to this table's namespace.
    Severity: Minor
    Found in src/Propel/Generator/Builder/Om/AbstractOMBuilder.php - About 7 hrs to fix

      Function setupReferrers has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
      Open

          public function setupReferrers($throwErrors = false)
          {
              foreach ($this->foreignKeys as $foreignKey) {
      
                  // table referrers
      Severity: Minor
      Found in src/Propel/Generator/Model/Table.php - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      TableMap has 48 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class TableMap
      {
          /**
           * phpname type
           * e.g. 'AuthorId'
      Severity: Minor
      Found in src/Propel/Runtime/Map/TableMap.php - About 6 hrs to fix

        Function execute has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function execute(InputInterface $input, OutputInterface $output)
            {
                $configOptions = [];
        
                if ($this->hasInputOption('output-dir', $input)) {
        Severity: Minor
        Found in src/Propel/Generator/Command/MigrationUpCommand.php - About 6 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function execute has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function execute(InputInterface $input, OutputInterface $output)
            {
                $configOptions = [];
        
                if ($this->hasInputOption('output-dir', $input)) {
        Severity: Minor
        Found in src/Propel/Generator/Command/MigrationDownCommand.php - About 6 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File PgsqlSchemaParser.php has 439 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
        
        /**
         * This file is part of the Propel package.
         * For the full copyright and license information, please view the LICENSE
        Severity: Minor
        Found in src/Propel/Generator/Reverse/PgsqlSchemaParser.php - About 6 hrs to fix

          Join has 47 functions (exceeds 20 allowed). Consider refactoring.
          Open

          class Join
          {
              // default comparison type
              const EQUAL = '=';
              const INNER_JOIN = 'INNER JOIN';
          Severity: Minor
          Found in src/Propel/Runtime/ActiveQuery/Join.php - About 6 hrs to fix

            Function __toString has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
            Open

                public function __toString()
                {
                    $ret = '';
                    $ret .= sprintf("  %s:\n", $this->fromTable->getName());
                    if ($addedColumns = $this->getAddedColumns()) {
            Severity: Minor
            Found in src/Propel/Generator/Model/Diff/TableDiff.php - About 6 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            MysqlPlatform has 45 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class MysqlPlatform extends DefaultPlatform
            {
                protected $tableEngineKeyword = 'ENGINE';  // overwritten in propel config
                protected $defaultTableEngine = 'InnoDB';  // overwritten in propel config
            
            
            Severity: Minor
            Found in src/Propel/Generator/Platform/MysqlPlatform.php - About 6 hrs to fix

              Function getNextStatement has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getNextStatement()
                  {
                      $isAfterBackslash = false;
                      $isInString = false;
                      $stringQuotes = '';
              Severity: Minor
              Found in src/Propel/Generator/Util/SqlParser.php - About 6 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Collection has 44 functions (exceeds 20 allowed). Consider refactoring.
              Open

              class Collection implements \ArrayAccess, \IteratorAggregate, \Countable, \Serializable
              {
                  /**
                   * @var string
                   */
              Severity: Minor
              Found in src/Propel/Runtime/Collection/Collection.php - About 6 hrs to fix

                Method startElement has 150 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function startElement($parser, $name, $attributes)
                    {
                        $parentTag = $this->peekCurrentSchemaTag();
                        if (false === $parentTag) {
                            switch ($name) {
                Severity: Major
                Found in src/Propel/Generator/Builder/Util/SchemaReader.php - About 6 hrs to fix

                  Function compareTables has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function compareTables($caseInsensitive = false)
                      {
                          $fromDatabaseTables = $this->fromDatabase->getTables();
                          $toDatabaseTables = $this->toDatabase->getTables();
                          $databaseDifferences = 0;
                  Severity: Minor
                  Found in src/Propel/Generator/Model/Diff/DatabaseComparator.php - About 5 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      protected function addAddArrayElement(&$script, Column $col)
                      {
                          $clo = $col->getLowercasedName();
                          $cfc = $col->getPhpName();
                          $visibility = $col->getAccessorVisibility();
                  Severity: Major
                  Found in src/Propel/Generator/Builder/Om/ObjectBuilder.php and 1 other location - About 5 hrs to fix
                  src/Propel/Generator/Builder/Om/ObjectBuilder.php on lines 1972..2013

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 166.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      protected function addRemoveArrayElement(&$script, Column $col)
                      {
                          $clo = $col->getLowercasedName();
                          $cfc = $col->getPhpName();
                          $visibility = $col->getAccessorVisibility();
                  Severity: Major
                  Found in src/Propel/Generator/Builder/Om/ObjectBuilder.php and 1 other location - About 5 hrs to fix
                  src/Propel/Generator/Builder/Om/ObjectBuilder.php on lines 1927..1965

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 166.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method createSelectSql has 144 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function createSelectSql(&$params)
                      {
                          $adapter = Propel::getServiceContainer()->getAdapter($this->getDbName());
                          $dbMap = Propel::getServiceContainer()->getDatabaseMap($this->getDbName());
                  
                  
                  Severity: Major
                  Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 5 hrs to fix
                    Severity
                    Category
                    Status
                    Source
                    Language