propelorm/Propel2

View on GitHub

Showing 740 of 740 total issues

TableMap has 52 functions (exceeds 20 allowed). Consider refactoring.
Open

class TableMap
{
    /**
     * phpname type
     * e.g. 'AuthorId'
Severity: Major
Found in src/Propel/Runtime/Map/TableMap.php - About 7 hrs to fix

    AbstractOMBuilder has 51 functions (exceeds 20 allowed). Consider refactoring.
    Open

    abstract class AbstractOMBuilder extends DataModelBuilder
    {
        use PathTrait;
    
        /**
    Severity: Major
    Found in src/Propel/Generator/Builder/Om/AbstractOMBuilder.php - About 7 hrs to fix

      MysqlPlatform has 50 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class MysqlPlatform extends DefaultPlatform
      {
          /**
           * @var string
           */
      Severity: Minor
      Found in src/Propel/Generator/Platform/MysqlPlatform.php - About 7 hrs to fix

        File PgsqlSchemaParser.php has 457 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
        
        /**
         * MIT License. This file is part of the Propel package.
         * For the full copyright and license information, please view the LICENSE
        Severity: Minor
        Found in src/Propel/Generator/Reverse/PgsqlSchemaParser.php - About 7 hrs to fix

          Function addForeignKeys has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function addForeignKeys(Table $table): void
              {
                  $database = $table->getDatabase();
          
                  $dataFetcher = $this->dbh->query(sprintf('SHOW CREATE TABLE %s', $this->getPlatform()->doQuoting($table->getName())));
          Severity: Minor
          Found in src/Propel/Generator/Reverse/MysqlSchemaParser.php - About 6 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method startElement has 171 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function startElement($parser, string $tagName, array $attributes): void
              {
                  $parentTag = $this->peekCurrentSchemaTag();
                  if ($parentTag === false) {
                      switch ($tagName) {
          Severity: Major
          Found in src/Propel/Generator/Builder/Util/SchemaReader.php - About 6 hrs to fix

            Function setupReferrers has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
            Open

                public function setupReferrers(bool $throwErrors = false): void
                {
                    foreach ($this->foreignKeys as $foreignKey) {
                        // table referrers
                        $foreignTable = $this->database->getTable($foreignKey->getForeignTableName());
            Severity: Minor
            Found in src/Propel/Generator/Model/Table.php - About 6 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    foreach ($this->getTable()->getForeignKeys() as $fk) {
                        $relationName = $this->getFKPhpNameAffix($fk);
            
                        $script .= "
             * @method     $queryClass leftJoin" . $relationName . '($relationAlias = null) Adds a LEFT JOIN clause to the query using the ' . $relationName . " relation
            Severity: Major
            Found in src/Propel/Generator/Builder/Om/QueryBuilder.php and 1 other location - About 6 hrs to fix
            src/Propel/Generator/Builder/Om/QueryBuilder.php on lines 164..184

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 218.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    foreach ($this->getTable()->getReferrers() as $refFK) {
                        $relationName = $this->getRefFKPhpNameAffix($refFK);
            
                        $script .= "
             * @method     $queryClass leftJoin" . $relationName . '($relationAlias = null) Adds a LEFT JOIN clause to the query using the ' . $relationName . " relation
            Severity: Major
            Found in src/Propel/Generator/Builder/Om/QueryBuilder.php and 1 other location - About 6 hrs to fix
            src/Propel/Generator/Builder/Om/QueryBuilder.php on lines 143..163

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 218.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Join has 48 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class Join
            {
                // default comparison type
                /**
                 * @var string
            Severity: Minor
            Found in src/Propel/Runtime/ActiveQuery/Join.php - About 6 hrs to fix

              Function execute has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function execute(InputInterface $input, OutputInterface $output)
                  {
                      $configOptions = [];
              
                      if ($this->hasInputOption('output-dir', $input)) {
              Severity: Minor
              Found in src/Propel/Generator/Command/MigrationUpCommand.php - About 6 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function execute has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function execute(InputInterface $input, OutputInterface $output): int
                  {
                      $configOptions = [];
              
                      if ($this->hasInputOption('output-dir', $input)) {
              Severity: Minor
              Found in src/Propel/Generator/Command/MigrationDownCommand.php - About 6 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function compareTables has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function compareTables(bool $caseInsensitive = false): int
                  {
                      $fromDatabaseTables = $this->fromDatabase->getTables();
                      $toDatabaseTables = $this->toDatabase->getTables();
                      $databaseDifferences = 0;
              Severity: Minor
              Found in src/Propel/Generator/Model/Diff/DatabaseComparator.php - About 6 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function applyLimit has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function applyLimit(string &$sql, int $offset, int $limit, ?Criteria $criteria = null): void
                  {
                      // split the select and from clauses out of the original query
                      $selectStatement = '';
                      $fromStatement = '';
              Severity: Minor
              Found in src/Propel/Runtime/Adapter/Pdo/MssqlAdapter.php - About 6 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function __toString has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function __toString(): string
                  {
                      $ret = '';
                      $ret .= sprintf("  %s:\n", $this->fromTable->getName());
                      if ($addedColumns = $this->getAddedColumns()) {
              Severity: Minor
              Found in src/Propel/Generator/Model/Diff/TableDiff.php - About 6 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Collection has 46 functions (exceeds 20 allowed). Consider refactoring.
              Open

              class Collection implements ArrayAccess, IteratorAggregate, Countable, Serializable
              {
                  /**
                   * @var string
                   */
              Severity: Minor
              Found in src/Propel/Runtime/Collection/Collection.php - About 6 hrs to fix

                Function getNextStatement has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getNextStatement(): string
                    {
                        $isAfterBackslash = false;
                        $isInString = false;
                        $stringQuotes = '';
                Severity: Minor
                Found in src/Propel/Generator/Util/SqlParser.php - About 6 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function findMethod has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function findMethod(string $methodName)
                    {
                        if (isset($this->knownMethodCache[$methodName])) {
                            return $this->knownMethodCache[$methodName];
                        }
                Severity: Minor
                Found in src/Propel/Generator/Util/PhpParser.php - About 5 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method execute has 143 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected function execute(InputInterface $input, OutputInterface $output): int
                    {
                        $configOptions = [];
                
                        if ($this->hasInputOption('connection', $input)) {
                Severity: Major
                Found in src/Propel/Generator/Command/MigrationDiffCommand.php - About 5 hrs to fix

                  TableMapBuilder has 42 functions (exceeds 20 allowed). Consider refactoring.
                  Open

                  class TableMapBuilder extends AbstractOMBuilder
                  {
                      /**
                       * Gets the package for the map builder classes.
                       *
                  Severity: Minor
                  Found in src/Propel/Generator/Builder/Om/TableMapBuilder.php - About 5 hrs to fix
                    Severity
                    Category
                    Status
                    Source
                    Language