Sign upLogin

quack/quack

View on GitHub
Star

Showing 839 of 839 total issues

Method __construct has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct($reader)
    {
        $this->reader = $reader;
        $this->register('&(', new PartialFuncParselet);
        $this->register(Tag::T_INTEGER, new LiteralParselet);
Severity: Major
Found in src/parser/ExprParser.php - About 2 hrs to fix

    Console has 21 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Console
{
    private $stdin;
    private $stdout;
    private $stderr;
    Severity: Minor
    Found in src/cli/Console.php - About 2 hrs to fix

      Method getCroakBuffer has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function getCroakBuffer()
{
    $packing_method = 'S';
    $croak = realpath(dirname(__FILE__) . '/resource/quack.wav');
    $handle = fopen($croak, 'rb');
      Severity: Major
      Found in build.php - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        <?php
/**
 * Quack Compiler and toolkit
 * Copyright (C) 2015-2017 Quack and CONTRIBUTORS
 *
        Severity: Major
        Found in src/parselets/types/BinaryOperatorTypeParselet.php and 1 other location - About 1 hr to fix
        src/parselets/expr/BinaryOperatorParselet.php on lines 1..50

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 120.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        <?php
/**
 * Quack Compiler and toolkit
 * Copyright (C) 2015-2017 Quack and CONTRIBUTORS
 *
        Severity: Major
        Found in src/parselets/expr/BinaryOperatorParselet.php and 1 other location - About 1 hr to fix
        src/parselets/types/BinaryOperatorTypeParselet.php on lines 1..49

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 120.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function bundle has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

        function bundle($config)
{
    // Configuration
    $bundle = $config['bundle'];
    $resources = $config['resources'];
        Severity: Minor
        Found in build.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function group_sections has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

        def group_sections(input):
    """
    Receives an input and groups the sections
    """
    tok = 'none'
        Severity: Minor
        Found in tools/testsuite/run-tests.py - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function simplify has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            public function simplify()
    {
        $simple_left = $this->left->simplify();
        $simple_right = $this->right->simplify();
        Severity: Minor
        Found in src/ast/types/OperatorType.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid excessively long variable names like $serialized_byte_array. Keep variable name length under 20.
        Open

            $serialized_byte_array = json_encode($compressed_byte_array);
        Severity: Minor
        Found in build.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

        Source https://phpmd.org/rules/naming.html#longvariable

        Avoid excessively long variable names like $compressed_byte_array. Keep variable name length under 20.
        Open

            $compressed_byte_array = [];
        Severity: Minor
        Found in build.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

        Source https://phpmd.org/rules/naming.html#longvariable

        Avoid excessively long variable names like $received_arguments_count. Keep variable name length under 20.
        Open

                $received_arguments_count = count($arguments);
        Severity: Minor
        Found in src/ast/types/FunctionType.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

        Source https://phpmd.org/rules/naming.html#longvariable

        Method compile has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function compile($source, $silent = false)
    {
        if ('' === $source) {
            $this->resetState();
            return;
        Severity: Minor
        Found in src/cli/Repl.php - About 1 hr to fix

          Function injectScope has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              public function injectScope($parent_scope)
    {
        if (!$this->is_explicit) {
            // Check if there is an implicit label
            $label = $parent_scope->getMetaInContext(Meta::M_LABEL);
          Severity: Minor
          Found in src/ast/stmt/ContinueStmt.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function injectScope has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              public function injectScope($parent_scope)
    {
        if (!$this->is_explicit) {
            // Check if there is an implicit label
            $label = $parent_scope->getMetaInContext(Meta::M_LABEL);
          Severity: Minor
          Found in src/ast/stmt/BreakStmt.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method format has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function format(Parser $parser)
    {
        $source = '&';

        switch (count($this->parameters)) {
          Severity: Minor
          Found in src/ast/expr/LambdaExpr.php - About 1 hr to fix

            Method bundle has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function bundle($config)
{
    // Configuration
    $bundle = $config['bundle'];
    $resources = $config['resources'];
            Severity: Minor
            Found in build.php - About 1 hr to fix

              Function readFiles has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function readFiles()
    {
        $abstractions = [];
        $classes = [];
        $handle = opendir($this->path);
              Severity: Minor
              Found in build.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method nextToken has 35 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function nextToken()
    {
        while ($this->peek != self::EOF) {
            if (ctype_digit($this->peek)) {
                return $this->digit();
              Severity: Minor
              Found in src/lexer/Tokenizer.php - About 1 hr to fix

                Method _stmt has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function _stmt()
    {
        $stmt_list = [
            Tag::T_IF       => '_ifStmt',
            Tag::T_LET      => '_letStmt',
                Severity: Minor
                Found in src/parser/StmtParser.php - About 1 hr to fix

                  Avoid using short method names like Parser::is(). The configured minimum method name length is 3.
                  Open

                      public function is($tag)
    {
        return $this->lookahead->getTag() === $tag;
    }
                  Severity: Minor
                  Found in src/parser/Parser.php by phpmd

                  ShortMethodName

                  Since: 0.2

                  Detects when very short method names are used.

                  Example

                  class ShortMethod {
    public function a( $index ) { // Violation
    }
}

                  Source https://phpmd.org/rules/naming.html#shortmethodname

                  Severity
                  Category
                  Status
                  Source
                  Language