Sign upLogin

quyse/flaw

View on GitHub
Star

Showing 292 of 292 total issues

Use camelCase
Open

glBufferData_bs target bytes usage = B.unsafeUseAsCStringLen bytes $ \(bytesPtr, bytesLen) ->
  glBufferData target (fromIntegral bytesLen) bytesPtr usage
Severity: Minor
Found in flaw-gl/Flaw/Graphics/OpenGL/FFI.hs by hlint

Found

glBufferData_bs target bytes usage = ...

Perhaps

glBufferDataBs target bytes usage = ...

Use camelCase
Open

data MDB_cursor
Severity: Minor
Found in flaw-lmdb/Flaw/Data/Lmdb.hs by hlint

Found

data MDB_cursor

Perhaps

data MDBCursor

Use camelCase
Open

glBufferData_null :: GLenum -> GLsizeiptr -> GLenum -> IO ()
Severity: Minor
Found in flaw-gl/Flaw/Graphics/OpenGL/FFI.hs by hlint

Found

glBufferData_null :: GLenum -> GLsizeiptr -> GLenum -> IO ()

Perhaps

glBufferDataNull :: GLenum -> GLsizeiptr -> GLenum -> IO ()

Use camelCase
Open

glDrawBuffers_n :: Int -> IO ()
Severity: Minor
Found in flaw-gl/Flaw/Graphics/OpenGL/FFI.hs by hlint

Found

glDrawBuffers_n :: Int -> IO ()

Perhaps

glDrawBuffersN :: Int -> IO ()

Use camelCase
Open

glGetUniformLocation_s programName locationName = B.useAsCString (T.encodeUtf8 locationName) $ glGetUniformLocation programName
Severity: Minor
Found in flaw-gl/Flaw/Graphics/OpenGL/FFI.hs by hlint

Found

glGetUniformLocation_s programName locationName = ...

Perhaps

glGetUniformLocationS programName locationName = ...

Use camelCase
Open

newtype JS_WebGLShader = JS_WebGLShader JSVal
Severity: Minor
Found in flaw-gl/Flaw/Graphics/WebGL/FFI.hs by hlint

Found

newtype JS_WebGLShader = JS_WebGLShader JSVal

Perhaps

newtype JSWebGLShader = JSWebGLShader JSVal

Use camelCase
Open

glBufferData_bs target bytes usage = glBufferData_val target (byteStringToJsDataView bytes) usage
Severity: Minor
Found in flaw-gl/Flaw/Graphics/WebGL/FFI.hs by hlint

Found

glBufferData_bs target bytes usage = ...

Perhaps

glBufferDataBs target bytes usage = ...

Use camelCase
Open

glBufferData_bs :: GLenum -> B.ByteString -> GLenum -> IO ()
Severity: Minor
Found in flaw-gl/Flaw/Graphics/WebGL/FFI.hs by hlint

Found

glBufferData_bs :: GLenum -> B.ByteString -> GLenum -> IO ()

Perhaps

glBufferDataBs :: GLenum -> B.ByteString -> GLenum -> IO ()

Use camelCase
Open

type MDB_dbi = CUInt
Severity: Minor
Found in flaw-lmdb/Flaw/Data/Lmdb.hs by hlint

Found

type MDB_dbi = CUInt

Perhaps

type MDBDbi = CUInt

Redundant bracket
Open

          return $ (noBindS [| writeMutVar $(r a) $(kst nax) |]) : nextNextInstStmts
Severity: Minor
Found in flaw-lua/Flaw/Script/Lua/Chunk.hs by hlint

Found

(noBindS [| writeMutVar $( r a ) $( kst nax ) |]) :
  nextNextInstStmts

Perhaps

noBindS [| writeMutVar $( r a ) $( kst nax ) |] : nextNextInstStmts

Reduce duplication
Open

    srvInterface <- book bk $ allocateCOMObject $ with srvDesc $ \srvDescPtr ->
      createCOMObjectViaPtr $ m_ID3D11Device_CreateShaderResourceView deviceInterface (pokeCOMObject resourceInterface) srvDescPtr
Severity: Minor
Found in flaw-dx11/Flaw/Graphics/DirectX11.hs by hlint

Found

srvInterface <- book bk $
                  allocateCOMObject $
                    with srvDesc $
                      \ srvDescPtr ->
                        createCOMObjectViaPtr $
                          m_ID3D11Device_CreateShaderResourceView deviceInterface
                            (pokeCOMObject resourceInterface)
                            srvDescPtr
releaseResourceInterface
samplerState <- book bk $
                  createSamplerState device samplerStateInfo

Perhaps

Combine with flaw-dx11/Flaw/Graphics/DirectX11.hs:552:5

Use camelCase
Open

type C_lua_Reader = Ptr C_lua_State -> Ptr () -> Ptr CSize -> IO (Ptr CChar)
Severity: Minor
Found in flaw-lua/Flaw/Script/Lua/FFI.hs by hlint

Found

type C_lua_Reader =
    Ptr C_lua_State -> Ptr () -> Ptr CSize -> IO (Ptr CChar)

Perhaps

type CLuaReader =
    Ptr C_lua_State -> Ptr () -> Ptr CSize -> IO (Ptr CChar)

Use camelCase
Open

glShaderSource_s :: GLuint -> T.Text -> IO ()
Severity: Minor
Found in flaw-gl/Flaw/Graphics/OpenGL/FFI.hs by hlint

Found

glShaderSource_s :: GLuint -> T.Text -> IO ()

Perhaps

glShaderSourceS :: GLuint -> T.Text -> IO ()

Reduce duplication
Open

          pressed <- readTVar pressedVar
Severity: Minor
Found in flaw-ui/Flaw/UI/Button.hs by hlint

Found

pressed <- readTVar pressedVar
when pressed $
  do click
     writeTVar pressedVar False
return True

Perhaps

Combine with flaw-ui/Flaw/UI/Button.hs:160:9

Use guards
Open

      (visibleItems, firstVisibleItemOrderedIndex) =
        if topOrderedIndex <= 0 then (items, 0)
        else if topOrderedIndex >= S.size items then (S.empty, 0)
        else let
          ListBoxItem firstVisibleItemIndex firstVisibleItemKeyFunc firstVisibleItemValue = S.elemAt topOrderedIndex items
Severity: Minor
Found in flaw-ui/Flaw/UI/ListBox.hs by hlint

Found

(visibleItems, firstVisibleItemOrderedIndex)
  = if topOrderedIndex <= 0 then (items, 0) else
      if topOrderedIndex >= S.size items then (S.empty, 0) else
        let ListBoxItem firstVisibleItemIndex firstVisibleItemKeyFunc
              firstVisibleItemValue
              = S.elemAt topOrderedIndex items
          in
          (snd $
             S.split
               (ListBoxItem (firstVisibleItemIndex - 1) firstVisibleItemKeyFunc
                  firstVisibleItemValue)
               items,
           topOrderedIndex)

Perhaps

(visibleItems, firstVisibleItemOrderedIndex)
  | topOrderedIndex <= 0 = (items, 0)
  | topOrderedIndex >= S.size items = (S.empty, 0)
  | otherwise =
    let ListBoxItem firstVisibleItemIndex firstVisibleItemKeyFunc
          firstVisibleItemValue
          = S.elemAt topOrderedIndex items
      in
      (snd $
         S.split
           (ListBoxItem (firstVisibleItemIndex - 1) firstVisibleItemKeyFunc
              firstVisibleItemValue)
           items,
       topOrderedIndex)

Use camelCase
Open

data Hb_font_t
Severity: Minor
Found in flaw-font-fhi/Flaw/Graphics/Font/Harfbuzz.hs by hlint

Found

data Hb_font_t

Perhaps

data HbFontT

Use camelCase
Open

glGetProgramInfoLog_s :: GLuint -> IO T.Text
Severity: Minor
Found in flaw-gl/Flaw/Graphics/OpenGL/FFI.hs by hlint

Found

glGetProgramInfoLog_s :: GLuint -> IO T.Text

Perhaps

glGetProgramInfoLogS :: GLuint -> IO T.Text

Use camelCase
Open

glDrawBuffers_n colorBuffersCount =
  withArray [GL_COLOR_ATTACHMENT0 + fromIntegral i | i <- [0..(colorBuffersCount - 1)]] $
  glDrawBuffers $ fromIntegral colorBuffersCount
Severity: Minor
Found in flaw-gl/Flaw/Graphics/OpenGL/FFI.hs by hlint

Found

glDrawBuffers_n colorBuffersCount = ...

Perhaps

glDrawBuffersN colorBuffersCount = ...

Use camelCase
Open

newtype JS_WebGLBuffer = JS_WebGLBuffer JSVal
Severity: Minor
Found in flaw-gl/Flaw/Graphics/WebGL/FFI.hs by hlint

Found

newtype JS_WebGLBuffer = JS_WebGLBuffer JSVal

Perhaps

newtype JSWebGLBuffer = JSWebGLBuffer JSVal

Use camelCase
Open

data MDB_env
Severity: Minor
Found in flaw-lmdb/Flaw/Data/Lmdb.hs by hlint

Found

data MDB_env

Perhaps

data MDBEnv
Severity
Category
Status
Source
Language