rapid7/metasploit-framework

View on GitHub

Showing 15,831 of 21,886 total issues

Method try_user_pass has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
Open

  def try_user_pass(opts)
    user = opts[:user]
    pass = opts[:pass]
    auth_path = opts[:auth_path]
    inbox_path = opts[:inbox_path]
Severity: Minor
Found in modules/auxiliary/scanner/http/owa_login.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run_host has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
Open

  def run_host(ip)

    startstage = datastore['STARTATSTAGE']

    @nr_errors = datastore['STOPAFTER']
Severity: Minor
Found in modules/auxiliary/fuzzers/ftp/ftp_pre_post.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method exploit has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
Open

  def exploit
    # Get node_id for requests
    node_id = get_node
    fail_with(Failure::Unknown, 'Could not get a valid node id for the vBulletin install.') unless node_id

Severity: Minor
Found in modules/exploits/multi/http/vbulletin_getindexablecontent.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process_files has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
Open

  def process_files(username)
    secrets = ''
    masterkey = nil
    decrypt_table = Rex::Text::Table.new(
      'Header' => 'Decrypted data',
Severity: Minor
Found in modules/post/windows/gather/enum_chrome.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method format_prompt has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
Open

  def format_prompt(str)
    return str unless framework

    # find the active session
    session = framework.sessions.values.find { |session| session.interacting }
Severity: Minor
Found in lib/rex/ui/text/shell.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method start_element has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
Open

  def start_element(name=nil,attrs=[])
    attrs = normalize_attrs(attrs)
    block = @block
    @state[:current_tag][name] = true

Severity: Minor
Found in lib/rex/parser/openvas_document.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method report_vuln has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
Open

    def report_vuln(&block)
      return unless in_tag("VulnerabilityDefinitions")
      return unless @report_data[:vuln]
      return unless @report_data[:vuln][:matches].kind_of? Array

Severity: Minor
Found in lib/rex/parser/nexpose_raw_document.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method prepend_migrate has 201 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def prepend_migrate(buf)
    payloadsize = "0x%04x" % buf.length
    procname = datastore['PrependMigrateProc'] || 'rundll32'

    # Prepare instructions to get address of block_api into ebp
Severity: Major
Found in lib/msf/core/payload/windows/prepend_migrate.rb - About 1 day to fix

    Method run_host has 200 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run_host(ip)
    
        timeout = datastore['TIMEOUT'].to_i
    
        instances = datastore['INSTANCES']
    Severity: Major
    Found in modules/auxiliary/scanner/sap/sap_service_discovery.rb - About 1 day to fix

      Method build_t3_request_object has 200 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def build_t3_request_object
          # T3 request serialized data
          # retrieved by watching network traffic
          # This is a proprietary, undocumented protocol
      
      
      Severity: Major
      Found in modules/exploits/multi/misc/weblogic_deserialize_rawobject.rb - About 1 day to fix

        File encrypted_reverse_tcp.rb has 500 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        require 'rex/peparsey'
        require 'metasploit/framework/compiler/mingw'
        
        module Msf
        
        
        Severity: Minor
        Found in lib/msf/core/payload/windows/encrypted_reverse_tcp.rb - About 1 day to fix

          File http_form_field.rb has 499 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          class MetasploitModule < Msf::Auxiliary
            include Msf::Exploit::Remote::HttpClient
          
            def initialize(info = {})
              super(update_info(info,
          Severity: Minor
          Found in modules/auxiliary/fuzzers/http/http_form_field.rb - About 1 day to fix

            Method enum_instance has 199 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def enum_instance(rhost)
                print_status("#{rhost}:#{rport} [SAP] Connecting to SAP Management Console SOAP Interface")
                success = false
                soapenv='http://schemas.xmlsoap.org/soap/envelope/'
                xsi='http://www.w3.org/2001/XMLSchema-instance'
            Severity: Major
            Found in modules/auxiliary/scanner/sap/sap_mgmt_con_instanceproperties.rb - About 7 hrs to fix

              Method build_t3_request_object has 199 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def build_t3_request_object
                  # T3 request serialized data
                  # retrieved by watching network traffic
                  # This is a proprietary, undocumented protocol
                  data =  '000005c3'                                     # lenght of the packet
              Severity: Major
              Found in modules/exploits/multi/misc/weblogic_deserialize_unicastref.rb - About 7 hrs to fix

                File creds.rb has 497 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                require 'rexml/document'
                require 'metasploit/framework/password_crackers/hashcat/formatter'
                require 'metasploit/framework/password_crackers/jtr/formatter'
                
                module Msf
                Severity: Minor
                Found in lib/msf/ui/console/command_dispatcher/creds.rb - About 7 hrs to fix

                  Method cmd_nexpose_scan has 198 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                        def cmd_nexpose_scan(*args)
                          opts = Rex::Parser::Arguments.new(
                            '-h' => [ false, 'This help menu'],
                            '-t' => [ true, 'The scan template to use (default:pentest-audit options:full-audit,exhaustive-audit,discovery,aggressive-discovery,dos-audit)'],
                            '-c' => [ true, 'Specify credentials to use against these targets (format is type:user:pass'],
                  Severity: Major
                  Found in plugins/nexpose.rb - About 7 hrs to fix

                    Method enumerate_writable_path_dirs has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def enumerate_writable_path_dirs(path_dirs, user_groups, current_user)
                        writable_path_dirs = []
                        perms_we_need = ['(F)', '(M)']
                        print_status('')
                    
                    
                    Severity: Minor
                    Found in modules/exploits/windows/local/srclient_dll_hijacking.rb - About 7 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method get_crypto_keys has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def get_crypto_keys(log_folder)
                        # Run commands according to the session type
                        if session.type =~ /shell/
                    
                          # Enumerate and retreave files according to privilege level
                    Severity: Minor
                    Found in modules/post/osx/gather/enum_osx.rb - About 7 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method run has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def run
                        # check for meterpreter and version of ie
                        if (session.type != 'meterpreter') && session.platform !~ (/win/)
                          print_error('This module only works with Windows Meterpreter sessions')
                          return 0
                    Severity: Minor
                    Found in modules/post/windows/gather/enum_ie.rb - About 7 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method send_data has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def send_data(host,port)
                        self.status = {:write_allowed => true}
                        data_blocks = blockify_file_or_data()
                        if data_blocks.empty?
                          yield "Closing down since there is no data to send." if block_given?
                    Severity: Minor
                    Found in lib/rex/proto/tftp/client.rb - About 7 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language