Sign upLogin

reactrb/reactrb

View on GitHub
Star

Showing 108 of 108 total issues

Literal typeof ReactDOMServer === 'undefined' appeared as a condition.
Open

    if !(`typeof ReactDOMServer === 'undefined'`)
Severity: Minor
Found in lib/react/top_level.rb by rubocop

This cop checks for literals used as the conditions or as operands in and/or expressions serving as the conditions of if/while/until.

Example:

# bad

if 20
  do_something
end

Example:

# bad

if some_var && true
  do_something
end

Example:

# good

if some_var && some_condition
  do_something
end

Do not suppress exceptions.
Open

    rescue # What exception is being caught here?
Severity: Minor
Found in lib/reactive-ruby/component_loader.rb by rubocop

This cop checks for rescue blocks with no body.

Example:

# bad

def some_method
  do_something
rescue
  # do nothing
end

Example:

# bad

begin
  do_something
rescue
  # do nothing
end

Example:

# good

def some_method
  do_something
rescue
  handle_exception
end

Example:

# good

begin
  do_something
rescue
  handle_exception
end

Literal typeof ReactDOM === 'undefined' appeared as a condition.
Open

    if !(`typeof ReactDOM === 'undefined'`)
Severity: Minor
Found in lib/react/top_level.rb by rubocop

This cop checks for literals used as the conditions or as operands in and/or expressions serving as the conditions of if/while/until.

Example:

# bad

if 20
  do_something
end

Example:

# bad

if some_var && true
  do_something
end

Example:

# good

if some_var && some_condition
  do_something
end

Useless assignment to variable - container.
Open

    container = `container.$$class ? container[0] : container`
Severity: Minor
Found in lib/react/top_level.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

Literal React.findDOMNode !== undefined && #{native_inst}.nodeType === undefined appeared as a condition.
Open

            elsif `React.findDOMNode !== undefined && #{native_inst}.nodeType === undefined`
Severity: Minor
Found in lib/react/ref_callback.rb by rubocop

This cop checks for literals used as the conditions or as operands in and/or expressions serving as the conditions of if/while/until.

Example:

# bad

if 20
  do_something
end

Example:

# bad

if some_var && true
  do_something
end

Example:

# good

if some_var && some_condition
  do_something
end

Unused method argument - new_value. If it's necessary, use _ or _new_value as an argument name to indicate that it won't be used.
Open

    def []=(state, new_value)
Severity: Minor
Found in lib/react/state_wrapper.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Use delete instead of gsub.
Open

        super(top_level_name, props, options, &block).gsub("\n","")
Severity: Minor
Found in lib/reactive-ruby/rails/component_mount.rb by rubocop

This cop identifies places where gsub can be replaced by tr or delete.

Example:

# bad
'abc'.gsub('b', 'd')
'abc'.gsub('a', '')
'abc'.gsub(/a/, 'd')
'abc'.gsub!('a', 'd')

# good
'abc'.gsub(/.*/, 'a')
'abc'.gsub(/a+/, 'd')
'abc'.tr('b', 'd')
'a b c'.delete(' ')

Literal typeof ReactDOMServer === 'undefined' appeared as a condition.
Open

      if !(`typeof ReactDOMServer === 'undefined'`)
Severity: Minor
Found in lib/react/server.rb by rubocop

This cop checks for literals used as the conditions or as operands in and/or expressions serving as the conditions of if/while/until.

Example:

# bad

if 20
  do_something
end

Example:

# bad

if some_var && true
  do_something
end

Example:

# good

if some_var && some_condition
  do_something
end

Literal typeof ReactDOMServer === 'undefined' appeared as a condition.
Open

      if !(`typeof ReactDOMServer === 'undefined'`)
Severity: Minor
Found in lib/react/server.rb by rubocop

This cop checks for literals used as the conditions or as operands in and/or expressions serving as the conditions of if/while/until.

Example:

# bad

if 20
  do_something
end

Example:

# bad

if some_var && true
  do_something
end

Example:

# good

if some_var && some_condition
  do_something
end

Unused block argument - key. If it's necessary, use _ or _key as an argument name to indicate that it won't be used.
Open

        args[0].each do |key, value|
Severity: Minor
Found in lib/react/rendering_context.rb by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

Unused method argument - container. If it's necessary, use _ or _container as an argument name to indicate that it won't be used.
Open

  def self.render(element, container)
Severity: Minor
Found in lib/react/top_level_render.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Useless assignment to variable - cb.
Open

    cb = %x{
Severity: Minor
Found in lib/react/top_level_render.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

Avoid rescuing the Exception class. Perhaps you meant to rescue StandardError?
Open

      rescue Exception => e
        self.class.process_exception(e, self)
Severity: Minor
Found in lib/react/component.rb by rubocop

This cop checks for rescue blocks targeting the Exception class.

Example:

# bad

begin
  do_something
rescue Exception
  handle_exception
end

Example:

# good

begin
  do_something
rescue ArgumentError
  handle_exception
end

Literal #{self.to_n}._reactrb_component_class === undefined appeared as a condition.
Open

    if `#{self.to_n}._reactrb_component_class === undefined`
Severity: Minor
Found in lib/react/ext/opal-jquery/element.rb by rubocop

This cop checks for literals used as the conditions or as operands in and/or expressions serving as the conditions of if/while/until.

Example:

# bad

if 20
  do_something
end

Example:

# bad

if some_var && true
  do_something
end

Example:

# good

if some_var && some_condition
  do_something
end

Avoid rescuing the Exception class. Perhaps you meant to rescue StandardError?
Open

          rescue Exception
Severity: Minor
Found in lib/react/rendering_context.rb by rubocop

This cop checks for rescue blocks targeting the Exception class.

Example:

# bad

begin
  do_something
rescue Exception
  handle_exception
end

Example:

# good

begin
  do_something
rescue ArgumentError
  handle_exception
end

Useless assignment to variable - container.
Open

    container = `container.$$class ? container[0] : container`
Severity: Minor
Found in lib/react/top_level_render.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

Literal #{native_inst}._getOpalInstance !== undefined appeared as a condition.
Open

            if `#{native_inst}._getOpalInstance !== undefined`
Severity: Minor
Found in lib/react/ref_callback.rb by rubocop

This cop checks for literals used as the conditions or as operands in and/or expressions serving as the conditions of if/while/until.

Example:

# bad

if 20
  do_something
end

Example:

# bad

if some_var && true
  do_something
end

Example:

# good

if some_var && some_condition
  do_something
end

Variable Context used in void context.
Open

Hyperloop::Context
Severity: Minor
Found in lib/react/callbacks.rb by rubocop

This cop checks for operators, variables and literals used in void context.

Example:

# bad

def some_method
  some_num * 10
  do_something
end

Example:

# bad

def some_method(some_var)
  some_var
  do_something
end

Example:

# good

def some_method
  do_something
  some_num * 10
end

Example:

# good

def some_method(some_var)
  do_something
  some_var
end

Avoid rescuing the Exception class. Perhaps you meant to rescue StandardError?
Open

      rescue Exception => e
        self.class.process_exception(e, self)
Severity: Minor
Found in lib/react/component.rb by rubocop

This cop checks for rescue blocks targeting the Exception class.

Example:

# bad

begin
  do_something
rescue Exception
  handle_exception
end

Example:

# good

begin
  do_something
rescue ArgumentError
  handle_exception
end

Literal ReactTestUtils.isDOMComponent(#{native_instance}) && React.findDOMNode !== undefined appeared as a condition.
Open

        elsif `ReactTestUtils.isDOMComponent(#{native_instance}) && React.findDOMNode !== undefined`
Severity: Minor
Found in lib/react/test/utils.rb by rubocop

This cop checks for literals used as the conditions or as operands in and/or expressions serving as the conditions of if/while/until.

Example:

# bad

if 20
  do_something
end

Example:

# bad

if some_var && true
  do_something
end

Example:

# good

if some_var && some_condition
  do_something
end
Severity
Category
Status
Source
Language