Sign upLogin

resource-watch/document-adapter

View on GitHub
Star

Showing 92 of 92 total issues

Function convertQueryToElastic has 90 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    async convertQueryToElastic(parsed, index) {
        // search ST_GeoHash
        if (parsed.group || parsed.orderBy) {
            const mapping = await this.getMapping(index);
            if (parsed.group) {
Severity: Major
Found in app/src/services/queryService.js - About 3 hrs to fix

    Function init has 90 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        async init() {
        logger.debug('Scroll init');
        this.timeoutFunc = setTimeout(() => {
            this.timeout = true;
        }, 60000);
    Severity: Major
    Found in app/src/services/scroll.js - About 3 hrs to fix

      Function constructor has 88 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          constructor() {
        logger.info(`Connecting to Elasticsearch at ${elasticUri}`);

        const elasticSearchConfig = {
            node: elasticUri
      Severity: Major
      Found in app/src/services/queryService.js - About 3 hrs to fix

        Function convertDataToDownload has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
        Open

            convertDataToDownload(data, type, first, more, cloneUrl) {
        if (type === 'csv') {
            if (data.data.length === 0) {
                return '';
            }
        Severity: Minor
        Found in app/src/services/scroll.js - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function findIntersect has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
        Open

            findIntersect(node, finded, result) {
        if (node && node.type === 'string' && node.value && finded) {
            try {
                logger.debug(node.value);
                if (node.value.startsWith('\'')) {
        Severity: Minor
        Found in app/src/services/queryService.js - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function formatAlias has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
        Open

            static formatAlias(el, parsedQuery) {
        if (!parsedQuery || !el) {
            return el;
        }
        Severity: Minor
        Found in app/src/serializers/jsonSerializer.js - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function formatAlias has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
        Open

            static formatAlias(el, parsedQuery) {
        if (!parsedQuery || !el) {
            return el;
        }
        Severity: Minor
        Found in app/src/serializers/csvSerializer.js - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File queryService.js has 298 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        const logger = require('logger');
const config = require('config');
const sleep = require('sleep');
const elasticsearch = require('@elastic/elasticsearch');
const Scroll = require('services/scroll');
        Severity: Minor
        Found in app/src/services/queryService.js - About 3 hrs to fix

          Function serializeBucket has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
          Open

              static serializeBucket(key, buckets) {
        let list = [];
        let alias = key;
        if (key.indexOf('geohash') >= 0) {
            alias = 'geohash';
          Severity: Minor
          Found in app/src/serializers/csvSerializer.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                              if (node.type === 'function' && node.value.toLowerCase() === 'st_geohash') {
                        const args = [];
                        args.push({
                            type: 'literal',
                            value: 'field=\'the_geom_point\'',
          Severity: Major
          Found in app/src/services/queryService.js and 1 other location - About 2 hrs to fix
          app/src/services/queryService.js on lines 260..271

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 89.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                              if (node.value.toLowerCase() === 'st_geohash') {
                        const args = [];
                        args.push({
                            type: 'literal',
                            value: 'field=\'the_geom_point\'',
          Severity: Major
          Found in app/src/services/queryService.js and 1 other location - About 2 hrs to fix
          app/src/services/queryService.js on lines 201..223

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 89.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function exports has 63 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports = (grunt) => {

    grunt.file.setBase('..');
    // eslint-disable-next-line import/no-extraneous-dependencies
    require('load-grunt-tasks')(grunt);
          Severity: Major
          Found in app/Gruntfile.js - About 2 hrs to fix

            Function continue has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
            Open

                async continue() {

        if (this.resultScroll.aggregations) {
            const data = Scroll.serialize(this.resultScroll, this.parsed, this.format);
            this.stream.write(this.convertDataToDownload(data, this.format, true, false, this.cloneUrl), 'binary');
            Severity: Minor
            Found in app/src/services/scroll.js - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function constructor has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
            Open

                constructor() {
        logger.info(`Connecting to Elasticsearch at ${elasticUri}`);

        const elasticSearchConfig = {
            node: elasticUri
            Severity: Minor
            Found in app/src/services/queryService.js - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function serialize has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
            Open

                static serialize(data, parsed) {
        if (!data) {
            return {
                data: []
            };
            Severity: Minor
            Found in app/src/serializers/csvSerializer.js - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function toSQLMiddleware has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
            Open

            const toSQLMiddleware = async (ctx, next) => {

    const options = {
        method: 'GET',
        headers: {
            Severity: Minor
            Found in app/src/routes/api/v1/query.router.js - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function serialize has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
            Open

                static serialize(data, parsed, format = 'json') {
        if (!data) {
            return {
                data: []
            };
            Severity: Minor
            Found in app/src/serializers/jsonSerializer.js - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function toSQLMiddleware has 56 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            const toSQLMiddleware = async (ctx, next) => {

    const options = {
        method: 'GET',
        headers: {
            Severity: Major
            Found in app/src/routes/api/v1/query.router.js - About 2 hrs to fix

              Function serialize has 54 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  static serialize(data, parsed, format = 'json') {
        if (!data) {
            return {
                data: []
            };
              Severity: Major
              Found in app/src/serializers/jsonSerializer.js - About 2 hrs to fix

                Function serialize has 46 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    static serialize(data, parsed) {
        if (!data) {
            return {
                data: []
            };
                Severity: Minor
                Found in app/src/serializers/csvSerializer.js - About 1 hr to fix
                  Severity
                  Category
                  Status
                  Source
                  Language