Sign upLogin

ripple/ripple-rest

View on GitHub
Star

Showing 151 of 151 total issues

Function getParsedBookOffers has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function getParsedBookOffers(offers, isAsk) {
    return offers.reduce(function(orderBook, off) {
      var price;
      var order_maker = off.Account;
      var sequence = off.Sequence;
Severity: Minor
Found in api/orders.js - About 1 hr to fix

    Function submitPayment has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function submitPayment(account, payment, clientResourceID, secret,
    urlBase, options, callback) {

  function formatTransactionResponse(message, meta) {
    if (meta.state === 'validated') {
    Severity: Minor
    Found in api/payments.js - About 1 hr to fix

      Function validateOptions has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function validateOptions(options) {
  if (options.max_fee !== undefined) {
    validateNonNegativeStringFloat(options.max_fee, 'max_fee');
  }
  if (options.fixed_fee !== undefined) {
      Severity: Minor
      Found in api/lib/validate.js - About 1 hr to fix

        Function parsePaymentsFromPathFind has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function parsePaymentsFromPathFind(pathfindResults) {
  return pathfindResults.alternatives.map(function(alternative) {
    return {
      source_account: pathfindResults.source_account,
      source_tag: '',
        Severity: Minor
        Found in api/lib/tx-to-rest-converter.js - About 1 hr to fix

          Function transactionFilter has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function transactionFilter(transactions, options) {
  var filtered_transactions = transactions.filter(function(transaction) {
    if (options.exclude_failed) {
      if (transaction.state === 'failed' || (transaction.meta
          && transaction.meta.TransactionResult !== 'tesSUCCESS')) {
          Severity: Minor
          Found in api/transactions.js - About 1 hr to fix

            Function setTransactionBitFlags has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

            function setTransactionBitFlags(transaction, options) {
  for (var flagName in options.flags) {
    var flag = options.flags[flagName];

    // Set transaction flags
            Severity: Minor
            Found in api/transaction/utils.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function createTxJSON has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

            function createTxJSON(transaction, remote, instructions, callback) {
  instructions = instructions || {};
  validate.options(instructions);

  transaction.complete();
            Severity: Minor
            Found in api/transaction/utils.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (baseTransactionIndex + 1 < txns.length) {
      var next_transaction = txns[baseTransactionIndex + 1];
      notificationDetails.next_transaction_identifier =
        (next_transaction.from_local_db ?
            next_transaction.client_resource_id : next_transaction.hash);
            Severity: Major
            Found in api/notifications.js and 1 other location - About 1 hr to fix
            api/notifications.js on lines 121..127

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (baseTransactionIndex > 0) {
      var previous_transaction = txns[baseTransactionIndex - 1];
      notificationDetails.previous_transaction_identifier =
        (previous_transaction.from_local_db ?
          previous_transaction.client_resource_id : previous_transaction.hash);
            Severity: Major
            Found in api/notifications.js and 1 other location - About 1 hr to fix
            api/notifications.js on lines 131..137

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function generateIndexPage has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function generateIndexPage(request, response, next) {
  var url_base = '/v' + version.getApiVersion();

  respond.success(response, {
    success: true,
            Severity: Minor
            Found in server/indexpage.js - About 1 hr to fix

              Function getAccountOrders has 34 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                function getAccountOrders(prevResult) {
    var isAggregate = options.limit === 'all';
    if (prevResult && (!isAggregate || !prevResult.marker)) {
      return Promise.resolve(prevResult);
    }
              Severity: Minor
              Found in api/orders.js - About 1 hr to fix

                Function getTransaction has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                DI.getTransaction = function(options, callback) {
  assert.strictEqual(typeof options, 'object');

  var txQuery = {};
                Severity: Minor
                Found in api/lib/db-interface.js - About 1 hr to fix

                  Function init has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  DI.init = function(callback) {
  var self = this;

  if (this.initialized) {
    self.logger.info('[DB] Warning: Re-initializing');
                  Severity: Minor
                  Found in api/lib/db-interface.js - About 1 hr to fix

                    Function parseNotifications has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      function parseNotifications(baseTransactions, _callback) {
    var numTransactions = baseTransactions.length;

    function parseNotification(transaction, __callback) {
      var args = {
                    Severity: Minor
                    Found in api/notifications.js - About 1 hr to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                      module.exports = {
  InvalidRequestError: InvalidRequestError,
  NetworkError: NetworkError,
  TransactionError: TransactionError,
  RippledNetworkError: RippledNetworkError,
                      Severity: Major
                      Found in api/lib/errors.js and 1 other location - About 1 hr to fix
                      server/response-handler.js on lines 204..215

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 62.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                      module.exports = {
  success: success,
  created: created,
  transactionError: transactionError,
  transactionNotFoundError: transactionNotFoundError,
                      Severity: Major
                      Found in server/response-handler.js and 1 other location - About 1 hr to fix
                      api/lib/errors.js on lines 106..117

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 62.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Function getFailedTransactions has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      DI.getFailedTransactions = function(options, callback) {
  assert.strictEqual(typeof options, 'object');
  assert.strictEqual(typeof options.account, 'string');
  assert(ripple.UInt160.is_valid(options.account),
         'Specified account is invalid');
                      Severity: Minor
                      Found in api/lib/db-interface.js - About 1 hr to fix

                        Function filtered_transactions has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          var filtered_transactions = transactions.filter(function(transaction) {
    if (options.exclude_failed) {
      if (transaction.state === 'failed' || (transaction.meta
          && transaction.meta.TransactionResult !== 'tesSUCCESS')) {
        return false;
                        Severity: Minor
                        Found in api/transactions.js - About 1 hr to fix

                          Function createTxJSON has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          function createTxJSON(transaction, remote, instructions, callback) {
  instructions = instructions || {};
  validate.options(instructions);

  transaction.complete();
                          Severity: Minor
                          Found in api/transaction/utils.js - About 1 hr to fix

                            Function validateOptions has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                            Open

                            function validateOptions(options) {
  if (options.max_fee !== undefined) {
    validateNonNegativeStringFloat(options.max_fee, 'max_fee');
  }
  if (options.fixed_fee !== undefined) {
                            Severity: Minor
                            Found in api/lib/validate.js - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language