ros-testing/hypothesis-ros

View on GitHub
hypothesis_ros/messages/geometry_msgs.py

Summary

Maintainability
D
2 days
Test Coverage

Function quaternion has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def quaternion(draw, x=float64(), y=float64(), z=float64(), w=float64()):
Severity: Minor
Found in hypothesis_ros/messages/geometry_msgs.py - About 35 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    @composite
    def vector3(draw, x=float64(), y=float64(), z=float64()):
        """
        Generate value for ROS geometry message type "vector3".
    
    
    Severity: Major
    Found in hypothesis_ros/messages/geometry_msgs.py and 1 other location - About 6 hrs to fix
    hypothesis_ros/messages/geometry_msgs.py on lines 30..49

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 109.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    @composite
    def point(draw, x=float64(), y=float64(), z=float64()):
        """
        Generate value for ROS geometry message type "point".
    
    
    Severity: Major
    Found in hypothesis_ros/messages/geometry_msgs.py and 1 other location - About 6 hrs to fix
    hypothesis_ros/messages/geometry_msgs.py on lines 115..134

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 109.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    @composite
    def transform(draw, translation=vector3(), rotation=quaternion()):
        """
        Generate value for ROS geometry message type "transform".
    
    
    Severity: Major
    Found in hypothesis_ros/messages/geometry_msgs.py and 3 other locations - About 4 hrs to fix
    hypothesis_ros/message_fields.py on lines 354..375
    hypothesis_ros/message_fields.py on lines 378..399
    hypothesis_ros/messages/geometry_msgs.py on lines 77..93

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 81.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    @composite
    def pose(draw, position=point(), orientation=quaternion()):
        """
        Generate value for ROS geometry message type "pose".
    
    
    Severity: Major
    Found in hypothesis_ros/messages/geometry_msgs.py and 3 other locations - About 4 hrs to fix
    hypothesis_ros/message_fields.py on lines 354..375
    hypothesis_ros/message_fields.py on lines 378..399
    hypothesis_ros/messages/geometry_msgs.py on lines 137..153

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 81.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status