ros-testing/hypothesis-ros

View on GitHub

Showing 32 of 32 total issues

Similar blocks of code found in 8 locations. Consider refactoring.
Open

@defines_strategy
def int64(min_value=INT64_MIN_VALUE, max_value=INT64_MAX_VALUE):
    """
    Generate value for ROS1 builtin message type "int64".

Severity: Major
Found in hypothesis_ros/message_fields.py and 7 other locations - About 1 hr to fix
hypothesis_ros/message_fields.py on lines 97..116
hypothesis_ros/message_fields.py on lines 119..138
hypothesis_ros/message_fields.py on lines 141..160
hypothesis_ros/message_fields.py on lines 163..182
hypothesis_ros/message_fields.py on lines 185..204
hypothesis_ros/message_fields.py on lines 207..226
hypothesis_ros/message_fields.py on lines 251..270

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

@defines_strategy
def uint64(min_value=UINT64_MIN_VALUE, max_value=UINT64_MAX_VALUE):
    """
    Generate value for ROS1 builtin message type "uint64".

Severity: Major
Found in hypothesis_ros/message_fields.py and 7 other locations - About 1 hr to fix
hypothesis_ros/message_fields.py on lines 97..116
hypothesis_ros/message_fields.py on lines 119..138
hypothesis_ros/message_fields.py on lines 141..160
hypothesis_ros/message_fields.py on lines 163..182
hypothesis_ros/message_fields.py on lines 185..204
hypothesis_ros/message_fields.py on lines 207..226
hypothesis_ros/message_fields.py on lines 229..248

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function camera_info has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

def camera_info(draw,
Severity: Major
Found in hypothesis_ros/messages/sensor_msgs.py - About 1 hr to fix

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    @defines_strategy
    def int16(min_value=INT16_MIN_VALUE, max_value=INT16_MAX_VALUE):
        """
        Generate value for ROS1 builtin message type "int16".
    
    
    Severity: Major
    Found in hypothesis_ros/message_fields.py and 7 other locations - About 1 hr to fix
    hypothesis_ros/message_fields.py on lines 97..116
    hypothesis_ros/message_fields.py on lines 119..138
    hypothesis_ros/message_fields.py on lines 163..182
    hypothesis_ros/message_fields.py on lines 185..204
    hypothesis_ros/message_fields.py on lines 207..226
    hypothesis_ros/message_fields.py on lines 229..248
    hypothesis_ros/message_fields.py on lines 251..270

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 44.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

    @defines_strategy
    def int32(min_value=INT32_MIN_VALUE, max_value=INT32_MAX_VALUE):
        """
        Generate value for ROS1 builtin message type "int32".
    
    
    Severity: Major
    Found in hypothesis_ros/message_fields.py and 7 other locations - About 1 hr to fix
    hypothesis_ros/message_fields.py on lines 97..116
    hypothesis_ros/message_fields.py on lines 119..138
    hypothesis_ros/message_fields.py on lines 141..160
    hypothesis_ros/message_fields.py on lines 163..182
    hypothesis_ros/message_fields.py on lines 207..226
    hypothesis_ros/message_fields.py on lines 229..248
    hypothesis_ros/message_fields.py on lines 251..270

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 44.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function log has 10 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def log(draw,  # DEBUG=uint8(), INFO=uint8(), WARN=uint8(), ERROR=uint8(), FATAL=uint8(),
    Severity: Major
    Found in hypothesis_ros/messages/rosgraph_msgs.py - About 1 hr to fix

      Function disparity_image has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def disparity_image(draw, header=header(), image=image(), f=float32(), t=float32(), valid_window=region_of_interest(), min_disparity=float32(), max_disparity=float32(), delta_d=float32()):
      Severity: Major
      Found in hypothesis_ros/messages/stereo_msgs.py - About 1 hr to fix

        Function image has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def image(draw,
        Severity: Major
        Found in hypothesis_ros/messages/sensor_msgs.py - About 1 hr to fix

          Function imu has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def imu(draw,
          Severity: Major
          Found in hypothesis_ros/messages/sensor_msgs.py - About 1 hr to fix

            Function region_of_interest has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def region_of_interest(draw,  # pylint: disable=too-many-arguments
            Severity: Major
            Found in hypothesis_ros/messages/sensor_msgs.py - About 50 mins to fix

              Function array has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def array(elements=None, min_size=None, max_size=None, unique_by=None, unique=None):
              Severity: Minor
              Found in hypothesis_ros/message_fields.py - About 35 mins to fix

                Function quaternion has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                def quaternion(draw, x=float64(), y=float64(), z=float64(), w=float64()):
                Severity: Minor
                Found in hypothesis_ros/messages/geometry_msgs.py - About 35 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language